xoops forums

Mamba

Moderator
Posted on: 2009/8/11 6:01
Mamba
Mamba (Show more)
Moderator
Posts: 10818
Since: 2004/4/23
#11

Re: First comments on 2.4

Quote:
xoopseditor is too big size

In the final release, there will be only few editors.

Right now, because it's Beta, we wanted to have the whole package included for testing, so we can address potential bugs

frankblack

Just can't stay away
Posted on: 2009/8/11 7:01
frankblack
frankblack (Show more)
Just can't stay away
Posts: 830
Since: 2005/6/13
#12

Re: First comments on 2.4

Quote:
I have updated 4 or 5 files in smarty. Some times is your php editor that does that. Are you using eclipse? Can you point me one of that files so I can check here?


Yes, I am using eclipse. class/smarty/plugins/modifier.cat.php or class/smarty/xoops_plugins/modifier.debug_print_var.php

I heard about the virtual closing of php files. But there should be a consistency in the files. Closing tag yes or no, this is the question.

ghia

Community Support Member
Posted on: 2009/8/11 7:52
ghia
ghia (Show more)
Community Support Member
Posts: 4954
Since: 2008/7/3 1
#13

Re: First comments on 2.4

Quote:
Closing tag yes or no, this is the question.
I should always add the closing tags for the sake of clear and clean code.

hervet

Friend of XOOPS
Posted on: 2009/8/11 8:04
hervet
hervet (Show more)
Friend of XOOPS
Posts: 2267
Since: 2003/11/4
#14

Re: First comments on 2.4

Quote:

Quote:
Closing tag yes or no, this is the question.
I should always add the closing tags for the sake of clear and clean code.

I even don't understand how this can be discussed !
A Php script starts with <?php and end with ?>
If you can't do it, don't code

frankblack

Just can't stay away
Posted on: 2009/8/11 8:19
frankblack
frankblack (Show more)
Just can't stay away
Posts: 830
Since: 2005/6/13
#15

Re: First comments on 2.4

Quote:
I even don't understand how this can be discussed ! A Php script starts with If you can't do it, don't code


Opinions differ from THIS to THIS.

I prefer closing the tag, because it seems "natural" to me.

ghia

Community Support Member
Posted on: 2009/8/11 9:33
ghia
ghia (Show more)
Community Support Member
Posts: 4954
Since: 2008/7/3 1
#16

Re: First comments on 2.4

Altough officially not required, I prefer to not ommit them.
But programmers are such lazy people!

kaotik

Just can't stay away
Posted on: 2009/8/11 9:55
kaotik
kaotik (Show more)
Just can't stay away
Posts: 861
Since: 2004/2/19
#17

Re: First comments on 2.4

There's another reason for supporting closing tags. When using a wysiwyg editor, the php closing tab is crucial when you have php and html on the same page, otherwise the editor gets the whole page screwed up.

trabis

Core Developer
Posted on: 2009/8/11 11:10
trabis
trabis (Show more)
Core Developer
Posts: 2268
Since: 2006/9/1 1
#18

Re: First comments on 2.4

Good programmers are lazy but lazy does not mean omitting closing tag, lol. Lazy goes for encapsulating code so it can be reused.
I go for Zend's word. Closing tag should not be used for "php only" scipts.
But my code is my code, core is core. If core uses closing tag we should use closing tag when submitting to core.

wishcraft

Module Developer
Posted on: 2009/8/11 12:16
wishcraft
wishcraft (Show more)
Module Developer
Posts: 3711
Since: 2007/5/18
#19

Re: First comments on 2.4

There is no hashing overhead trabis, i am running it on 2.4.0 on www.chronolabs.org.au, it has 32mbs, all the hashing adds is 44 bytes of data to the total object size, how could that overhead anything. It is also running on the old key that originally would drop blocks when you edited the block trabis.

I noticed the upgrade doesn't have the latest upgrade when I downloaded it from sourceforge, I am not sure why that wasn't packaged.
Quote:

Speks of Chronolabs::

Apache Version :: 2.2.11 (Unix)
PHP Version :: 5.2.9
MySQL Version :: 5.0.77-community
Disk Space Bandwidth :: 8886.02/99999 MB
Monthly Bandwidth :: 2540.87/9999999999 MB

wishcraft

Module Developer
Posted on: 2009/8/11 12:20
wishcraft
wishcraft (Show more)
Module Developer
Posts: 3711
Since: 2007/5/18
#20

Re: First comments on 2.4

Those editor for example the XOOPS code to connect to them is written by the authors of the objects, personally I prefer Flash editors like xihane and others. Java is clunky the flash editors are so smooth with so many options.

I will review the code, I just wanted the orginal author code to connect it to XOOPS in there, as you know with typie typie, best from the author and client. Yeah I wrote to each one and asked each individual to write the code for the plug-in bit, i am still waiting on the example i wrote for jpgraph, i don't think some authors understand the importance of a plug-in.