XOOPS 
Forum
Forum Index General Forums Community Support Modules Support Themes Support Development International Support Module Hack Reviews Theme Designer Talk
  1. Board index / 
  2. XOOPS Community Support forums / 
  3. 2.4.x Support 
  4.  / First comments on 2.4
Register
11
Mamba
Re: First comments on 2.4

  • 2009/8/11 6:01

  • Mamba

  • Moderator

  • Posts: 11409

  • Since: 2004/4/23


Quote:
xoopseditor is too big size

In the final release, there will be only few editors.

Right now, because it's Beta, we wanted to have the whole package included for testing, so we can address potential bugs
12
frankblack
Re: First comments on 2.4

  • 2009/8/11 7:01

  • frankblack

  • Just can't stay away

  • Posts: 830

  • Since: 2005/6/13


Quote:
I have updated 4 or 5 files in smarty. Some times is your php editor that does that. Are you using eclipse? Can you point me one of that files so I can check here?


Yes, I am using eclipse. class/smarty/plugins/modifier.cat.php or class/smarty/xoops_plugins/modifier.debug_print_var.php

I heard about the virtual closing of php files. But there should be a consistency in the files. Closing tag yes or no, this is the question.
13
ghia
Re: First comments on 2.4

  • 2009/8/11 7:52

  • ghia

  • Community Support Member

  • Posts: 4953

  • Since: 2008/7/3 1


Quote:
Closing tag yes or no, this is the question.
I should always add the closing tags for the sake of clear and clean code.
14
hervet
Re: First comments on 2.4

  • 2009/8/11 8:04

  • hervet

  • Friend of XOOPS

  • Posts: 2267

  • Since: 2003/11/4


Quote:

Quote:
Closing tag yes or no, this is the question.
I should always add the closing tags for the sake of clear and clean code.

I even don't understand how this can be discussed !
A Php script starts with
If you can't do it, don't code
15
frankblack
Re: First comments on 2.4

  • 2009/8/11 8:19

  • frankblack

  • Just can't stay away

  • Posts: 830

  • Since: 2005/6/13


Quote:
I even don't understand how this can be discussed ! A Php script starts with If you can't do it, don't code
Opinions differ from THIS to THIS. I prefer closing the tag, because it seems "natural" to me.
16
ghia
Re: First comments on 2.4

  • 2009/8/11 9:33

  • ghia

  • Community Support Member

  • Posts: 4953

  • Since: 2008/7/3 1


Altough officially not required, I prefer to not ommit them.
But programmers are such lazy people!
17
kaotik
Re: First comments on 2.4

  • 2009/8/11 9:55

  • kaotik

  • Just can't stay away

  • Posts: 861

  • Since: 2004/2/19


There's another reason for supporting closing tags. When using a wysiwyg editor, the php closing tab is crucial when you have php and html on the same page, otherwise the editor gets the whole page screwed up.
18
trabis
Re: First comments on 2.4

  • 2009/8/11 11:10

  • trabis

  • Core Developer

  • Posts: 2269

  • Since: 2006/9/1 1


Good programmers are lazy but lazy does not mean omitting closing tag, lol. Lazy goes for encapsulating code so it can be reused.
I go for Zend's word. Closing tag should not be used for "php only" scipts.
But my code is my code, core is core. If core uses closing tag we should use closing tag when submitting to core.
19
wishcraft
Re: First comments on 2.4

There is no hashing overhead trabis, i am running it on 2.4.0 on http://www.chronolabs.org.au, it has 32mbs, all the hashing adds is 44 bytes of data to the total object size, how could that overhead anything. It is also running on the old key that originally would drop blocks when you edited the block trabis.

I noticed the upgrade doesn't have the latest upgrade when I downloaded it from sourceforge, I am not sure why that wasn't packaged.
Quote:

Speks of Chronolabs::

Apache Version :: 2.2.11 (Unix)
PHP Version :: 5.2.9
MySQL Version :: 5.0.77-community
Disk Space Bandwidth :: 8886.02/99999 MB
Monthly Bandwidth :: 2540.87/9999999999 MB
20
wishcraft
Re: First comments on 2.4

Those editor for example the XOOPS code to connect to them is written by the authors of the objects, personally I prefer Flash editors like xihane and others. Java is clunky the flash editors are so smooth with so many options.

I will review the code, I just wanted the orginal author code to connect it to XOOPS in there, as you know with typie typie, best from the author and client. Yeah I wrote to each one and asked each individual to write the code for the plug-in bit, i am still waiting on the example i wrote for jpgraph, i don't think some authors understand the importance of a plug-in.
« 1 (2) 3 4 5 »

Login

Register now!  |  Lost Password?

Search

Advanced Search

Recent Posts

Who's Online

332 user(s) are online (202 user(s) are browsing Support Forums)

Members: 0

Guests: 332

more...

Donat-O-Meter

Stats
Goal: $100.00
Due Date: Nov 30
Gross Amount: $0.00
Net Balance: $0.00
Left to go: $100.00
Make donations with PayPal!

Latest GitHub Commits