37
OK, I found and fixed the problem with the topic images as well. It turns out the story.picture variable was set to the path (without a picture name), even if there was no picture, hence never making it empty, as the template checks for.
To fix it, the following should be changed in class.newsstory.php, line 684:
The original code
$story['picture'] = XOOPS_URL.'/uploads/news/image/'.$this->picture();
should be changed to
if ($this->picture() != ''){
$story['picture'] = XOOPS_URL.'/uploads/news/image/'.$this->picture();
} else {
$story['picture'] = '';
}
That's all the bugs I've found so far (I can't reproduce Cesag's warning errors, but the deprecated class is there of course). However, regarding attaching a picture that is shown instead of the topic image, a nice touch to add in the next version would be to make it possible to control the position of the attached picture or at least make it controlled by the "regular" position control for the topic image, so that it doesn't have to be aligned to the right.
