XOOPS 
Forum
Forum Index General Forums Community Support Modules Support Themes Support Development International Support Module Hack Reviews Theme Designer Talk
  1. Board index / 
  2. XOOPS Modules Support forums / 
  3. Module troubleshooting 
  4.  / XHelp Pop email Not working - Cron help
Register
21
ghia
Re: XHelp Pop email Not working - Cron help

  • 2010/6/18 9:33

  • ghia

  • Community Support Member

  • Posts: 4953

  • Since: 2008/7/3 1


Seems it can log on to the email box.
Are you sure there was a message in the box?
Because then after the
10:39:02 960 POP3 command: STAT
there would be a
10:39:02 960 POP3 command: RETR 1
22
hezina
Re: XHelp Pop email Not working - Cron help

  • 2010/6/18 10:16

  • hezina

  • Just popping in

  • Posts: 3

  • Since: 2010/6/18


yes .. log in mailbox is OK... STAT is OK to ... now i'm on next steps...

need some changes on

kernel/member.php line 25 and 26

include/xoopslocal.php line 35

include/functions.php line 148

Fatal error: Call to a member function path() on a non-object in /srv/www/vhosts/BDOIntranet/include/functions.php on line 148


any idea?
23
TDE-Drums
Re: XHelp Pop email Not working - Cron help

  • 2010/6/18 16:51

  • TDE-Drums

  • Just popping in

  • Posts: 29

  • Since: 2010/6/14


I'm getting a bunch of different errors as well, but not sure if it is all the timing of different file changes. The last error on my log for the module is this.. and it is the same error for every minute of the day.

[18-Jun-2010 10:44:02] PHP Fatal error: Call to a member function path() on a non-object in /home1/........./public_html/drumquestion/kernel/member.php on line 25

I had this error back on the 17th but that might be because I added that last file change at the end of this form post.

17-Jun-2010 20:42:01] PHP Fatal error: require() [function.require]: Failed opening required '../../mainfile.php' (include_path='.:/usr/lib64/php:/usr/lib/php') in /home1/........./public_html/drumquestion/modules/xhelp/servicemain.php on line 6

I do need to mention I have 6 unread emails sitting in the mail box, so I know they are there.

David
24
ghia
Re: XHelp Pop email Not working - Cron help

  • 2010/6/18 18:43

  • ghia

  • Community Support Member

  • Posts: 4953

  • Since: 2008/7/3 1


If you need automatic user creation, then you must do also following replacements:
in /class/xoopsmailer.php
include_once $GLOBALS['xoops']->path('class/mail/xoopsmultimailer.php');

to
include_once XOOPS_ROOT_PATH.'/class/mail/xoopsmultimailer.php';

in /kernel/member.php
require_once $GLOBALS['xoops']->path('kernel/user.php');
require_once $GLOBALS['xoops']->path('kernel/group.php');
to
require_once XOOPS_ROOT_PATH.'/kernel/user.php';
require_once XOOPS_ROOT_PATH.'/kernel/group.php';

in /kernel/module.php function loadInfo
if (file_exists($file = $GLOBALS['xoops']->path('modules/' . $dirname . '/language/' . $xoopsConfig['language'] . '/modinfo.php'))) {
            include_once $file;
        } else if (file_exists($file = $GLOBALS['xoops']->path('modules/' . $dirname . '/language/english/modinfo.php'))) {
            include_once $file;
        }

        if (!file_exists($file = $GLOBALS['xoops']->path('modules/' . $dirname . '/xoops_version.php'))) {
to
if (file_exists($file = XOOPS_ROOT_PATH.'/modules/' . $dirname . '/language/' . $xoopsConfig['language'] . '/modinfo.php')) {
            include_once $file;
        } else if (file_exists($file = XOOPS_ROOT_PATH.'/modules/' . $dirname . '/language/english/modinfo.php')) {
            include_once $file;
        }

        if (!file_exists($file = XOOPS_ROOT_PATH.'/modules/' . $dirname . '/xoops_version.php')) {

function search
if (file_exists($file = $GLOBALS['xoops']->path('modules/' . $this->getVar('dirname') . '/' . $search['file']))) {
to
if (file_exists($file = XOOPS_ROOT_PATH.'/modules/' . $this->getVar('dirname') . '/' . $search['file'])) {

in /include/xoopslocal.php
require $GLOBALS['xoops']->path('class/xoopslocal.php');

to
require XOOPS_ROOT_PATH.'/class/xoopslocal.php';
in /include/functions.php function xoops_loadLanguage
if (!file_exists($fileinc = $GLOBALS['xoops']->path("{$path}/{$language}/{$name}.php" ))) {
        if (!file_exists( $fileinc = $GLOBALS['xoops']->path("{$path}/english/{$name}.php"))) {
to
if (!file_exists($fileinc = XOOPS_ROOT_PATH."/{$path}/{$language}/{$name}.php" )) {
        if (!file_exists( $fileinc = XOOPS_ROOT_PATH."/{$path}/english/{$name}.php")) {
function xoops_header
if (file_exists($GLOBALS['xoops']->path('language/' . $language . '/style.css'))) {
to
if (file_exists(XOOPS_ROOT_PATH.'/language/' . $language . '/style.css')) {


Your last error with mainfile.php may indicate you are not executing the checkemail from within the right directory. It should be from /modules/xhelp/

The mailbox not having messages was in response to the POP3 log of hezina.

25
Peekay
Re: XHelp Pop email Not working - Cron help

  • 2010/6/18 23:45

  • Peekay

  • XOOPS is my life!

  • Posts: 2335

  • Since: 2004/11/20


I am impressed by your support for this issue Ghia... but if TDE-Drums makes this change and it turns out that the problem centres on the change in xoopsmailer.php from:

(XOOPS_ROOT_PATH."/class/mail/xoopsmultimailer.php");

to
$GLOBALS['xoops']->path('class/mail/xoopsmultimailer.php');

my question is, why has this method been changed and what benefits in terms of speed, efficiency and security are we gaining from that change?
A thread is for life. Not just for Christmas.
26
ghia
Re: XHelp Pop email Not working - Cron help

  • 2010/6/19 0:00

  • ghia

  • Community Support Member

  • Posts: 4953

  • Since: 2008/7/3 1


None. It is done by an object and it set the slashes according the OS, altough I don't know of complaints as that Windows would not allow paths with the Linux /
This is the function:
function path($url, $virtual = false)
    {
        // removed , $error_type = E_USER_WARNING
        $path = '';
        @list($root, $path) = explode('/', $url, 2);
        if (!isset($this->paths[$root])) {
            list($root, $path) = array('www', $url);
        }
        if (!$virtual) { // Returns a physical path
            $path = $this->paths[$root][0] . '/' . $path;
            $path = str_replace('/', DS, $path);
            return $path;
        }
        return !isset($this->paths[$root][1] ) ? '' : ($this->paths[$root][1] . '/' . $path);
    }

BTW my change is the reverse.
27
Peekay
Re: XHelp Pop email Not working - Cron help

  • 2010/6/19 0:04

  • Peekay

  • XOOPS is my life!

  • Posts: 2335

  • Since: 2004/11/20


Thx Ghia. All my Xoops sites are developed on Windows IIS. Never had a problem with XOOPS_URL or forward slashes. In fact, you have to use forward slashes.

It may not be the problem, but it would be a shame if this has broken a perfectly good module.
A thread is for life. Not just for Christmas.
28
phppp
Re: XHelp Pop email Not working - Cron help

  • 2010/6/19 3:06

  • phppp

  • XOOPS Contributor

  • Posts: 2857

  • Since: 2004/1/25


Quote:

Peekay wrote:
my question is, why has this method been changed and what benefits in terms of speed, efficiency and security are we gaining from that change?


It is not a good change and I also have the same question.
Unfortunately it is too late to revert or refactor many similar changes in 2.4*.
It seems at this moment the practical solution is to keep as it as and provide patches once bugs are discovered.
29
TDE-Drums
Re: XHelp Pop email Not working - Cron help

  • 2010/6/19 4:41

  • TDE-Drums

  • Just popping in

  • Posts: 29

  • Since: 2010/6/14


I'm kind of lost at this point. Not sure if the code is for me to resolve the email problem or for other user fixes.

My xoops is working OK and all my xhelp is performing well except the POP email part.

My second error I believe was because I messed up the code, that error is no longer happening.

Is there someone in the community that can help me with this privately as well as 3 other small problems, then the fix can be posted here.

Someone to take a closer look at my situation?

I would like to get this fixed if I could work directly with a xoops .PHP programmer.

I know Ghia is really trying to help, but not sure Ghia has the time to keep coming back.

Thanks

David
30
ghia
Re: XHelp Pop email Not working - Cron help

  • 2010/6/19 7:04

  • ghia

  • Community Support Member

  • Posts: 4953

  • Since: 2008/7/3 1


Quote:
It is not a good change and I also have the same question.
I reported this as a bug (broken nocommon functionality).
Quote:
Unfortunately it is too late to revert or refactor many similar changes in 2.4*.
It is never too late and there were a lot of reverts lin the last months. I don't see why this could not.
Quote:
I'm kind of lost at this point.
This is partly a discussion on the why the function is broken in 2.4.4
Quote:
Not sure if the code is for me to resolve the email problem or for other user fixes.
My xoops is working OK and all my xhelp is performing well except the POP email part.
The changes in the core files fix the checkemail problem and are of no influence in the core or for the XOOPS and other modules. As said, on my test site the email check is running.
It may a little bit confusing when other users jump the thread, but all changes are to be done.
Quote:
Is there someone in the community that can help me with this privately as well as 3 other small problems, then the fix can be posted here.
Someone to take a closer look at my situation?
I would like to get this fixed if I could work directly with a xoops .PHP programmer.
I can do this, but it will be paid work then.
Quote:
I know Ghia is really trying to help, but not sure Ghia has the time to keep coming back.
Not shooting is never a hit. So, put your questions on the forum.
« 1 2 (3) 4 5 6 »

Login

Register now!  |  Lost Password?

Search

Advanced Search

Recent Posts

Who's Online

222 user(s) are online (141 user(s) are browsing Support Forums)

Members: 0

Guests: 222

more...

Donat-O-Meter

Stats
Goal: $100.00
Due Date: Nov 30
Gross Amount: $0.00
Net Balance: $0.00
Left to go: $100.00
Make donations with PayPal!

Latest GitHub Commits