xoops forums

Mamba

Moderator
Posted on: 2014/6/22 1:55
Mamba
Mamba (Show more)
Moderator
Posts: 10797
Since: 2004/4/23
#1

Publisher 1.02 Beta 3 for XOOPS 2.5.7 ready for testing

In XOOPS 2.5.7 Release we have updated jQuery and jQuery UI:

- jQuery to 1.11.0
- jQuery UI 1.10.4

This means that some modules that utilized older version might need to be updated as well, as it was the case with Publisher.

I have made some changes to Publisher so it runs on XOOPS 2.5.7, and if you would like to test it, please go to our SVN and click on the "Download Snapshot" link.

Please note:

a) This version is developed and tested ONLY on XOOPS 2.5.7
b) this is still in Beta, so your feedback is appreciated, and there will be few more changes coming.
c) the TCPDF library has been updated and moved to

/xoops_lib/vendor

If you would like to test PDF, you can download it from our SVN as well (use the "Download Snapshot" link)

Some other changes in this Beta:

- updated to XOOPS 2.5.7 version of jQuery UI Tabs (noo-b/mamba)
- added ID column in Admin's Category view (mamba)
- fixed preg_replace /e in request.php (mamba)
- added Views column in Admin's Articles view (mamba)
- ensured that short_url is under 255 characters (mamba)
- added import from C-Jay Content (mamba)
- added import from xNews (bleekk, mamba)
- moved all images, CSS, and JS files to /assets (mamba)
- renamed .html Smarty templates to .tpl (mamba)
- added Preference option for PDF icon (cifug/mamba)
Support XOOPS => DONATE
Use 2.5.10 | Docs | Modules | Bugs

noo-b

Just can't stay away
Posted on: 2014/6/23 1:20
noo-b
noo-b (Show more)
Just can't stay away
Posts: 456
Since: 2007/10/23
#2

Re: Publisher 1.02 Beta 3 for XOOPS 2.5.7 ready for testing

Thank you for this release

so far ok..the tabs is now back...will make further test and will report any issue

hope some of the changes in publisher can be commit in svn


1. new archive template
https://xoops.org/modules/newbb/viewto ... id=357642#forumpost357642
2. changes made by bleek and team for publisher for 2.5.7 xbootstrap theme


TQ

Mamba

Moderator
Posted on: 2014/6/23 3:09
Mamba
Mamba (Show more)
Moderator
Posts: 10797
Since: 2004/4/23
#3

Re: Publisher 1.02 Beta 3 for XOOPS 2.5.7 ready for testing

Thanks for the testing. If you find anything else, please report back here.

Quote:
1. new archive template
https://xoops.org/modules/newbb/viewto ... id=357642#forumpost357642

I am not sure if I'll have the time to do it, but if somebody else contributes a code, we'll be glad to incorporate it into Publisher...

Quote:
2. changes made by bleek and team for publisher for 2.5.7 xbootstrap theme

These will be as part of the theme, not part of the module.
Support XOOPS => DONATE
Use 2.5.10 | Docs | Modules | Bugs

noo-b

Just can't stay away
Posted on: 2014/6/23 6:30
noo-b
noo-b (Show more)
Just can't stay away
Posts: 456
Since: 2007/10/23
#4

Re: Publisher 1.02 Beta 3 for XOOPS 2.5.7 ready for testing

the new archive template code provided in the topic is working fine
<table>  
  <
tr>  
    <
th><{$lang_newsarchives}></th>  
  </
tr>  

      
<{foreach 
item=year from=$years}>  
    <
tr class="even">  
    <
td><{$year.number}></td>  
    </
tr>  
    <
tr class="odd">  
    <
td>  
<{foreach 
item=month from=$year.months}>  
    <
a href="./archive.php?year=<{$year.number}>&month=<{$month.number}>"><{$month.string}> </a>&nbsp;  
  <{/foreach}>  
    </
td>  
  </
tr>  
 <{/foreach}>  
    
        
</
table>




<{if 
$show_articles == true}>
<
table>
    <
tr>
        <
th><{$lang_articles}></th>
        <
th align="center"><{$lang_actions}></th>
        <
th align="center"><{$lang_views}></th>
        <
th align="center"><{$lang_date}></th>
    </
tr>
    <{foreach 
item=story from=$stories}>
    <
tr class="<{cycle values=" even,odd"}>">
    <
td><{$story.title}></td>
    <
td align="center">
        <
a href="<{$story.print_link}>" rel="nofollow"><img src="<{$xoops_url}>/modules/publisher/assets/images/links/print.gif" border="0" alt="<{$lang_printer}>"/></a>
        <
a href="<{$story.mail_link}>" target="_top"/><img src="<{$xoops_url}>/modules/publisher/assets/images/links/friend.gif" border="0" alt="<{$smarty.const._MD_PUBLISHER_SENDSTORY}>"/></a>
    </
td>
    <
td align="center"><{$story.counter}></td>
    <
td align="center"><{$story.date}></td>
    </
tr><{/foreach}>
</
table>

<
div><{$lang_storytotal}></div><{/if}>




xBootstrap/modules/publisher/xoops_and_module_changes

changelog.txt
Quote:

- changed class/category.php the public function getCategoryPath to display breadcrumb as list
+ changed class/item.php to display category of article | line 718
+ in class/item.php deleted hardcoded <br><br> | line 248 | public function body | to display body and summary check module preferences at the bottom
- changed item.php to display article title in breadcrumb as last list element | line 186
- in bootstrap.css .panel-heading a{color:inherit} to avoid invisible title
- in bootstrap.css changed font-size to 12px for .breadcrumb
- in search.php added css class to <select> | line 176
- in search.php added css class to <select> | line 191
- in search.php added css class to <input> | line 200 - 230
- changed themes style css - add css for xoopsQuote
- changed /class/pagenav.php to add some style @heyula
- added style to xoops.css for the new pagenav | can also be added in the theme style
- comment out publisher.js from item.php
+ in class/item.php seperating smarty who_when in who and when
+ in class/item.php give titlelink a css class .titlelink | line 683
+ in class/item.php added imgurl, who and when in simpleview


hope some of the change listed in the xbootstrap publisher changelog can be review and implement in svn publisher

so we don't need to hack publisher to fully use xbootstrap like right now

as eg
+ in class/item.php seperating smarty who_when in who and when
this will be useful when user dont want to show the author of an article

slider84

Just popping in
Posted on: 2014/6/23 8:38
slider84
slider84 (Show more)
Just popping in
Posts: 21
Since: 2013/8/16
#5

Re: Publisher 1.02 Beta 3 for XOOPS 2.5.7 ready for testing

Hi,

On update:
Old template files (.html) are not deleted.
Old directories (images, js, css) not deleted too.

Mamba

Moderator
Posted on: 2014/6/23 15:44
Mamba
Mamba (Show more)
Moderator
Posts: 10797
Since: 2004/4/23
#6

Re: Publisher 1.02 Beta 3 for XOOPS 2.5.7 ready for testing

Quote:
On update:
Old template files (.html) are not deleted.
Old directories (images, js, css) not deleted too.

1) when did you download the files? Do you have the latest code (check in the SVN)

2) it's also possible that in the database in "modules" table the version was equal to the current version, i.e. 102, so the update wouldn't be activated.

Make sure that you have the latest code, and before you're doing the update, make sure that the version in the DB for Publisher is 101 or lower.
Support XOOPS => DONATE
Use 2.5.10 | Docs | Modules | Bugs

Cifug

Quite a regular
Posted on: 2014/6/24 1:11
Cifug
Cifug (Show more)
Quite a regular
Posts: 208
Since: 2007/12/13
#7

Re: Publisher 1.02 Beta 3 for XOOPS 2.5.7 ready for testing

Great news Mamba, I'll download and start testing tonight.

Thank you,
Marty

Bleekk

Theme Designer
Posted on: 2014/6/24 9:11
Bleekk
Bleekk (Show more)
Theme Designer
Posts: 934
Since: 2002/12/14
#8

Re: Publisher 1.02 Beta 3 for XOOPS 2.5.7 ready for testing

hi noo-b,

I have done the changes to the Publisher module to make it work better with the bootstrap theme.
you are right, now you have to hack the module so it works perfect with the theme.

If I find some free time I will merge these files to Publisher so hacking is no more required. Before I have to make sure that this does not affect other themes that use publisher

kakos

Friend of XOOPS
Posted on: 2014/6/24 9:50
kakos
kakos (Show more)
Friend of XOOPS
Posts: 73
Since: 2002/6/6 2
#9

Re: Publisher 1.02 Beta 3 for XOOPS 2.5.7 ready for testing

Hello ....

After upgrading publisher with the above upgrade package all changes made by the xbootstrap team gone. To avoid complete mess, a collaboration with bleek (or any other which made the changes) would make smoother the publisher upgrade for end users. Publisher contains many hardcoded elements like the Breadcrumb. To properly display all the elements of publisher, designer had to made some changes to the code of some php files, which are contained in the xbootstrap package (in extras folder).
I hope for a collaboration of teams so the end-users have the correct results.

With the above changes (which break the look) the tabs work normally. That still not working (perhaps a bug) is the date in my local format d/m/Y. As in previous versions of xoops I've made all changes in global.php file, but the publisher still "wants" (only when publishing an article) the date as m/d/Y. If the date given in this format then displayed as defined in global.php.

In case the choice of date made from (javascript) calendar then in the article shows in the position of the day the month and vice versa. If the value of the day is greater than 12 then as the article date displayed 01-Jan-1970.

And one final question unrelated to the above. How can I change in my language the verbal of month that displayed in publisher articles.

thanx
Kostas

Mamba

Moderator
Posted on: 2014/6/24 19:03
Mamba
Mamba (Show more)
Moderator
Posts: 10797
Since: 2004/4/23
#10

Re: Publisher 1.02 Beta 3 for XOOPS 2.5.7 ready for testing

Hi Kakos, thanks for the testing and feedback! Very much appreciated!

Quote:
After upgrading publisher with the above upgrade package all changes made by the xbootstrap team gone. To avoid complete mess, a collaboration with bleek (or any other which made the changes) would make smoother the publisher upgrade for end users.

Bleekk will be looking at that. But what exactly is broken now? Which template, and in which place? Maybe there is a quick fix for it?

[EDIT] I see that in the file:
\themes\xbootstrap\modules\publisher\xoops_and_module_changes\modules\publisher\item.php

there is missing "/assets/":

$xoTheme->addScript(PUBLISHER_URL '/js/behavior.js');
$xoTheme->addScript(PUBLISHER_URL '/js/rating.js');

It should be:

$xoTheme->addScript(PUBLISHER_URL '/assets/js/behavior.js');
$xoTheme->addScript(PUBLISHER_URL '/assets/js/rating.js');

Please change it and let us know if this fixed your issue.

Quote:
Publisher contains many hardcoded elements like the Breadcrumb. To properly display all the elements of publisher, designer had to made some changes to the code of some php files, which are contained in the xbootstrap package (in extras folder).
I hope for a collaboration of teams so the end-users have the correct results.

We definitely don't want anything being hard-coded, so if you see anything, please let us know.

Quote:
With the above changes (which break the look) the tabs work normally.

Good to hear that the tabs are now working correctly. Sorry about the broken look, but once the xBootstrap folks fix the templates, everything should be OK. I guess, the templates were pointing to the old CSS/JS files.

Quote:
That still not working (perhaps a bug) is the date in my local format d/m/Y. As in previous versions of xoops I've made all changes in global.php file, but the publisher still "wants" (only when publishing an article) the date as m/d/Y. If the date given in this format then displayed as defined in global.php.

There were already few discussions about it - we don't recommend to use the slashes in European dates like this: "d/m/Y". PHP thinks that when there are slashes, it is a US/UK format, and reads the first number as month, and not as day. Please use "d-m-Y", as recommended by Trabis 3 years ago

Quote:
In case the choice of date made from (javascript) calendar then in the article shows in the position of the day the month and vice versa. If the value of the day is greater than 12 then as the article date displayed 01-Jan-1970.

I am not sure, I understand. Can you help me step by step what you do, how you use the JavaScript calendar, so I could replicate it.

Quote:
And one final question unrelated to the above. How can I change in my language the verbal of month that displayed in publisher articles.

Normally all local changes should be done in your local language files, for example in: \language\YOURLANGUAGE\calendar.php
if you look at Publisher's file:
\modules\publisher\archive.php
the Publisher pulls the month names from the "calendar.php" file by building the array: $months_arr
Support XOOPS => DONATE
Use 2.5.10 | Docs | Modules | Bugs