71
Catzwolf
Re: Advanced Downloads Module
  • 2004/4/8 17:48

  • Catzwolf

  • Home away from home

  • Posts: 1392

  • Since: 2007/9/30


The reason people are having problems with this module and other modules that use the uploader class (with mimetypes) is that the uploader class has a bug in the code.

The check mimetype function is where the problem is.

if (count($this->allowedMimeTypes) > 0 && !in_array($this->mediaType, $this->allowedMimeTypes)) {

should be

if (count($this->allowedMimeTypes) == 0 && !in_array($this->mediaType, $this->allowedMimeTypes)) {

Hope this helps

72
domineaux
Re: Advanced Downloads Module

I've been playing with the Downloads Pro. Still having issues with it.

Is anyone using it successfully?


73
mpowell
Re: Advanced Downloads Module
  • 2004/4/9 7:11

  • mpowell

  • Friend of XOOPS

  • Posts: 119

  • Since: 2004/2/10


Does the download in wf-section not fulfill many of the items being request here? I use it on my site and it works real well.

74
DutchMan
Re: Advanced Downloads Module
  • 2004/4/9 18:04

  • DutchMan

  • Just popping in

  • Posts: 22

  • Since: 2003/11/20


Hi Catz,

How does things going? When will it be available for us?

DutchMan

75
bluenova
Re: Advanced Downloads Module

Hi I'm very new to XOOPS as you can see this is my first post

Just to let people know that the other download mod, does work after changing the code given by Catzwolf, changing a few bits of text that wern't in english and adding a few Mimetypes that I needed but wern't already listed. But saying that I am still very much looking forward to the version Catzwolf is working on as it looks like it will have a lot of features not available in this 1.

Thanks

Bluenova

76
Dhurgan
Re: Advanced Downloads Module
  • 2004/4/12 19:05

  • Dhurgan

  • Just popping in

  • Posts: 68

  • Since: 2004/2/11


Ok,

I summarize a fw problems I have with the download modules I've tried so far

* They have upload FILE as an option, the main idea with
upload (i.e the download modules) seems to be to LINK to
another website where the stuff hopefully still exists
when the person that wants to download it wants it.
To me this is a LINK not a download. And there is a
module for that.

* They all, the ones I've tried, upload to ONE directory and
use the name given by the uploader to save to, instead it
should save the filename in the db and use the upload
index as the savename for uniqueness.
another upload can otherwise overwrite the first

* Mimes seems to be handled in every separate module, that
might be better handled by a separate module and queried
by all the others.
Remove double work

* There doesnt seem to be any real method for several people
to "own" their own uploads. It should work as with the
comments and posts, the one that did them should be able
to "repair" or "edit" the upload and its info.

I havent seen the new stuff from catzwolf, sorry if that one
already has this.

77
Dhurgan
Re: Advanced Downloads Module
  • 2004/4/12 19:07

  • Dhurgan

  • Just popping in

  • Posts: 68

  • Since: 2004/2/11


Quote:

Catzwolf wrote:
The reason people are having problems with this module and other modules that use the uploader class (with mimetypes) is that the uploader class has a bug in the code.

The check mimetype function is where the problem is.

if (count($this->allowedMimeTypes) > 0 && !in_array($this->mediaType, $this->allowedMimeTypes)) {

should be

if (count($this->allowedMimeTypes) == 0 && !in_array($this->mediaType, $this->allowedMimeTypes)) {

Hope this helps


It probably will, I will check that out tomorrow.


78
samuels
Re: Advanced Downloads Module
  • 2004/4/15 13:54

  • samuels

  • Quite a regular

  • Posts: 249

  • Since: 2003/10/30


@Dhurgan
Can you tell me the bugs have you solved on Mydownloads Pro? I'm trying to improve it.

79
Dhurgan
Re: Advanced Downloads Module
  • 2004/4/15 18:08

  • Dhurgan

  • Just popping in

  • Posts: 68

  • Since: 2004/2/11


Quote:

samuels wrote:
@Dhurgan
Can you tell me the bugs have you solved on Mydownloads Pro? I'm trying to improve it.


I tried to, but I dropped it.

The code looks to be written by several different persons
with different understanding on how XOOPS should work.

The person who added the last stuff seems not to have understood smarty at all for example, if you look at submit.php you can see it has a template but its not used

It uses it's own configuration of mime-types instead of using php built in model and it's depends on the file tags to conclude a type and trusts the user to give the right size of the file.

This is all and good if you are gonna provide links to another site where that webserver is going to provide this information to the client, but its not good enough when you want to store the data localy (at least not to me)and serve
it through the php-scripts.

So what am I doing?

I'm building my own module, I've already gotten upload and download to work, with automatic mime-types and filesizes, what I'm doing right now is figuring out how to make it conform to xoops, and thats not so easy with the current documentation and differently written modules.

I have been reading the Wiki documentation on building a module, problem is that not even the "core" modules abide the rules as I see it. Rigth now I'm trying to find a module or documentation to provide me with the "true way" to make it work in a fully configurable XOOPS manner, and that takes longer than just putting the actual code together

There isnt even documentation on how to connect the MySQL database into it, it seems the rule is "read the friggin code" which would be well if people coudl stick to one way of coding

But I'm getting there and I'' try it out for a while.
BTW, I'm not writing a link module, mydownloads works fine for that. My goals a re a bit different.

* All files stored locally on server.
* User manages his/her uploads.
--* version
--* categories
--* permissions
--* screenshots
--* licenses
* Database will take care of filehandling, that means no
direct linking will be possible, everything will be
handled through php. That also means same filename can
exists as a download any amount of times.
* I will be scanning the files for viruses, exactly how
that will be done I havent yet decided.

Anyways, thats where it stands right now, with me looking at how I can get this into a XOOPS module.


80
kotis
Re: Advanced Downloads Module
  • 2004/4/16 3:44

  • kotis

  • Just popping in

  • Posts: 82

  • Since: 2002/12/23


Dhurgan, it looks like you know what you are doing, but i beleive it would be better to contact catzwolf and try to work on this project together. Catzwolf already implemented most of what you try to figure out and he is at a final stage (we all hope so) to give the world a working downloads module...

Login

Who's Online

217 user(s) are online (145 user(s) are browsing Support Forums)


Members: 0


Guests: 217


more...

Donat-O-Meter

Stats
Goal: $100.00
Due Date: Apr 30
Gross Amount: $0.00
Net Balance: $0.00
Left to go: $100.00
Make donations with PayPal!

Latest GitHub Commits