xoops forums

Cesagonchu

Moderator
Posted on: 2012/4/29 21:45
Cesagonchu
Cesagonchu (Show more)
Moderator
Posts: 864
Since: 2010/2/1 2
#11

Re: xForms 1.21 Beta ready for Testing

xForms 1.21 RC and Xoops 2.5.5

Error when I go to "/modules/xforms/admin/editelement.php?op=edit&ele_type=text" :
NoticeUndefined offset2 in file /modules/xforms/admin/ele_text.php line 11


Error when I go to "/modules/xforms/admin/editelement.php?op=edit&ele_type=uploadimg" :
NoticeUndefined offset3 in file /modules/xforms/admin/ele_uploadimg.php line 10


Error when I go to "/modules/xforms/admin/editelement.php?op=edit&ele_type=upload" :
NoticeUndefined offset3 in file /modules/xforms/admin/ele_upload.php line 8


Error when I go to the module ("/modules/xforms/") :
NoticeUndefined indexintro in file /modules/xforms/index.php line 39

Cesagonchu

Moderator
Posted on: 2012/6/22 8:21
Cesagonchu
Cesagonchu (Show more)
Moderator
Posts: 864
Since: 2010/2/1 2
#12

Re: xForms 1.21 Beta ready for Testing

Please, a developer has time to deal with the bugs mentioned above?

black_beard

Just popping in
Posted on: 2012/6/25 8:57
black_beard
black_beard (Show more)
Just popping in
Posts: 59
Since: 2012/6/24
#13

Re: xForms 1.21 Beta ready for Testing

Hi cesag,
Here are the fixes for the errors reported

For first error :
Replace line 11 in ./modules/xforms/admin/ele_text.php
$default = new XoopsFormText(_AM_ELE_DEFAULT'ele_value[2]'50255,  $myts->htmlspecialchars($myts->stripSlashesGPC($value[2])));


by

$default = new XoopsFormText(_AM_ELE_DEFAULT'ele_value[2]'50255, isset($value[2]) ? $myts->htmlspecialchars($myts->stripSlashesGPC($value[2])) : '');


For second error :
Replace line 10 in ./modules/xforms/admin/ele_uploadimg.php
$saveas $value[3] != 1;


by

if (isset($value[3]) && $value[3] == 1) {
    
$saveas $value[3];
} else {
    
$saveas 0;
}


For the third error

Replace line 8 in ./modules/xforms/admin/ele_upload.php
$saveas $value[3] != 1;


by

if (isset($value[3]) && $value[3] == 1) {
    
$saveas $value[3];
} else {
    
$saveas 0;
}


For the fourth error, I have no error at line 39. The offset "intro" file comes xoops_version.php, surely a mistake to install the module and then the bug has already been corrected by another person.

Cesagonchu

Moderator
Posted on: 2012/6/25 12:23
Cesagonchu
Cesagonchu (Show more)
Moderator
Posts: 864
Since: 2010/2/1 2
#14

Re: xForms 1.21 Beta ready for Testing

Thank you very much black_beard (montuy337513)!


Quote:
For the fourth error, I have no error at line 39. The offset "intro" file comes xoops_version.php, surely a mistake to install the module and then the bug has already been corrected by another person.


NoticeUndefined indexintro in file /modules/xforms/index.php line 39


already exist.

You can see it when creating a new form and then clicking on xform on the main menu (yoursite.com/modules/xforms/).

black_beard

Just popping in
Posted on: 2012/6/25 14:01
black_beard
black_beard (Show more)
Just popping in
Posts: 59
Since: 2012/6/24
#15

Re: xForms 1.21 Beta ready for Testing

OK I found the bug, the problem come from xoops_version.php file, there were two configuration options with the same key.

Suffit de changer
$modversion['config'][9]['name'] = 'intro';
$modversion['config'][9]['title'] = '_MI_xforms_INTRO';
$modversion['config'][9]['description'] = '';
$modversion['config'][9]['formtype'] = 'textarea';
$modversion['config'][9]['valuetype'] = 'text';
$modversion['config'][9]['default'] = _MI_xforms_INTRO_DEFAULT;


by

$modversion['config'][13]['name'] = 'intro';
$modversion['config'][13]['title'] = '_MI_xforms_INTRO';
$modversion['config'][13]['description'] = '';
$modversion['config'][13]['formtype'] = 'textarea';
$modversion['config'][13]['valuetype'] = 'text';
$modversion['config'][13]['default'] = _MI_xforms_INTRO_DEFAULT;


And to an update module at the module manager

Cesagonchu

Moderator
Posted on: 2012/6/25 14:44
Cesagonchu
Cesagonchu (Show more)
Moderator
Posts: 864
Since: 2010/2/1 2
#16

Re: xForms 1.21 Beta ready for Testing

Thank you, you're the best ! I can now translate it in french.

Mamba

Moderator
Posted on: 2012/6/25 16:42
Mamba
Mamba (Show more)
Moderator
Posts: 10818
Since: 2004/4/23
#17

xForms 1.21 Final released for XOOPS 2.5.5

Thanks, Black_beard! It's always great to see community members getting involved and contributing! Your help is very much appreciated!

Since there are no other open bugs, the Module has been now updated to Version 1.21 Final.

Download: XOOPS File Repository
Support XOOPS => DONATE
Use 2.5.10 | Docs | Modules | Bugs

Cesagonchu

Moderator
Posted on: 2012/6/25 17:33
Cesagonchu
Cesagonchu (Show more)
Moderator
Posts: 864
Since: 2010/2/1 2
#18

Re: xForms 1.21 Final released for XOOPS 2.5.5

Do not forget to put the right link, to each module I point this error

xforms\xoops_version.php
Line 23:
replace
$modversion["module_website_url"] = "https://xoops.org/

with
$modversion["module_website_url"] = "www.xoops.org/

Mamba

Moderator
Posted on: 2012/6/25 18:13
Mamba
Mamba (Show more)
Moderator
Posts: 10818
Since: 2004/4/23
#19

Re: xForms 1.21 Final released for XOOPS 2.5.5

Done and updated in SVN for xForms.

Other modules are done too, but they will be updated in SVN later, together with other updates.
Support XOOPS => DONATE
Use 2.5.10 | Docs | Modules | Bugs

Cesagonchu

Moderator
Posted on: 2012/6/26 13:43
Cesagonchu
Cesagonchu (Show more)
Moderator
Posts: 864
Since: 2010/2/1 2
#20

Re: xForms 1.21 Final released for XOOPS 2.5.5

Missing "define" for these words, which must be in local language:

=> Your comments
xformsadmindefault_elements.php
    Line 30
$defaults[2]['caption'] = 'Your comments';

=> Your name
xformsadmindefault_elements.php
    Line 8
$defaults[0]['caption'] = 'Your name';

=> Email address
xformsadmindefault_elements.php
    Line 19
$defaults[1]['caption'] = 'Email address';