XOOPS 
Forum
Forum Index General Forums Community Support Modules Support Themes Support Development International Support Module Hack Reviews Theme Designer Talk
  1. Board index / 
  2. XOOPS Community Support forums / 
  3. 2.4.x Support 
  4.  / 2.4.3 and apostrophe
Register
11
jph000
Re: 2.4.x and apostrophe - SmartFAQ

  • 2010/2/9 17:43

  • jph000

  • Just popping in

  • Posts: 60

  • Since: 2004/8/2 2


Re btesec's posting on January 8, 2010, regarding an issue with handling of html special characters like apostrophe in SmartFAQ, I noticed the same problem.

I upgraded one of my test sites from XOOPS 2.3.3 to 2.4.4 yesterday and found issues with html special characters (like apostrophe) in some modules, in particular SmartFAQ 1.08 (which still is the latest version as far as I could tell).

Was there any resolution to the problem? Do I need to try editing the code myself or was there already a fix?
12
trabis
Re: 2.4.3 and apostrophe

  • 2010/2/9 20:13

  • trabis

  • Core Developer

  • Posts: 2269

  • Since: 2006/9/1 1


I'm considering to revert changes in module.textsanitizer so we can have those modules working again, even if that seems to me like pushing a bug into core. I think it is better to have modules working then to have the code box working and a bug free core. Since we are not in conditions to provide updates to not working modules we could schedule this fix for a breaking release such as 3.0.
13
btesec
Re: 2.4.3 and apostrophe

  • 2010/2/9 21:16

  • btesec

  • Friend of XOOPS

  • Posts: 623

  • Since: 2007/2/20


Apostrophe in smartpartner- fix
open->
/smartpartner/class/partner.php
line 130
comment like this //$ret = $myts->displayTarea($ret);


14
btesec
Re: 2.4.3 and apostrophe

  • 2010/2/9 21:18

  • btesec

  • Friend of XOOPS

  • Posts: 623

  • Since: 2007/2/20


the fix for this SmartFAQ mod is mentioned earlier in this thread. Just read carefully. You might want to do a search on the files for this mod, I think there are two or three instances you need to comment out to remove the issue. you can use code editor like dreamweaver
15
jph000
Re: 2.4.4 and SmartFAQ 1.08 apostrophe fix

  • 2010/2/9 23:18

  • jph000

  • Just popping in

  • Posts: 60

  • Since: 2004/8/2 2


Sorry, btesec, I do not understand the "fix" after reading the posts again. I cannot find the lines you reference in any global source code search for "smartpartner" or a file by that name in my standard XOOPS installation.
16
trabis
Re: 2.4.3 and apostrophe

  • 2010/2/9 23:56

  • trabis

  • Core Developer

  • Posts: 2269

  • Since: 2006/9/1 1


We will release 2.4.5 to address this issue, changes have already been commited to svn (core/branches/2.4.5)
This time we will go for a beta so we can have enough testing. You can download the all package from here if you just can't wait:
http://xoops.svn.sourceforge.net/viewvc/xoops/XoopsCore/branches/2.4.x/2.4.5/
17
trabis
Re: 2.4.3 and apostrophe

  • 2010/2/10 0:05

  • trabis

  • Core Developer

  • Posts: 2269

  • Since: 2006/9/1 1


Xoops.org is running on 2.4.5 beta now! If you notice any problem please report.
18
Burning
Re: 2.4.3 and apostrophe

  • 2010/2/10 4:39

  • Burning

  • Theme Designer

  • Posts: 1163

  • Since: 2006/8/22


Great news !

ps : there is an index.html file in root folder (www/index.html). Ti finish install process (step 14), I had to erase it...
19
ghia
Re: 2.4.3 and apostrophe

  • 2010/2/10 7:54

  • ghia

  • Community Support Member

  • Posts: 4953

  • Since: 2008/7/3 1


Weird!
Normal, index.php has priority above index.html
You can rearrange this by the .htaccess file:
DirectoryIndex index.php index.html index.shtml

20
jph000
Re: 2.4.x and html special characters in SmartFAQ 1.08

  • 2010/2/11 22:21

  • jph000

  • Just popping in

  • Posts: 60

  • Since: 2004/8/2 2


Re problem with html special characters in SmartFAQ 1.08 module:

Using the info in trabis' posts, I left my XOOPS 2.4.4 installation intact and merely replaced the xoops/class/module.textsanitizer.php file with Revision 4359 posted at:

http://xoops.svn.sourceforge.net/viewvc/xoops/XoopsCore/branches/2.4.x/2.4.5/htdocs/class/module.textsanitizer.php?view=log

No other changes were made (xoopsstory.php and xoopstopic.php left as is in 2.4.4).

The newer module.textsanitizer.php file appears to have fixed the problem with html special characters that I noticed in questions in the Recent Q&A List and Did You Know blocks and in block title headers in:

xoops/modules/smartfaq/admin/myblocksadmin.php

More testing probably in a good idea, for this module as well as others.
« 1 (2) 3 »

Login

Register now!  |  Lost Password?

Search

Advanced Search

Recent Posts

Who's Online

345 user(s) are online (234 user(s) are browsing Support Forums)

Members: 0

Guests: 345

more...

Donat-O-Meter

Stats
Goal: $100.00
Due Date: Nov 30
Gross Amount: $0.00
Net Balance: $0.00
Left to go: $100.00
Make donations with PayPal!

Latest GitHub Commits