XOOPS 
Forum
Forum Index General Forums Community Support Modules Support Themes Support Development International Support Module Hack Reviews Theme Designer Talk
  1. Board index / 
  2. XOOPS Modules Support forums / 
  3. Module usage questions 
  4.  / Wiwimod
Register
31
skenow
Re: Wiwimod

  • 2009/3/29 14:02

  • skenow

  • Home away from home

  • Posts: 993

  • Since: 2004/11/17


Quote:

JAVesey wrote:
Thanks for the bug-fixes - there's been a fair bit of work for you sorting out the date/time formatting

Hadn't noticed the search one - sorry


Can you check this fix in 2.3.x?

Some reasons the date/time formatting issues arise:
* Not properly separating code layer from presentation layer

* Not properly defining the date/time fields in the database. Some developers use an integer field, some use a text field, some use a timestamp field, some use a date field and a time field, and still others use a datetime field. Each of them stores the information in different formats and converting and formatting them varies. This is something for the Module Development team to standardize. For the Core Development team, making sure each of the core areas that uses date/time is expecting the same data type.

* Simple mistakes in overlooking parts of code

Just a few ramblings on developing modules.
32
Anonymous
Re: Wiwimod

  • 2009/3/29 14:42

  • Anonymous

  • Posts: 0

  • Since:


Quote:
skenow wrote:
[
Can you check this fix in 2.3.x?


Yep

If not today (sorry - got to mend a window that #2 son put a football through ) then tomorrow evening after I get home from work.

Will report back in this thread and email you too.
33
nmshah
Re: Wiwimod

  • 2009/3/29 15:48

  • nmshah

  • Just can't stay away

  • Posts: 556

  • Since: 2007/7/2 8


Thanks skenow for the fix,

but there is a typo error in your post

Quote:
Just discovered one more correction to be made in the search function - SimplyWiki stores dates in the DB as DATETIME values (YYYY-MM-DD HH:MM:SS) and the system search expects the date/time for the search results to be a UNIX timestamp. So, to get everything matched up, change this line

'time' => formatTimestamp(strtotime($myrow['modified']), _SHORTDATESTRING),
to

'time' => strtotime($myrow['modified'],


'time' => strtotime($myrow['modified'],


Should be
'time' => strtotime($myrow['modified']),


) missing near the end of code
34
nmshah
Re: Wiwimod

  • 2009/3/29 15:50

  • nmshah

  • Just can't stay away

  • Posts: 556

  • Since: 2007/7/2 8


Checked the code, its working now.
Thanks again
35
skenow
Re: Wiwimod

  • 2009/3/30 0:55

  • skenow

  • Home away from home

  • Posts: 993

  • Since: 2004/11/17


Quote:
got to mend a window that #2 son put a football through

I take it that would not be an American football

[quote]
by nmshah on 2009/3/29 16:48:56

Thanks skenow for the fix,

but there is a typo error in your post
[/quote
ah, yes, the post was incorrect, but it was committed properly in the repository.

Thanks for the report back.
36
ghia
Re: Wiwimod

  • 2009/3/30 8:47

  • ghia

  • Community Support Member

  • Posts: 4953

  • Since: 2008/7/3 1


No, the round American Soccer football.
37
Anonymous
Re: Wiwimod

  • 2009/3/30 9:21

  • Anonymous

  • Posts: 0

  • Since:


Quote:
skenow wrote:

I take it that would not be an American football


No..... proper football played, as the name suggests, with one's feet

We also have a game over here called Rugby. Like American Football, it is played by men with odd-shaped balls. Unlike American Football, the players don't wear sissy padding

Will give the modified code a thorough workout this evening and report back
38
Anonymous
Re: Wiwimod

  • 2009/3/30 17:17

  • Anonymous

  • Posts: 0

  • Since:


Quote:
skenow wrote:

Can you check this fix in 2.3.x?


Search is working fine in 2.3.3, including searches by date

This is on my localhost, but no reason to suspect it will be different on live site.
39
Anonymous
Re: Wiwimod

  • 2009/4/9 18:55

  • Anonymous

  • Posts: 0

  • Since:


I've upgraded my live site to SimplyWiki 1.1RC with the "search code modification" above. Didn't want to wait

The only issue I had during upgrading from v1.0 was that the upgraded module didn't read any of the pages unless I updated the module with "Check templates for modifications" set to on. No probs when turning it off afterwards, though

This didn't happen when updating on my local PC so unlikely to be module issue.
40
skenow
Re: Wiwimod

  • 2009/4/9 23:34

  • skenow

  • Home away from home

  • Posts: 993

  • Since: 2004/11/17


I'm not sure why the templates wouldn't be deleted - that is part of the core, not the module. There definitely are template changes in this release, so I will make a note in the release notes to check this if problems are encountered. It will also be an issue if you are using template overrides and have modified the previous wiwimod templates. (got caught by that one, myself )

One other significant option to watch is the new setting in preferences to determine which page will be the home page for the module. Previously, it was coded in the language files as 'WiwiHome', now the default is 'HomePage' (or however it has been translated in each language). You will need to update this option to match your old top page name. New installs will not need to alter this, unless you want to. This option also gives you the ability to change the top page at any time.

I will be moving this release to final status after the weekend...
« 1 2 3 (4) 5 6 7 »

Login

Register now!  |  Lost Password?

Search

Advanced Search

Recent Posts

Who's Online

358 user(s) are online (244 user(s) are browsing Support Forums)

Members: 0

Guests: 358

more...

Donat-O-Meter

Stats
Goal: $100.00
Due Date: Nov 30
Gross Amount: $0.00
Net Balance: $0.00
Left to go: $100.00
Make donations with PayPal!

Latest GitHub Commits