Re: Liaise 1.27 and Xoops 2.3.0 RC2 [Module troubleshooting]

1

Liaise 1.27 and Xoops 2.3.0 RC2

2008/9/7 18:32
AHLIS
Not too shy to talk
Posts: 189
Since: 2004/12/12

Hi!

I'm testing XOOPS 2.3.0 RC2 and has just installed Liaise 1.27 and when I press the send button I recive a new page with this text:

Errors
Failed opening template file.

If I go to the adminpage I see this text:
Version of XOOPS does not meet the system requirement. Liaise may not work properly.

Anyone knows how to fix this?
____________
Best Regards
Ahlis

Reply Quote

2

Re: Liaise 1.27 and Xoops 2.3.0 RC2

2008/9/7 20:06
Anonymous
Posts: 0
Since:

I'm interested in this too..... good post

What happens when you try with php debugging turned on, i.e. are there any error messages?

Cheers

Reply Quote

3

Re: Liaise 1.27 and Xoops 2.3.0 RC2

2008/9/7 20:19
trabis
Core Developer
Posts: 2269
Since: 2006/9/1 1

If you look in liaise/admin/footer.php you will see that liaise is expecting to find XOOPS 2.0.9 (at least in liase 1.23)

LatinoPoemas

Reply Quote

4

Re: Liaise 1.27 and Xoops 2.3.0 RC2

2008/9/7 20:33
Anonymous
Posts: 0
Since:

Quote:

trabis wrote:

If you look in liaise/admin/footer.php you will see that liaise is expecting to find XOOPS 2.0.9 (at least in liase 1.23)

Interesting..... in Liaise v1.26, line 42 of footer.php says:

le="color: #000000"><?php $version_check = preg_match('/2.0.[9|10|11|12|13]/', XOOPS_VERSION);

Interestingly, it works fine with XOOPS 2.0.18.2.

Presumably, changing the code to something like that below would sort out the Admin message?:

le="color: #000000"><?php $version_check = preg_match('/2.3.[0|1|2|3|4]/', XOOPS_VERSION);

What about the template issue, though?

Reply Quote

5

Re: Liaise 1.27 and Xoops 2.3.0 RC2

2008/9/7 21:09
trabis
Core Developer
Posts: 2269
Since: 2006/9/1 1

For what I can see there is a bug in XOOPS 2.3 and you need to do some changes in liaise also.

in liaise include/form_execute (around line 184 for liaise 1.26)
you will find:

le="color: #000000"><?php if( is_dir(LIAISE_ROOT_PATH."language/".$xoopsConfig['language']."/mail_template") ){ $template_dir = LIAISE_ROOT_PATH."language/".$xoopsConfig['language']."/mail_template"; }else{ $template_dir = LIAISE_ROOT_PATH."language/english/mail_template"; } $xoopsMailer =& getMailer(); $xoopsMailer->setTemplateDir($template_dir);

relpace by this:

le="color: #000000"><?php $xoopsMailer =& xoops_getMailer(); $xoopsMailer->setTemplateDir('liaise');

And thenyou need to fix the core bug in class/xoopsmailer.php line 180:

le="color: #000000"><?php $path = XOOPS . "/modules/" . $path . "/languages/";

Replace by

le="color: #000000"><?php $path = XOOPS_ROOT_PATH . "/modules/" . $path . "/language/";

LatinoPoemas

Reply Quote

6

Re: Liaise 1.27 and Xoops 2.3.0 RC2

2008/9/7 21:35
ghia
Community Support Member
Posts: 4953
Since: 2008/7/3 1

Quote:

n liaise include/form_execute (around line 184 for liaise 1.26)
you will find:

le="color: #000000"><?php if( is_dir(LIAISE_ROOT_PATH."language/".$xoopsConfig['language']."/mail_template") ){ $template_dir = LIAISE_ROOT_PATH."language/".$xoopsConfig['language']."/mail_template"; }else{ $template_dir = LIAISE_ROOT_PATH."language/english/mail_template"; } $xoopsMailer =& getMailer(); $xoopsMailer->setTemplateDir($template_dir);
relpace by this:

le="color: #000000"><?php $xoopsMailer =& xoops_getMailer(); $xoopsMailer->setTemplateDir('liaise');

I think you are breaking a standard here and compatibility with a lot of modules.
This problem has to be resolved entirely in phpmailer, so that it is ready to accept this kind of template specifications.

This is a code snippet from 2.2.6rc

le="color: #000000"><?php // public function setTemplateDir($value) { if ( substr($value, -1, 1) != "/" ) { $value .= "/"; } $this->templatedir = $value; } // public function setTemplate($value) { $this->template = $value; }

le="color: #000000"><?php // public function send($debug = false) { global $xoopsConfig; if ( $this->body == "" && $this->template == "" ) { if ($debug) { $this->errors[] = _MAIL_MSGBODY; } return false; } elseif ( $this->template != "" ) { $path = ( $this->templatedir != "" ) ? $this->templatedir."".$this->template : (XOOPS_ROOT_PATH."/language/".$xoopsConfig['language']."/mail_template/".$this->template); if ( !($fd = @fopen($path, 'r')) ) { if ($debug) { $this->errors[] = _MAIL_FAILOPTPL; } return false; } $this->setBody(fread($fd, filesize($path))); } // for sending mail only

The art of asking questions.

Reply Quote

7

Re: Liaise 1.27 and Xoops 2.3.0 RC2

2008/9/7 21:51
trabis
Core Developer
Posts: 2269
Since: 2006/9/1 1

I agree. xoopsmailer needs to be reviewed to maintain compatibility. As it is, you do not even need to set a template dir and as you are forced to use mail_template.

le="color: #000000"><?php // private function getTemplatePath() { if (!$path = $this->templatedir) { $path = XOOPS_ROOT_PATH . "/language/"; } elseif ( false === strpos($path, '/') ) { $path = XOOPS . "/modules/" . $path . "/languages/"; } elseif ( substr($path, -1, 1) != "/" ) { $path .= "/"; } if (file_exists($path . $GLOBALS['xoopsConfig']['language'] . "/" . $this->template) ) { return $path . $GLOBALS['xoopsConfig']['language'] . "/mail_template/" . $this->template; } else { return $path . "english/mail_template/" . $this->template; } }

le="color: #000000"><?php // public function send($debug = false) { global $xoopsConfig; if ( $this->body == "" && $this->template == "" ) { if ($debug) { $this->errors[] = _MAIL_MSGBODY; } return false; } elseif ( $this->template != "" ) { $path = $this->getTemplatePath(); if ( !($fd = @fopen($path, 'r')) ) { if ($debug) { $this->errors[] = _MAIL_FAILOPTPL; } return false; } $this->setBody(fread($fd, filesize($path))); } ...

LatinoPoemas

Reply Quote

8

Re: Liaise 1.27 and Xoops 2.3.0 RC2

2008/9/7 21:57
trabis
Core Developer
Posts: 2269
Since: 2006/9/1 1

I guess this would be a better fix for xoopsmailer.php

le="color: #000000"><?php function getTemplatePath() { if (!$path = $this->templatedir) { $path = XOOPS_ROOT_PATH . "/language/"; } elseif ( false === strpos($path, '/') ) { $path = XOOPS_ROOT_PATH . "/modules/" . $path . "/language/"; } elseif ( substr($path, -1, 1) != "/" ) { $path .= "/"; } if (file_exists($path . $GLOBALS['xoopsConfig']['language'] . "/mail_template/" . $this->template) ) { return $path . $GLOBALS['xoopsConfig']['language'] . "/mail_template/" . $this->template; } elseif (file_exists($path . "english/mail_template/" . $this->template) ) { return $path . "english/mail_template/" . $this->template; } elseif (file_exists($path . $this->template) ) { return $path . $this->template; } else { return false; } }

LatinoPoemas

Reply Quote

9

Re: Liaise 1.27 and Xoops 2.3.0 RC2

2008/9/8 16:53
AHLIS
Not too shy to talk
Posts: 189
Since: 2004/12/12

Quote:

trabis wrote:
I guess this would be a better fix for xoopsmailer.php

le="color: #000000"><?php function getTemplatePath() { if (!$path = $this->templatedir) { $path = XOOPS_ROOT_PATH . "/language/"; } elseif ( false === strpos($path, '/') ) { $path = XOOPS_ROOT_PATH . "/modules/" . $path . "/language/"; } elseif ( substr($path, -1, 1) != "/" ) { $path .= "/"; } if (file_exists($path . $GLOBALS['xoopsConfig']['language'] . "/mail_template/" . $this->template) ) { return $path . $GLOBALS['xoopsConfig']['language'] . "/mail_template/" . $this->template; } elseif (file_exists($path . "english/mail_template/" . $this->template) ) { return $path . "english/mail_template/" . $this->template; } elseif (file_exists($path . $this->template) ) { return $path . $this->template; } else { return false; } }

Thanks. The above code helped. :)
____________
Best Regards
Ahlis

Reply Quote

10

Re: Liaise 1.27 and Xoops 2.3.0 RC2

2008/9/8 17:08
Anonymous
Posts: 0
Since:

Thread bookmarked

Reply Quote

Stats
Goal:	$15.00
Due Date:	Jul 31
Gross Amount:	$0.00
Net Balance:	$0.00
Left to go:	$15.00

Liaise 1.27 and Xoops 2.3.0 RC2

Re: Liaise 1.27 and Xoops 2.3.0 RC2

Re: Liaise 1.27 and Xoops 2.3.0 RC2

Re: Liaise 1.27 and Xoops 2.3.0 RC2

Re: Liaise 1.27 and Xoops 2.3.0 RC2

Re: Liaise 1.27 and Xoops 2.3.0 RC2

Re: Liaise 1.27 and Xoops 2.3.0 RC2

Re: Liaise 1.27 and Xoops 2.3.0 RC2

Re: Liaise 1.27 and Xoops 2.3.0 RC2

Re: Liaise 1.27 and Xoops 2.3.0 RC2

Post Reply

Search

Recent Posts

Re: XOOPS 2.7.1-RC1 Released for Testing

Re: XOOPS 2.7.1-RC1 Released for Testing

Coming soon: fully rewritten PEDIGREE

XOOPS Cocktails available for testing

Quotes module available for testing

mTools available for testing

XOOPS 2.7.1-RC1 Released for Testing

Re: New XOOPS 2.7.0 Documentation in development

New XOOPS 2.7.0 Documentation in development

Re: XOOPS 2.7.0-RC5 Released for Testing

Who's Online

Donat-O-Meter

Latest GitHub Commits

{{ record.sha.slice(0, 7) }} - {{ record.commit.message | truncate }}