1
sarahmx
smilies suddenly not working in 2.0.18
  • 2007/12/17 6:36

  • sarahmx

  • Quite a regular

  • Posts: 381

  • Since: 2007/10/28


just upgraded to 2.0.18 from 2.0171
and my smilies not working

what do i need to do to rectify this problem

i've check in my uploads all the smilies is there and the folder is in 777 mod

in admin preference - smilies control all smilies is there

but when i post in forum (newbbex) and comments (Enable Smiley Icons checked)

smilies is shown as symbol etc and not as image

how do i fix this ?

2
phppp
Re: smilies suddenly not working in 2.0.18
  • 2007/12/17 8:12

  • phppp

  • XOOPS Contributor

  • Posts: 2857

  • Since: 2004/1/25


This is a backward compatibility issue.
Can you please submit to
http://sourceforge.net/tracker/?func= ... roup_id=41586&atid=430840

Before get it fixed in SVN, you can modify
/class/module.textsanitizer.php
line #115

function smiley($message)
    {
        foreach (
$this->smileys as $smile) {
            
$message str_replace($smile['code'], '<img src="'.XOOPS_UPLOAD_URL.'/'.htmlspecialchars($smile['smile_url']).'" alt="" />'$message);
        }
        return 
$message;
    }


Change to
function smiley($message)
    {
        if (
count($this->smileys) == 0) {
            
$this->getSmileys();
        }
        
        foreach (
$this->smileys as $smile) {
            
$message str_replace($smile['code'], '<img src="'.XOOPS_UPLOAD_URL.'/'.htmlspecialchars($smile['smile_url']).'" alt="" />'$message);
        }
        return 
$message;
    }

3
sarahmx
Re: smilies suddenly not working in 2.0.18
  • 2007/12/17 12:05

  • sarahmx

  • Quite a regular

  • Posts: 381

  • Since: 2007/10/28


thank you phpp it works now and i've submitted the bug to the bug tracker

4
CrazyJoe_
Re: smilies suddenly not working in 2.0.18
  • 2007/12/21 17:37

  • CrazyJoe_

  • Just popping in

  • Posts: 1

  • Since: 2007/12/21


I've made the changes listed above, yet my smileys still don't show.
Both the system module and CBB have been "updated" via the modules section. Is there anything else that would need to be done?

NM ... they suddenly started working ... must have been some lag on the server response.

Thanks for the fix !

5
karasu
Re: smilies suddenly not working in 2.0.18
  • 2008/1/5 13:28

  • karasu

  • Just popping in

  • Posts: 22

  • Since: 2006/6/26


You Must Select The Avartar admin to Display in form? too

that the smillies will show correctly

i think this is still have a bug in smillies admin too ^^

6
faridelha
Re: smilies suddenly not working in 2.0.18
  • 2008/1/16 21:50

  • faridelha

  • Just popping in

  • Posts: 22

  • Since: 2006/3/7 0




dont work

7
BlueStocking
Re: smilies suddenly not working in 2.0.18

faridelha,

Make sure they are checked on the smiles control
Example: http://www.xoops.net.br/smiles.htm 2.0.16
http://xoops-end-user.com/xoopshelper/help/smiles.htm 2.0.18 RC

BlueStocking
https://xoops.org/modules/repository .. It is time to get involved - XOOPS.ORG

8
faridelha
Re: smilies suddenly not working in 2.0.18
  • 2008/1/17 12:56

  • faridelha

  • Just popping in

  • Posts: 22

  • Since: 2006/3/7 0


ok thanx
And if I have more than 50 smiley, in the form of private messages or other form, they will all be displayed

9
donny
Re: smilies suddenly not working in 2.0.18
  • 2008/2/4 21:18

  • donny

  • Just popping in

  • Posts: 21

  • Since: 2006/11/5


I would have to say that in my case the proposed code didn't do much.
though enabling the display check box next to the smileys in the admin panel did help, with both the old and the new code.

so I am guessing that someone decided that the check box no longer means
1)display the smiley in the list on post (reply, new topic etc.) pages, but otherwise use it regularly
instead now it is
2)display the smilie when the code is used. which also means that ALL smileys are displayed below post dialogs. which also means that the "more smileys" button don't make any sense anymore.

I would also point out that option 2 doesn't really make much sense. Besides the thing that it ruins the old way of doing things, and goes against the descriptions, it also don't make much sense to me to have smileys in my db and then disabling them from use. that is what the "delete" button is for? am I wrong?

please return this to the old ways? should I complain on some official channel? I don't know where... on the bug tracker?

anyway the solution that works for me is
in /class/module.textsanitizer.php
line #97
if ($getsmiles $GLOBALS["xoopsDB"]->query("SELECT * FROM ".$GLOBALS["xoopsDB"]->prefix("smiles").' WHERE display=1')) {

replace with
if ($getsmiles $GLOBALS["xoopsDB"]->query("SELECT * FROM ".$GLOBALS["xoopsDB"]->prefix("smiles"))) {


this will return the old behaviour. or at least it did for me.

10
donny
Re: smilies suddenly not working in 2.0.18
  • 2008/2/6 0:08

  • donny

  • Just popping in

  • Posts: 21

  • Since: 2006/11/5


it seems that the 2.0.18.1 has fixed this problem.

as far as I have seen, the solution is very similar to the code I came up with :)

Login

Username:
Password:

Lost Password? Register now!

Who's Online

71 user(s) are online (37 user(s) are browsing Support Forums)


Members: 0


Guests: 71


more...

Donat-O-Meter

Stats
Goal: $100.00
Due Date: May 31
Gross Amount: $0.00
Net Balance: $0.00
Left to go: $100.00
Make donations with PayPal!

Latest GitHub Commits