xoops forums

ICHI_UK

Not too shy to talk
Posted on: 2006/2/21 15:22
ICHI_UK
ICHI_UK (Show more)
Not too shy to talk
Posts: 181
Since: 2005/11/1
#1

CBB 3.0 ... wheres QUOTE

How come the quote option has been removed from CBB... Edit, Delete etc etc are there but Quote seems to have been removed.. anyone else noticed this or am I missing something?

m0nty

XOOPS is my life!
Posted on: 2006/2/21 15:39
m0nty
m0nty (Show more)
XOOPS is my life!
Posts: 3337
Since: 2003/10/24
#2

Re: CBB 3.0 ... wheres QUOTE

yup you missed reading the comments in the news article.. lol

Rhomal

Quite a regular
Posted on: 2006/2/21 17:12
Rhomal
Rhomal (Show more)
Quite a regular
Posts: 274
Since: 2004/10/5
#3

Re: CBB 3.0 ... wheres QUOTE

Quote:

m0nty wrote:
yup you missed reading the comments in the news article.. lol


I do not understand why it is so difficult to tell use where to un-REM to make the button return?

Many people have asked for this yet all we get is silence from the devs.

davidl2

XOOPS is my life!
Posted on: 2006/2/21 17:42
davidl2
davidl2 (Show more)
XOOPS is my life!
Posts: 4843
Since: 2003/5/26
#4

Re: CBB 3.0 ... wheres QUOTE

Here we go again....

It was removed because: it confused some people, it slowed down the module (not the image - but the queries relating to it I would guess) and finally it's not removed - but it's present when you hit submit.

If you want to keep the button... don't upgrade.

Rhomal

Quite a regular
Posted on: 2006/2/21 20:32
Rhomal
Rhomal (Show more)
Quite a regular
Posts: 274
Since: 2004/10/5
#5

Re: CBB 3.0 ... wheres QUOTE

Quote:

davidl2 wrote:
Here we go again....

It was removed because: it confused some people, it slowed down the module (not the image - but the queries relating to it I would guess) and finally it's not removed - but it's present when you hit submit.

If you want to keep the button... don't upgrade.


It was a silly and VERY POOR choice to remove it. Period.

Bender

Home away from home
Posted on: 2006/2/21 21:24
Bender
Bender (Show more)
Home away from home
Posts: 1899
Since: 2003/3/10
#6

Re: CBB 3.0 ... wheres QUOTE

1. Everybody calm down please ... the only thing stupid is actually fighting over this instead of taking a constructive approach

2. This decision is not carved in stone i think so if there is enough interest it might make a regular return eventually

3. I know close to nothing about php and stuff but it took me about ten minutes to get it back after i noticed that dotmill wrote this in the comments of the original news posting:
Quote:
Ok that reasoning for the "quote" changes makes a little more sense to me. I guess it's just a preference some people have and others don't. Either way, I just uncommented the usual lines and it's back.

I don't mind having to enable it this way, as long as the feature is available as an option. Thanks BTW; this is definitely a worthwhile upgrade!


btw: Did anyone bother to pm him and ask him? Maybe he did not check back on the comments and did not see you asking guys?

4. Did anyone try to send a (nice) pm to phppp asking him directly if it could be reenabled manually?

So please ... there are other ways to get on without getting on each others throat.


Now lets get to work:

In the folder /modules/newbb/class is a file post.php

Just edit it and remove the part that comments out the quote button:

before:

440                /*
441                $thread_buttons['quote']['image'] = newbb_displayImage($forumImage['p_quote'], _MD_QUOTE);
442                $thread_buttons['quote']['link'] = "reply.php?forum=" . $forumdata['forum_id'] . "&topic_id=" . 443 $this->getVar('topic_id') . "&viewmode=$viewmode&order=$order&start=$start&quotedac=1";
444                $thread_buttons['quote']['name'] = _MD_QUOTE;
445                */


after:

440                
441                $thread_buttons
['quote']['image'] = newbb_displayImage($forumImage['p_quote'], _MD_QUOTE);
442                $thread_buttons['quote']['link'] = "reply.php?forum=" $forumdata['forum_id'] . "&topic_id=" 443 $this->getVar('topic_id') . "&viewmode=$viewmode&order=$order&start=$start&quotedac=1";
444                $thread_buttons['quote']['name'] = _MD_QUOTE;
445


Now chill ... and thats an order
Sorry, this signature is experiencing technical difficulties. We will return you to the sheduled signature as soon as possible ...

davidl2

XOOPS is my life!
Posted on: 2006/2/21 21:27
davidl2
davidl2 (Show more)
XOOPS is my life!
Posts: 4843
Since: 2003/5/26
#7

Re: CBB 3.0 ... wheres QUOTE

Thank you B.

Rhomal

Quite a regular
Posted on: 2006/2/21 22:37
Rhomal
Rhomal (Show more)
Quite a regular
Posts: 274
Since: 2004/10/5
#8

Re: CBB 3.0 ... wheres QUOTE

Thank you Bender, it is much appreciated.

Mantooth

Friend of XOOPS
Posted on: 2006/2/22 17:15
Mantooth
Mantooth (Show more)
Friend of XOOPS
Posts: 189
Since: 2004/11/2
#9

Re: CBB 3.0 ... wheres QUOTE

thanks for the fix bender.

i'm not trying to start up an argument, but i think that a lot more people want the quote button left where it was even if the module slows down slightly. Also, I think it's causing more of a problem than it was intended to solve.

perhaps phppp would be nice enough to put some sort of poll up about the next release
...


I hate Mortal Kombat

davidl2

XOOPS is my life!
Posted on: 2006/2/22 17:36
davidl2
davidl2 (Show more)
XOOPS is my life!
Posts: 4843
Since: 2003/5/26
#10

Re: CBB 3.0 ... wheres QUOTE

Well there's a patch for people who want it now at least