26
Quote:
LazyBadger wrote:
Quote:
Herko Coomans wrote:
It's a nice enough solution using basic smarty features, which is good. But it shouldn't *have* to be in the theme itself.
1. There aren't ways to redefine modules's block design in theme for XOOPS before 2.2.3
2. Still there aren't ways to redefine design of one (any) specific block in theme now
I don't *fully* agree, but share your frustration there. It IS very well possible to give each block a unique design using the old core and the new core. Just don't use the theme.html file for that. The theme file defines the *positioning* of the static and dynamic elements, and adds classes to them (and perhaps IDs to static elements, but the use for those is limited to specifics). Actual markup of the dynamic elements (such as blocks) is done in the templates. That's how it has been from the very start since we introduced templates.
However, I share part of your frustration because block titles are defined in the theme.html file, and not in the block template. This IMO goes against the theme/template logic, and produces mixed themes.
When I design a new theme, the block positioning code (the smarty loops for all blocks) only define a <div> in which each block *series* is placed (center-center, center left etc.), and I use CSS and the templates to design the blocks themselves. As it should be, IMHO.
Quote:
3. If your credo is such pure, any PHP-inclusions in theme and <{assign var='varname' value='varvalue'}> inside themes must be outlaws...
Correct. The credo is to keep presentation and application logic separated. Look at the web usability discussions, at csszengarden.com, at alistapart, at the w3c standards, they're all aimed towards facilitating this. If used properly, our theme.html files would only contain a series of <div>s, and nothing more. The whole layout and design is done via CSS.
We're not there yet, tho. That's where the frusration comes from.
Quote:
We get poor stupid lame idiotic #OOPS# as theme in result
Not because we follow the pure logic, but because we don't. And it is nearly possible. The core isn't the biggest problem here tho, the modules are. ALL presentation logic should be in the templates, and not every module does that.
So I think we agree on this
Herko