51
zyspec
Re: SQL error with Tag Module
  • 2019/11/15 14:31

  • zyspec

  • Module Developer

  • Posts: 1095

  • Since: 2004/9/21


@mjoel - sorry this hasn't worked (yet). I'll load the module on my test site and look at it within the next several days.

@Mage - good catch. This should be able to be fixed though by modifying the 'Criteria' used to build the SQL query string. There's a way to build a query that includes the ability to add a "function" on a column. Once we figure out which column is 'unique' then we ensure we add the right function to the query....



52
zyspec
Re: SQL error with Tag Module
  • 2019/11/14 16:50

  • zyspec

  • Module Developer

  • Posts: 1095

  • Since: 2004/9/21


Sorry... I apparently didn't read far enough down in the code...

You also need to change lines 265 and 405 in ./blocks/block.php from:
$criteria->add(new Criteria('l.tag_modid'$modid))

to:
$criteria->add(new Criteria('o.tag_modid'$modid))



53
zyspec
Re: SQL error with Tag Module
  • 2019/11/7 15:14

  • zyspec

  • Module Developer

  • Posts: 1095

  • Since: 2004/9/21


Let me first say that I HAVEN'T ACTUALLY TRIED THIS.... so it could I'm mis-reading the code but:

It looks like ./block/block.php line 115
$criteria->add(new Criteria('l.tag_modid'$modid));

should be:
$criteria->add(new Criteria('o.tag_modid'$modid));


and in line 120:
if (!$tags = &$tagHandler->getByLimit(00$criterianull, empty($options[1]))) {

should be:
if (!$tags $tagHandler->getByLimit(00$criterianull, empty($options[1]))) {


In theory that should help fix the issue in the block. Let us know if that works and if so then we can find the other place(s) in the code that may have similar issues.



54
zyspec
Re: Latestnews : No categories in selection panel ...
  • 2019/8/12 16:25

  • zyspec

  • Module Developer

  • Posts: 1095

  • Since: 2004/9/21


@Pino

I made some minor changes to the module that should allow it to work a little better for you.

I submitted the changes to Mamba but until he gets a chance to accept the pull request you can see what I've done athttps://github.com/zyspec/latestnews and try it out.

Unfortunately I do not have time to replace the HTML marquee tag in the block with something more 'modern' (HTML5 translate[X/Y] to make the block more responsive.

Hope this helps. Please report back on what you find so we can continue to improve the module when time permits.



55
zyspec
Re: Latestnews : No categories in selection panel ...
  • 2019/8/11 22:25

  • zyspec

  • Module Developer

  • Posts: 1095

  • Since: 2004/9/21


@Pino,

You might try to use Mamba's update of version 0.73 of Latestnews (https://github.com/mambax7/latestnews/) to see if it gets you any closer. He made some updates to get rid of pass-by-reference errors that could be causing you issues with PHP 7.x.

Turn on XOOPS debug to see if it gives you errors (and post them back here) to try and narrow down where the issue might be.



56
zyspec
Re: Upgrade my own modules to 2.5.10 and Xmf
  • 2019/7/31 18:25

  • zyspec

  • Module Developer

  • Posts: 1095

  • Since: 2004/9/21


You might want to look at WgGallery (https://github.com/ggoffy/wggallery) - it uses some of the XMF features, PHP namespaces, uses the "common" admin GUI, etc.

It would be a good starting point to help you understand how to implement some of the newer XOOPS 2.5.x features. After that you can browse some of the recently edited modules in the GitHub modules repositories to see other examples.



57
zyspec
Re: Gallery Module working on version 2.5.9
  • 2019/7/14 23:47

  • zyspec

  • Module Developer

  • Posts: 1095

  • Since: 2004/9/21


You can fix this temporarily (until someone gets a chance to update the repository). In ./class/PhotoHandler.php change line 1023 from:
if (null !== $catHandler->getCatRestrictCriteria()) {

to:
if (false !== $catHandler->getCatRestrictCriteria()) {


That should fix the error you're seeing on line 1024.



58
zyspec
Re: Wfdownloads 3.30 Beta-1 for XOOPS 2.5.9 and PHP 5.6+
  • 2019/6/26 22:09

  • zyspec

  • Module Developer

  • Posts: 1095

  • Since: 2004/9/21


looks like this forum "ate" the '\' in the previous post...

replace line 5:
$utility = new XoopsModulesWfdownloadsUtility();

with:
$utility = new XoopsModules\Wfdownloads\Utility();



59
zyspec
Re: newbb on xoops.org
  • 2019/6/26 16:58

  • zyspec

  • Module Developer

  • Posts: 1095

  • Since: 2004/9/21


Ok - I'd recommend you turn on debug and look at the MySQL queries in debug to see if that leads you in the right direction.

The other thing to try is to look a the value of $types in the Smarty template debug information.

Hopefully one of these will lead you in the right direction. I don't use newbb on any of my sites (including my debug site) right now so I found the bug above by code inspection. There's probably something else that assumes $status is a string... looks like allowing "multiple" types was added somewhere along the way and by irmtfan after initial development.



60
zyspec
Re: newbb on xoops.org
  • 2019/6/24 16:18

  • zyspec

  • Module Developer

  • Posts: 1095

  • Since: 2004/9/21


@goffy,

It looks to me like there's a minor bug in the logic. $status is defined as a string variable, but later it is accessed as an array.

The code in ./class/TopicRenderer.php (line 730) is:
$status '';


Should be changed to:
$status = [];




TopTop
« 1 ... 3 4 5 (6) 7 8 9 ... 100 »



Login

Who's Online

242 user(s) are online (172 user(s) are browsing Support Forums)


Members: 0


Guests: 242


more...

Donat-O-Meter

Stats
Goal: $100.00
Due Date: Apr 30
Gross Amount: $0.00
Net Balance: $0.00
Left to go: $100.00
Make donations with PayPal!

Latest GitHub Commits