xoops forums

Forum Index


Board index » All Posts (zyspec)




zyspec

Module Developer
Posted on: Yesterday 15:36
zyspec
zyspec (Show more)
Module Developer
Posts: 1047
Since: 2004/9/21
#1

Re: SQL error with Tag Module

@mjoel,

Thanks... I'll load publisher and create a few test tags. I'll enable "ONLY_FULL_GROUP_BY" in my SQL server and make sure to test with it enabled.


zyspec

Module Developer
Posted on: 11/15 22:53
zyspec
zyspec (Show more)
Module Developer
Posts: 1047
Since: 2004/9/21
#2

Re: SQL error with Tag Module

@mjoel,

Can you tell me what other modules you're using? Using the following config I don't get any errors yet.
Quote:

XOOPS Version XOOPS 2.5.10
PHP Version 7.2.24
mySQL Version 5.7.27-log

I installed the module and enabled each of the blocks one-at-a-time on the home page without any problems. I also do not get any errors if I go to the module home page (./modules/tag/index.php).

I do not have any tags yet because I want to make sure I load a module with tag support similar to what you're doing so I can replicate the problem.

I checked to make sure the SQL call is being executed - here's the resulting SQL statement with the Cumulus Tag Block enabled:
SELECT DISTINCT(o.tag_id), o.tag_termo.tag_statusSUM(l.tag_count) AS countl.tag_modid FROM tag_tag AS o LEFT JOIN tag_stats AS l ON l.tag_id o.tag_id WHERE (o.tag_status '0' AND l.tag_modid '11' AND l.tag_catid '0'GROUP BY o.tag_id ORDER BY count DESC LIMIT 0100


zyspec

Module Developer
Posted on: 11/15 14:31
zyspec
zyspec (Show more)
Module Developer
Posts: 1047
Since: 2004/9/21
#3

Re: SQL error with Tag Module

@mjoel - sorry this hasn't worked (yet). I'll load the module on my test site and look at it within the next several days.

@Mage - good catch. This should be able to be fixed though by modifying the 'Criteria' used to build the SQL query string. There's a way to build a query that includes the ability to add a "function" on a column. Once we figure out which column is 'unique' then we ensure we add the right function to the query....


zyspec

Module Developer
Posted on: 11/14 16:50
zyspec
zyspec (Show more)
Module Developer
Posts: 1047
Since: 2004/9/21
#4

Re: SQL error with Tag Module

Sorry... I apparently didn't read far enough down in the code...

You also need to change lines 265 and 405 in ./blocks/block.php from:
$criteria->add(new Criteria('l.tag_modid'$modid))

to:
$criteria->add(new Criteria('o.tag_modid'$modid))


zyspec

Module Developer
Posted on: 11/7 15:14
zyspec
zyspec (Show more)
Module Developer
Posts: 1047
Since: 2004/9/21
#5

Re: SQL error with Tag Module

Let me first say that I HAVEN'T ACTUALLY TRIED THIS.... so it could I'm mis-reading the code but:

It looks like ./block/block.php line 115
$criteria->add(new Criteria('l.tag_modid'$modid));

should be:
$criteria->add(new Criteria('o.tag_modid'$modid));


and in line 120:
if (!$tags = &$tagHandler->getByLimit(00$criterianull, empty($options[1]))) {

should be:
if (!$tags $tagHandler->getByLimit(00$criterianull, empty($options[1]))) {


In theory that should help fix the issue in the block. Let us know if that works and if so then we can find the other place(s) in the code that may have similar issues.


zyspec

Module Developer
Posted on: 8/12 16:25
zyspec
zyspec (Show more)
Module Developer
Posts: 1047
Since: 2004/9/21
#6

Re: Latestnews : No categories in selection panel ...

@Pino

I made some minor changes to the module that should allow it to work a little better for you.

I submitted the changes to Mamba but until he gets a chance to accept the pull request you can see what I've done at https://github.com/zyspec/latestnews and try it out.

Unfortunately I do not have time to replace the HTML marquee tag in the block with something more 'modern' (HTML5 translate[X/Y] to make the block more responsive.

Hope this helps. Please report back on what you find so we can continue to improve the module when time permits.


zyspec

Module Developer
Posted on: 8/11 22:25
zyspec
zyspec (Show more)
Module Developer
Posts: 1047
Since: 2004/9/21
#7

Re: Latestnews : No categories in selection panel ...

@Pino,

You might try to use Mamba's update of version 0.73 of Latestnews (https://github.com/mambax7/latestnews/) to see if it gets you any closer. He made some updates to get rid of pass-by-reference errors that could be causing you issues with PHP 7.x.

Turn on XOOPS debug to see if it gives you errors (and post them back here) to try and narrow down where the issue might be.


zyspec

Module Developer
Posted on: 7/31 18:25
zyspec
zyspec (Show more)
Module Developer
Posts: 1047
Since: 2004/9/21
#8

Re: Upgrade my own modules to 2.5.10 and Xmf

You might want to look at WgGallery (https://github.com/ggoffy/wggallery) - it uses some of the XMF features, PHP namespaces, uses the "common" admin GUI, etc.

It would be a good starting point to help you understand how to implement some of the newer XOOPS 2.5.x features. After that you can browse some of the recently edited modules in the GitHub modules repositories to see other examples.


zyspec

Module Developer
Posted on: 7/14 23:47
zyspec
zyspec (Show more)
Module Developer
Posts: 1047
Since: 2004/9/21
#9

Re: Gallery Module working on version 2.5.9

You can fix this temporarily (until someone gets a chance to update the repository). In ./class/PhotoHandler.php change line 1023 from:
if (null !== $catHandler->getCatRestrictCriteria()) {

to:
if (false !== $catHandler->getCatRestrictCriteria()) {


That should fix the error you're seeing on line 1024.


zyspec

Module Developer
Posted on: 6/26 22:09
zyspec
zyspec (Show more)
Module Developer
Posts: 1047
Since: 2004/9/21
#10

Re: Wfdownloads 3.30 Beta-1 for XOOPS 2.5.9 and PHP 5.6+

looks like this forum "ate" the '\' in the previous post...

replace line 5:
$utility = new XoopsModulesWfdownloadsUtility();

with:
$utility = new XoopsModules\Wfdownloads\Utility();



TopTop
(1) 2 3 4 ... 95 »