11
ghia
Re: Message icons in newbb under 2.4.2
  • 2009/12/5 0:31

  • ghia

  • Community Support Member

  • Posts: 4953

  • Since: 2008/7/3 1


Quote:
I tried that option first as it seemed the cleanest, but it did not work.
Turned out that it needed a minus sign for separation in the names to work. An underline is not good.

12
skyangelo
Re: Message icons in newbb under 2.4.2
  • 2009/12/5 14:11

  • skyangelo

  • Just popping in

  • Posts: 79

  • Since: 2005/4/9 1


I put this directly in XOOPS CSS file (xoops root folder), in case that I change another theme. And it works. Thanks a lot.
label[name="xolb_icon"], [name="xolb_dohtml"], [name="xolb_dosmiley"], [name="xolb_doxcode"], [name="xolb_dobr"], [name="xolb_attachsig"], [name="xolb_attachsig"], [name="xolb_notify"],  [name="xolb_private"], [name="xolb_updateping"], [name="xolb_specify_created"], [name="xolb_noname"], [name="xolb_view_require"]  { margin-left:                        0.5emdisplay:                            inline; }
However, I have another issue with the theme, the left column of the form is quite big (width = 40%) and I don't know how to change this.... The left column changed its width after update to 2.4.x. And I did not find in which CSS file to change this
<tr valign="top" align="left"><td class="head" style="width: 40%"><div class="xoops-form-element-caption">
Thanks a lot!

13
ghia
Re: Message icons in newbb under 2.4.2
  • 2009/12/5 15:00

  • ghia

  • Community Support Member

  • Posts: 4953

  • Since: 2008/7/3 1


That 40% is here also when eg posting in the forum. The normal style rule is for 20% I believe. It is indeed a change from 2.3.x to 2.4.2, there was a style rule included to the head tag in /class/xoopsform/themeform.php and tableform.php
$ret .= '<tr valign="top" align="left"><td class="head" style="width: 40%">';
I suggest you try to delete the style parameter.
style="width: 40%"
Apart from the change itself, it should not be done in that way, by mixing presentation and code.

14
skyangelo
Re: Message icons in newbb under 2.4.2
  • 2009/12/5 15:17

  • skyangelo

  • Just popping in

  • Posts: 79

  • Since: 2005/4/9 1


Done.
I changed it to 20% instead of 40%.
Thank you very much Ghia!

15
barryc
Re: Message icons in newbb under 2.4.2
  • 2009/12/5 19:04

  • barryc

  • Just can't stay away

  • Posts: 480

  • Since: 2004/3/20


Simply removing the style="width: 40%" fixes the problem too. I could only find that line of code in xoopsform.php and not in themeform.php.

barryc

16
ghia
Re: Message icons in newbb under 2.4.2
  • 2009/12/5 19:19

  • ghia

  • Community Support Member

  • Posts: 4953

  • Since: 2008/7/3 1


Weird!
It should be there. Check it once in your 2.4.2 ZIP file.
Could be some uploading problem.
Run the file check to detect other problems.

17
barryc
Re: Message icons in newbb under 2.4.2
  • 2009/12/5 22:37

  • barryc

  • Just can't stay away

  • Posts: 480

  • Since: 2004/3/20


My apologies. From my previous message you will be able to see that I screwed up which files I was looking in. The width: 40% statement was there in both xoopsforum/themeform.php and tableform.php. My excuse is that I have "a bug" today and am not feeling well.

I removed "width: 40%" from both files and things appear to be working correctly.

barryc

18
skyangelo
Re: Message icons in newbb under 2.4.2
  • 2009/12/6 0:27

  • skyangelo

  • Just popping in

  • Posts: 79

  • Since: 2005/4/9 1


Ghia,
do you know who to fix the column width issue with the "Notifications options" 3 columns?
the checkbox columns (i.e. the column in the middle) is too big...

Resized Image

19
ghia
Re: Message icons in newbb under 2.4.2
  • 2009/12/6 9:39

  • ghia

  • Community Support Member

  • Posts: 4953

  • Since: 2008/7/3 1


Isn't that a question of theme and templates?

20
skyangelo
Re: Message icons in newbb under 2.4.2
  • 2009/12/6 12:37

  • skyangelo

  • Just popping in

  • Posts: 79

  • Since: 2005/4/9 1


I don't think so.
Because I did not change anything in my theme or template.
The same thing (for the tableform, icon and column) happened just after upgrading to XOOPS 2.4.2.

Login

Who's Online

140 user(s) are online (99 user(s) are browsing Support Forums)


Members: 0


Guests: 140


more...

Donat-O-Meter

Stats
Goal: $100.00
Due Date: Apr 30
Gross Amount: $0.00
Net Balance: $0.00
Left to go: $100.00
Make donations with PayPal!

Latest GitHub Commits