6
Quote:
SMEDrieben wrote:
I upgraded from 2.5.7.2 tot 2.5.8 and get quite a lot of debug messages in teh admin section:
Onbekend: Only variables should be assigned by reference in bestand /modules/smartfaq/xoops_version.php regel 258
...
There appears to be similarity among those messages. Will they be solved with the module upgrades or must these problems be solved manually ?
SMEDrieben
This is a growing pain.
The issue actually goes back to a PHP 4 era technique where it was common to assign things
by reference to save memory. PHP has improved a lot since then, and along the way, these messages showed up. Someone helpfully suppressed those messages from showing up in the XOOPS logger for many years.
As of PHP 7, these suppressed warnings become actual errors, and will eventually cause even more serious problems.
We turned off the suppression in 2.5.8, because developers can't fix what they can't see. Production use -- without the logger enabled -- isn't changed at all, but with the logger people can see what must be fixed.
The most common situation is something like this:
$handler =& xoops_getHandler('foo');
that since PHP 5 should be (without a
&):
$handler = xoops_getHandler('foo');
We cleaned up core, and many modules, but there are more that still need to be fixed. Eventually module upgrades will fix these.
