xoops forums

Forum Index


Board index » All Posts (geekwright)




geekwright

Quite a regular
Posted on: 5/28 20:12
geekwright
geekwright (Show more)
Quite a regular
Posts: 303
Since: 2010/10/15
#1

Re: Module profile and translation update

Please see https://github.com/XOOPS/XoopsCore25/pull/841

It enables manual editing of the option text from a link at the bottom of the admin field edit form.


geekwright

Quite a regular
Posted on: 5/27 19:45
geekwright
geekwright (Show more)
Quite a regular
Posts: 303
Since: 2010/10/15
#2

Re: Module profile and translation update

Thank you for the more complete problem description. Wow, that sucks. I'll look deeper.


geekwright

Quite a regular
Posted on: 5/26 3:38
geekwright
geekwright (Show more)
Quite a regular
Posts: 303
Since: 2010/10/15
#3

Re: Module profile and translation update

After "profile" is installed, the definitive title and description source is no longer the language files, it is the database. You can edit all of that in the admin area -- much easier than saving tables and reinstalling since there are only 24 fields that could be affected.

I agree that the profile module's language support is limiting, but that is largely due to the ability to fully customize and extend the user definition. Needs improvement, but that it isn't likely to happen in the 2.5 series.


geekwright

Quite a regular
Posted on: 5/15 22:22
geekwright
geekwright (Show more)
Quite a regular
Posts: 303
Since: 2010/10/15
#4

Re: Help with Error redirections

I just want to make sure what you are asking for.

As I read this, it sounds to me that you want to intercept a URL
XOOPS_URL/?page=23
and have that instead result in an HTTP error, such as 404.

Is that correct?

Here are a few general observations.

While the link that is causing the issue is wrong, it is not technically an error. The custom error pages don't get called, as there is no HTTP error triggered. (The front page is found, and passed a query string it ignores.)

Something is creating the links that google follows. Until you find a correct that, there will still be a problem somewhere. Has anything been updated recently? As an example, I saw a module before with a XoopsPageNav error that generated links that looked a lot like this.

Goffy's suggestion about the search console sounded worthwhile.

Seeing the referrer for one of these problem URLs would pinpoint the actual source of the problem.

As a temporary solution, you could patch the XOOPS_ROOT_PATH/index.php

Adding this code on the next line after the opening "<?php" tag will cause any query string parameters to result in an error, and log the referrer if specified:
if (!empty($_GET)) {
    if (!empty(
$_SERVER['HTTP_REFERER'])) {
        @
file_put_contents(__DIR__ '/queryurllog.txt'$_SERVER['HTTP_REFERER'] . "n"FILE_APPEND);
    }
    
http_response_code(404);
    exit;
}


geekwright

Quite a regular
Posted on: 3/13 18:34
geekwright
geekwright (Show more)
Quite a regular
Posts: 303
Since: 2010/10/15
#5

Re: Cannot connect BDD Mysql

Where are you running the install code? On your local computer or on webcindario.com?

In the fourms at https://soporte.miarroba.com/ there are a number of problems reported because
mysql.webcindario.com does not accept external connections. The PHP code must be running on a webcindario.com server.


geekwright

Quite a regular
Posted on: 3/7 5:55
geekwright
geekwright (Show more)
Quite a regular
Posts: 303
Since: 2010/10/15
#6

Re: Github and language repository

Think about that in the other direction.

You have a your git clone of XOOPS-monxoops-Traduction-FR.
You also have your wamp accessible XoopsCore25.

Make a script (*.bat file) that will copy the htdoc directory from XOOPS-monxoops-Traduction-FR to the htdoc directory in XoopsCore25 (i.e. using robocopy). Add another line in the script to copy the upgrade directory, too. (You want to make sure you don't copy the ".git" folder as that would be bad.)

Now, adjust your workflow to edit your translation in your XOOPS-monxoops-Traduction-FR repository, then run the copy script to test everything in wamp.

If you automate this with a script, and always edit in the XOOPS-monxoops-Traduction-FR repository clone, you always have all the updates that need commited in the right place.

A couple of apologies:

Sorry that the language folders are so awkward to work with. Making the translations much easier to work with and install is a high priority in the next generation XoopsCore.

Also sorry to be vauge about the Windows commands -- last time I rebooted into Windows, I had to wait more that two hours for updates and I don't have that much time right now.


geekwright

Quite a regular
Posted on: 2/13 23:54
geekwright
geekwright (Show more)
Quite a regular
Posts: 303
Since: 2010/10/15
#7

Re: use line-break in tpl files

Quote:
goffy wrote: ... if I use
$xoopsMailer->assign('RESULT''Newsletter 1<br>Newsletter 2<br>Newsletter 3);
I get in the mails also Quote:
Newsletter 1
Newsletter 2
Newsletter 3
the same with \r\n, \r or \n how can I get a line break?
The string is defined in single quotes, so the \n and \r each are treated as 2 characters, not the control character you expect. https://www.php.net/manual/en/language ... ypes.string.syntax.single


geekwright

Quite a regular
Posted on: 1/17 21:49
geekwright
geekwright (Show more)
Quite a regular
Posts: 303
Since: 2010/10/15
#8

Re: Cannot enter in PUBLISHER module administration ... but "sometimes" ...

I had not realized the new module code was doing this. Cool feature.

I've got a few thoughts.

Looks like we should be checking the CURLINFO_RESPONSE_CODE with curl_getinfo() to make sure the return is a 200. A lot of other codes can be returned with a valid json body that are totally different than the releases body. An example is the 403 response code for a rate limit exceded error - https://developer.github.com/v3/#rate-limiting

We might also consider a more precise end point, like this:
https://api.github.com/repos/XoopsModu ... publisher/releases/latest

To be good github citizens, we should cache the results for some period of time so we don't generate hundreds of checks while doing publisher setup activities. The period could easily be an hour or more. Xmf\Module\Helper\Cache::cacheRead() could make that easy.

One last observation not directly related to this issue, since publisher can be cloned, it looks like this check will not get any data, or wrong data from another module.


geekwright

Quite a regular
Posted on: 1/14 5:49
geekwright
geekwright (Show more)
Quite a regular
Posts: 303
Since: 2010/10/15
#9

Re: Customize blocs with no title in the managment page

Went with the minimal change approach with comment style slash-slash-space starting the title. Simple, but effective.

https://github.com/XOOPS/XoopsCore25/pull/762


geekwright

Quite a regular
Posted on: 1/13 17:50
geekwright
geekwright (Show more)
Quite a regular
Posts: 303
Since: 2010/10/15
#10

Re: Customize blocs with no title in the managment page

This is a common problem, I know I have this issue. Perhaps, it would be best if it is handled outside of the theme in core?

I would suggest we treat a block title starting with "// " (slash, slash, space) as a comment, and suppress the title when the block is rendered.

This would allow switching themes without resulting in a bunch of "@ - " block titles

The "//" is a comment indicator in many languages (such as PHP, C, JAVA, JavaScript to name a few) so it could be semantically familiar for some.

What do you think?



TopTop
(1) 2 3 4 ... 21 »