xoops forums

zyspec

Module Developer
Posted on: 2013/5/17 15:30
zyspec
zyspec (Show more)
Module Developer
Posts: 1077
Since: 2004/9/21
#1

Xoopspoll v1.40 Beta 1 - Ready for testing

See news release for more complete details. Please report any issues you find here so we can work to resolve them quickly.

This is an BETA release, do not use it on a production site!

Xoopspoll is a XOOPS module that allows an administrator to create polls to query site users. This refactored revision provides the ability for site administrators to create multiple poll types. This version adds the highly anticipated capability to allow anonymous voters, create blind poll types, create multiple selection polls, and introduces many additional new features.

Xoopspoll Features:
  • Create unlimited polls

  • XOOPS 2.5.x Administration GUI

  • Log all voters/votes

  • Integrated with forum (newbb) - irmtfan v4.31 branch

  • Limit votes by user

  • Notify poll creator when poll finishes

  • Multi-language support - no hard coded language strings

  • Set poll end time/date

  • Ability to restart an expired poll

  • Set poll weight (order) to change order of display in module


  • NEW Features in this version:
  • NEW - Now supports four (4) poll types:
    - Results always visible
    - Only show results after voted
    - Only show results after poll ends
    - Never show users the results

  • NEW - XOOPS search for question and answer fields

  • NEW - Block to select and display a specific poll

  • NEW - Black color graphic for answers

  • NEW - Allow adding more than 10 answers per poll

  • NEW - Ability to set poll start date to schedule future poll

  • NEW - Ability to import polls from XOOPS umfrage module

  • NEW - Support for SmartClone module (see extras folder)

  • NEW - Userlog plugin for index.php and pollresults.php

  • NEW - Ability to hide polls created with forum (newbb) from frontside of polls module

  • NEW - Persian translation (irmtfan)

  • NEW - Module preference (config) to show/hide vote/voter count

  • NEW - Ability to mail notification to poll voter (XOOPS users only)

  • NEW - Ability to set maximum number of answers allowed for multi-select poll

  • NEW - Ability for admin to clone a poll

  • NEW - Summary of results on admin log display

  • NEW - Ability for admin to PM voter in poll administration

  • NEW - XOOPS API using handlers for poll, option and log objects/classes


  • This is an BETA release, do not use it on a production site!

    Download: Xoopspoll v1.40 BETA 1 Release

    Backup your existing site before installing/upgrading any XOOPS module.

    timgno

    Module Developer
    Posted on: 2013/5/17 19:57
    timgno
    timgno (Show more)
    Module Developer
    Posts: 1504
    Since: 2007/6/21
    #2

    Re: Xoopspoll v1.40 Beta 1 - Ready for testing

    Problem with this downloads, I have a message for zip file not valid

    OS: Win 8 Pro 64bit

    zyspec

    Module Developer
    Posted on: 2013/5/17 20:57
    zyspec
    zyspec (Show more)
    Module Developer
    Posts: 1077
    Since: 2004/9/21
    #3

    Re: Xoopspoll v1.40 Beta 1 - Ready for testing

    I apologize timgno.

    The archive was mislabelled as a .zip file, it should have been a .tar.gz file.

    Here's a link to the correct file until we can get the link in the release announcement fixed.

    https://code.google.com/p/zyspec/downl ... ll_1.40_BETA1A_zyspec.zip

    zyspec

    Module Developer
    Posted on: 2013/5/17 21:10
    zyspec
    zyspec (Show more)
    Module Developer
    Posts: 1077
    Since: 2004/9/21
    #4

    Re: Xoopspoll v1.40 Beta 1 - Ready for testing

    Thanks to Mamba the link in the article and forum post above are now correct!

    irmtfan

    Module Developer
    Posted on: 2013/5/18 6:31
    irmtfan
    irmtfan (Show more)
    Module Developer
    Posts: 3419
    Since: 2003/12/7
    #5

    Re: Xoopspoll v1.40 Beta 1 - Ready for testing

    Very nice job! Thank you zyspec.
    Xoopspoll is developed and progressed in the right direction.
    Unfortunately I had not time recently to test xoopspoll and especially its integration with newbb but it is in the top of my list.

    noo-b

    Just can't stay away
    Posted on: 2013/5/18 11:15
    noo-b
    noo-b (Show more)
    Just can't stay away
    Posts: 456
    Since: 2007/10/23
    #6

    Re: Xoopspoll v1.40 Beta 1 - Ready for testing

    Congrats zyspec..

    nice new and improved features

    - currently testing it on new 2.5.5 installation
    XOOPS Version XOOPS 2.5.5
    PHP Version 5.3.1
    mySQL Version 5.1.41
    Server API apache2handler
    OS WINNT
    safe_mode Off
    register_globals Off
    magic_quotes_gpc Off
    allow_url_fopen On
    fsockopen On
    post_max_size 128M
    max_input_time 60
    output_buffering
    max_execution_time 60
    memory_limit 128M
    file_uploads On
    upload_max_filesize 128M


    - i tried hide result untill polls expired..i received this message
    Fatal error: Call to a member function hasExpired() on a non-object in D:\xampp\htdocs\255\modules\xoopspoll\class\poll.php on line 354


    - btw how do i upgrade from old to this final version later..just replace all the files ?

    will made futher testing..congrats again


    suggestion
    - disable comment link in block if comments are disable
    - display results as pie chart etc

    zyspec

    Module Developer
    Posted on: 2013/5/18 12:40
    zyspec
    zyspec (Show more)
    Module Developer
    Posts: 1077
    Since: 2004/9/21
    #7

    Re: Xoopspoll v1.40 Beta 1 - Ready for testing

    noo-b,

    Thanks for testing this...

    Here's a quick fix the problem you're seeing. In ./class/poll.php, line 354 replace:

    if (!$poll_obj->hasExpired()) {


    with:

    if (!$this->hasExpired()) {


    Quote:

    - btw how do i upgrade from old to this final version later..just replace all the files ?


    Yes, replace the existing files and then update the module as normal in XOOPS module administration panel.

    irmtfan

    Module Developer
    Posted on: 2013/5/20 10:55
    irmtfan
    irmtfan (Show more)
    Module Developer
    Posts: 3419
    Since: 2003/12/7
    #8

    Re: Xoopspoll v1.40 Beta 1 - Ready for testing

    Today i update newbb to support new xoopspoll and all old xoopspoll and umfrage versions and all new and old clones.
    because i have 2 xoopspoll in my website and now one can select them in newbb > preferences.
    Q: is this good to make it selectable? or just make it selectable for one time?
    please test this new version:
    http://svn.code.sf.net/p/xoops/svn/Xo ... b/branches/irmtfan/newbb/

    Thru my tests I found this issue in xoopspoll/class/poll.pph around line 285 function renderForm.
    to solve it I add a $extra:
    if (!$this->hasExpired()) {
                
    $endTimeText = new XoopspollFormDateTimePicker("<div class='bold middle'>" _AM_XOOPSPOLL_EXPIRATION "</div>"
                               
    'xu_end_time'
                                
    20
                                
    $xuEndTimestamp);
            } else {
                
    // START irmtfan add topic_id
                
    $extra "";
                foreach(
    $addHidden as $key=>$value) {
                    
    $extra="&amp;{$key}=" $value;
                }        
                
    $xuEndFormattedTime ucfirst(date(_MEDIUMDATESTRING$xuEndTimestamp));
                
    $endTimeText = new XoopsFormLabel("<div class='bold middle'>" _AM_XOOPSPOLL_EXPIRATION,
                                 
    sprintf(_AM_XOOPSPOLL_EXPIREDAT$xuEndFormattedTime)
                               . 
    "<br /><a href='{$rtnPage}?op=restart&amp;poll_id="
                               
    $this->getVar('poll_id') . $extra "'>" _AM_XOOPSPOLL_RESTART "</a></div>");
                
    // END irmtfan add topic_id
            
    }


    Q: how can we add hejira date? now it used jquery-ui-timepicker-addon.js and i think it is possible to add hejira system.
    I will work on it.

    zyspec

    Module Developer
    Posted on: 2013/5/20 15:23
    zyspec
    zyspec (Show more)
    Module Developer
    Posts: 1077
    Since: 2004/9/21
    #9

    Re: Xoopspoll v1.40 Beta 1 - Ready for testing

    @irmtfan,

    Quote:
    because i have 2 xoopspoll in my website and now one can select them in newbb > preferences.
    Q: is this good to make it selectable? or just make it selectable for one time?

    I'm not sure this is the best way. This could cause serious problems with operation if an Administrator changes this later. Here's a scenario to consider:

  • Install newbb and xoopspoll

  • Set xoopspoll as the poll module in newbb Preferences

  • Create 3 or 4 polls in xoopspoll through newbb topics

  • Install umfrage module

  • Create 2 polls in umfrage.

  • Set umfrage as poll module in newbb Preferences


  • The first few newbb topics with polls will now have the umfrage poll associated with the topic instead of the xoopspoll poll that was originally created for that topic. The last few newbb topics will not have a poll even though the newbb tables think that it does since a poll with that poll_id will not exist in umfrage.

    Unfortunately there's several other combinations of failure modes in newbb between umfrage and xoopspoll if they're both installed but I think making the Preferences setting of poll module increases the likelyhood that something will go wrong.

    Ideally we should probably create a 'poll_mid' column associated with the poll in the 'bb_topics' table so we can make sure the modules only modify polls associated with that particular module. This would simplify managing polls between modules. If we had this table column then having a Preferences setting to select a poll module would be fine.

    Quote:
    Thru my tests I found this issue in xoopspoll/class/poll.php around line 285 function renderForm. to solve it I add a $extra:


    Thanks for not only testing but helping find a solution. I've added an 'extra' fix to the class poll. I modified it slightly from the example above to provide a little more sanitation on the $addHidden var and to also make sure that 'op' and 'poll_id' aren't overwritten. I will check this into SVN soon and will be in the next release.

    irmtfan

    Module Developer
    Posted on: 2013/5/21 1:40
    irmtfan
    irmtfan (Show more)
    Module Developer
    Posts: 3419
    Since: 2003/12/7
    #10

    Re: Xoopspoll v1.40 Beta 1 - Ready for testing

    @zyspec:
    yes i knew that trouble.
    I cannot see any need or any mean (do you see any?) to have more than one xoopspoll integrated with newbb so IMO adding a new field to "bb_topics" for this purpose is just making more unneeded queries. The only need is let user to select the preferred xoopspoll module at the first step. once he select the xoopspoll module and create the first poll that selection should be hidden.

    besides in "irmtfan" branch of newbb i didnt implement any big feature until now. (eg: no field in tables) So the main question is am i allowed to make this branch more and more different with Alfred version.

    Also in general im against using mid field as a solution in modules.
    IMO dirname is better than mid because mid is not consistent in all installations. for example if somebody uninstall the xoopspoll module and install it again or wants to move tables from a site to another site the mid of xoopspoll is different and make it very hard or impossible to find issues.
    I know using the int field (mid) is faster than varchar (dirname) but i still think dirname is better.