@irmtfan,

Quote:
I'm not sure this is the best way. This could cause serious problems with operation if an Administrator changes this later. Here's a scenario to consider:

Install newbb and xoopspoll

Set xoopspoll as the poll module in newbb Preferences

Create 3 or 4 polls in xoopspoll through newbb topics

Install umfrage module

Create 2 polls in umfrage.

Set umfrage as poll module in newbb Preferences

The first few newbb topics with polls will now have the umfrage poll associated with the topic instead of the xoopspoll poll that was originally created for that topic. The last few newbb topics will not have a poll even though the newbb tables think that it does since a poll with that poll_id will not exist in umfrage.

Unfortunately there's several other combinations of failure modes in newbb between umfrage and xoopspoll if they're both installed but I think making the Preferences setting of poll module increases the likelyhood that something will go wrong.

Ideally we should probably create a 'poll_mid' column associated with the poll in the 'bb_topics' table so we can make sure the modules only modify polls associated with that particular module. This would simplify managing polls between modules. If we had this table column then having a Preferences setting to select a poll module would be fine.

Quote:

Thanks for not only testing but helping find a solution. I've added an 'extra' fix to the class poll. I modified it slightly from the example above to provide a little more sanitation on the $addHidden var and to also make sure that 'op' and 'poll_id' aren't overwritten. I will check this into SVN soon and will be in the next release.

@zyspec:
yes i knew that trouble.
I cannot see any need or any mean (do you see any?) to have more than one xoopspoll integrated with newbb so IMO adding a new field to "bb_topics" for this purpose is just making more unneeded queries. The only need is let user to select the preferred xoopspoll module at the first step. once he select the xoopspoll module and create the first poll that selection should be hidden.

besides in "irmtfan" branch of newbb i didnt implement any big feature until now. (eg: no field in tables) So the main question is am i allowed to make this branch more and more different with Alfred version.

Also in general im against using mid field as a solution in modules.
IMO dirname is better than mid because mid is not consistent in all installations. for example if somebody uninstall the xoopspoll module and install it again or wants to move tables from a site to another site the mid of xoopspoll is different and make it very hard or impossible to find issues.
I know using the int field (mid) is faster than varchar (dirname) but i still think dirname is better.