xoops forums

edipinho

Just popping in
Posted on: 2010/12/8 18:04
edipinho
edipinho (Show more)
Just popping in
Posts: 87
Since: 2003/10/15
#1

Small correction in Xoops 2.5.0 (Ranks and Smilies)

### Amendment - Correction ###



====================
/modules/system/admin/smilies/main.php

(so this)
72 $smilies['image'] = '<img src="' . XOOPS_UPLOAD_URL . '/' . $smilies_img . '" alt="" />';
(is thus)
72 $smilies['image'] = '<img src="' . XOOPS_UPLOAD_URL . '/smilies/' . $smilies_img . '" alt="" />';

====================
/modules/system/admin/userrank/main.php

(so this)
75 $userrank['rank_image'] = '<img src="'.XOOPS_UPLOAD_URL.'/'.$rank_img.'" alt="" />';
(is thus)
75 $userrank['rank_image'] = '<img src="'.XOOPS_UPLOAD_URL.'/ranks/'.$rank_img.'" alt="" />';

?? I changed but I do not know what the outcome. ??
(so this)
186 xoops_confirm(array("ok" => 1, "rank_id" => $_REQUEST["rank_id"], "op" => "userrank_delete"), $_SERVER["REQUEST_URI"],

sprintf(_AM_SYSTEM_USERRANK_SUREDEL) . '<br \><img src="' . XOOPS_UPLOAD_URL . '/' . $rank_img . '" alt="" /><br \>');
(is thus)
186 xoops_confirm(array("ok" => 1, "rank_id" => $_REQUEST["rank_id"], "op" => "userrank_delete"), $_SERVER["REQUEST_URI"],

sprintf(_AM_SYSTEM_USERRANK_SUREDEL) . '<br \><img src="' . XOOPS_UPLOAD_URL . '/ranks/' . $rank_img . '" alt="" /><br \>');


=============================
/modules/profile/class/field.php

(so this)
328 $user_rankimage = '<img src="'.XOOPS_UPLOAD_URL . '/' . $userrank['image'] . '" alt="' . $userrank['title'] . '" /><br />';
(is thus)
328 $user_rankimage = '<img src="'.XOOPS_UPLOAD_URL . '/ranks/' . $userrank['image'] . '" alt="' . $userrank['title'] . '" /><br />';


===========================
File with the corrections :
http://edipinho.uni.cc/uploads/correcaoX250-ranks-smilies.zip

For now is working without problem.

T+

jcweb

Quite a regular
Posted on: 2010/12/9 0:16
jcweb
jcweb (Show more)
Quite a regular
Posts: 253
Since: 2005/4/25
#2

Re: Small correction in Xoops 2.5.0 (Ranks and Smilies)

Thanks! Your topic can connect with the topic, link below:
https://xoops.org/modules/newbb/viewto ... =&topic_id=72694&forum=74

Greets Andy

kraven30

Just popping in
Posted on: 2010/12/9 12:01
kraven30
kraven30 (Show more)
Just popping in
Posts: 88
Since: 2008/12/23
#3

Re: Small correction in Xoops 2.5.0 (Ranks and Smilies)

This is on purpose ^^
Quote:
72 $smilies['image'] = '<img src="' . XOOPS_UPLOAD_URL . '/' . $smilies_img . '" alt="" />';


you did an upgrade or new installation ?

jcweb

Quite a regular
Posted on: 2010/12/9 14:39
jcweb
jcweb (Show more)
Quite a regular
Posts: 253
Since: 2005/4/25
#4

Re: Small correction in Xoops 2.5.0 (Ranks and Smilies)

I can only talk about me, my xoops is a upgrade from 2.4.5 and i see it on other installations they did upgrade too, and have the same problem.

Andy

edipinho

Just popping in
Posted on: 2010/12/9 23:26
edipinho
edipinho (Show more)
Just popping in
Posts: 87
Since: 2003/10/15
#5

Re: Small correction in Xoops 2.5.0 (Ranks and Smilies)

My installation is new, I installed the direct x2.5.0.

jcweb

Quite a regular
Posted on: 2010/12/12 12:24
jcweb
jcweb (Show more)
Quite a regular
Posts: 253
Since: 2005/4/25
#6

Re: Small correction in Xoops 2.5.0 (Ranks and Smilies)

Hi all
I install last night some new and clear xoops 2.5.0. The error is with smilies and rank images already in new installations, so my meaning, it is a bug.

The fix you post @edipinho works, thanks again!

Greets Andy

jcweb

Quite a regular
Posted on: 2010/12/12 13:00
jcweb
jcweb (Show more)
Quite a regular
Posts: 253
Since: 2005/4/25
#7

Re: Small correction in Xoops 2.5.0 (Ranks and Smilies)

Again me

Can someone try and or confirm. Example: Send a PM and try to choose smilies. Its not work for me, same when you create a new block and choose smilies! Did we forget to edit the path in the editor?

Greets Andy

//Edit

I think a found it. In misc.php line 53

echo "<tr class='$rcolor'><td>" $smile['code'] . "</td><td>" $smile['emotion'] . "</td><td><img onmouseover='style.cursor="hand"' onclick='doSmilie(" " . $smile['code'] . " ");' src='" XOOPS_UPLOAD_URL "/" $smile['smile_url'] . "' alt='' /></td></tr>";


change to

echo "<tr class='$rcolor'><td>" $smile['code'] . "</td><td>" $smile['emotion'] . "</td><td><img onmouseover='style.cursor="hand"' onclick='doSmilie(" " . $smile['code'] . " ");' src='" XOOPS_UPLOAD_URL "/smilies/" $smile['smile_url'] . "' alt='' /></td></tr>";


Can someone check it out?

End//

kroewing

Friend of XOOPS
Posted on: 2011/1/12 15:02
kroewing
kroewing (Show more)
Friend of XOOPS
Posts: 7
Since: 2008/3/24
#8

Re: Small correction in Xoops 2.5.0 (Ranks and Smilies)

Hi folks,

my installation was an update from 2.4.5 as well. I know it is not mission critical and has no technical impact, but "The presentation makes it",

@Andy, I not so technical to figure out, sorry

Cheers!
Heinz

jcweb

Quite a regular
Posted on: 2011/1/20 15:07
jcweb
jcweb (Show more)
Quite a regular
Posts: 253
Since: 2005/4/25
#9

Re: Small correction in Xoops 2.5.0 (Ranks and Smilies)

Hi all
I see in another thread a link to the bugtracker, thereĀ“s (in the bugtracker) a comment its fixed, but its not fixed.

Andy

Mamba

Moderator
Posted on: 2011/1/20 15:15
Mamba
Mamba (Show more)
Moderator
Posts: 10838
Since: 2004/4/23
#10

Re: Small correction in Xoops 2.5.0 (Ranks and Smilies)

It's fixed in the trunk
Support XOOPS => DONATE
Use 2.5.10 | Docs | Modules | Bugs