1
edipinho
Small correction in Xoops 2.5.0 (Ranks and Smilies)
  • 2010/12/8 18:04

  • edipinho

  • Not too shy to talk

  • Posts: 107

  • Since: 2003/10/15


### Amendment - Correction ###



====================
/modules/system/admin/smilies/main.php

(so this)
72 $smilies['image'] = '<img src="' . XOOPS_UPLOAD_URL . '/' . $smilies_img . '" alt="" />';
(is thus)
72 $smilies['image'] = '<img src="' . XOOPS_UPLOAD_URL . '/smilies/' . $smilies_img . '" alt="" />';

====================
/modules/system/admin/userrank/main.php

(so this)
75 $userrank['rank_image'] = '<img src="'.XOOPS_UPLOAD_URL.'/'.$rank_img.'" alt="" />';
(is thus)
75 $userrank['rank_image'] = '<img src="'.XOOPS_UPLOAD_URL.'/ranks/'.$rank_img.'" alt="" />';

?? I changed but I do not know what the outcome. ??
(so this)
186 xoops_confirm(array("ok" => 1, "rank_id" => $_REQUEST["rank_id"], "op" => "userrank_delete"), $_SERVER["REQUEST_URI"],

sprintf(_AM_SYSTEM_USERRANK_SUREDEL) . '<br \><img src="' . XOOPS_UPLOAD_URL . '/' . $rank_img . '" alt="" /><br \>');
(is thus)
186 xoops_confirm(array("ok" => 1, "rank_id" => $_REQUEST["rank_id"], "op" => "userrank_delete"), $_SERVER["REQUEST_URI"],

sprintf(_AM_SYSTEM_USERRANK_SUREDEL) . '<br \><img src="' . XOOPS_UPLOAD_URL . '/ranks/' . $rank_img . '" alt="" /><br \>');


=============================
/modules/profile/class/field.php

(so this)
328 $user_rankimage = '<img src="'.XOOPS_UPLOAD_URL . '/' . $userrank['image'] . '" alt="' . $userrank['title'] . '" /><br />';
(is thus)
328 $user_rankimage = '<img src="'.XOOPS_UPLOAD_URL . '/ranks/' . $userrank['image'] . '" alt="' . $userrank['title'] . '" /><br />';


===========================
File with the corrections :
http://edipinho.uni.cc/uploads/correcaoX250-ranks-smilies.zip

For now is working without problem.

T+

2
jcweb
Re: Small correction in Xoops 2.5.0 (Ranks and Smilies)
  • 2010/12/9 0:16

  • jcweb

  • Quite a regular

  • Posts: 253

  • Since: 2005/4/25


Thanks! Your topic can connect with the topic, link below:
https://xoops.org/modules/newbb/viewto ... =&topic_id=72694&forum=74

Greets Andy

3
kraven30
Re: Small correction in Xoops 2.5.0 (Ranks and Smilies)
  • 2010/12/9 12:01

  • kraven30

  • Just popping in

  • Posts: 88

  • Since: 2008/12/23


This is on purpose ^^
Quote:
72 $smilies['image'] = '<img src="' . XOOPS_UPLOAD_URL . '/' . $smilies_img . '" alt="" />';


you did an upgrade or new installation ?

4
jcweb
Re: Small correction in Xoops 2.5.0 (Ranks and Smilies)
  • 2010/12/9 14:39

  • jcweb

  • Quite a regular

  • Posts: 253

  • Since: 2005/4/25


I can only talk about me, my xoops is a upgrade from 2.4.5 and i see it on other installations they did upgrade too, and have the same problem.

Andy

5
edipinho
Re: Small correction in Xoops 2.5.0 (Ranks and Smilies)
  • 2010/12/9 23:26

  • edipinho

  • Not too shy to talk

  • Posts: 107

  • Since: 2003/10/15


My installation is new, I installed the direct x2.5.0.

6
jcweb
Re: Small correction in Xoops 2.5.0 (Ranks and Smilies)
  • 2010/12/12 12:24

  • jcweb

  • Quite a regular

  • Posts: 253

  • Since: 2005/4/25


Hi all
I install last night some new and clear xoops 2.5.0. The error is with smilies and rank images already in new installations, so my meaning, it is a bug.

The fix you post @edipinho works, thanks again!

Greets Andy

7
jcweb
Re: Small correction in Xoops 2.5.0 (Ranks and Smilies)
  • 2010/12/12 13:00

  • jcweb

  • Quite a regular

  • Posts: 253

  • Since: 2005/4/25


Again me

Can someone try and or confirm. Example: Send a PM and try to choose smilies. Its not work for me, same when you create a new block and choose smilies! Did we forget to edit the path in the editor?

Greets Andy

//Edit

I think a found it. In misc.php line 53

echo "<tr class='$rcolor'><td>" $smile['code'] . "</td><td>" $smile['emotion'] . "</td><td><img onmouseover='style.cursor="hand"' onclick='doSmilie(" " . $smile['code'] . " ");' src='" XOOPS_UPLOAD_URL "/" $smile['smile_url'] . "' alt='' /></td></tr>";


change to

echo "<tr class='$rcolor'><td>" $smile['code'] . "</td><td>" $smile['emotion'] . "</td><td><img onmouseover='style.cursor="hand"' onclick='doSmilie(" " . $smile['code'] . " ");' src='" XOOPS_UPLOAD_URL "/smilies/" $smile['smile_url'] . "' alt='' /></td></tr>";


Can someone check it out?

End//


8
kroewing
Re: Small correction in Xoops 2.5.0 (Ranks and Smilies)
  • 2011/1/12 15:02

  • kroewing

  • Friend of XOOPS

  • Posts: 7

  • Since: 2008/3/24


Hi folks,

my installation was an update from 2.4.5 as well. I know it is not mission critical and has no technical impact, but "The presentation makes it",

@Andy, I not so technical to figure out, sorry

Cheers!
Heinz

9
jcweb
Re: Small correction in Xoops 2.5.0 (Ranks and Smilies)
  • 2011/1/20 15:07

  • jcweb

  • Quite a regular

  • Posts: 253

  • Since: 2005/4/25


Hi all
I see in another thread a link to the bugtracker, thereĀ“s (in the bugtracker) a comment its fixed, but its not fixed.

Andy

10
Mamba
Re: Small correction in Xoops 2.5.0 (Ranks and Smilies)
  • 2011/1/20 15:15

  • Mamba

  • Moderator

  • Posts: 11204

  • Since: 2004/4/23


It's fixed in the trunk
Support XOOPS => DONATE
Use 2.5.10 | Docs | Modules | Bugs

Login

Username:
Password:

Lost Password? Register now!

Who's Online

74 user(s) are online (56 user(s) are browsing Support Forums)


Members: 0


Guests: 74


more...

Donat-O-Meter

Stats
Goal: $100.00
Due Date: Nov 30
Gross Amount: $0.00
Net Balance: $0.00
Left to go: $100.00
Make donations with PayPal!

Latest GitHub Commits