xoops forums

sylvainb

Not too shy to talk
Posted on: 2004/5/22 7:50
sylvainb
sylvainb (Show more)
Not too shy to talk
Posts: 168
Since: 2003/2/11
#1

News v1.2 RC1

First of all, I really want to say that you have both done a good work on it.

Now time for question, is it a wanted thing that we are redirected to the main news page after submitting a news through the admin section of the module?
If I'm going into the 'Submit/Approve Permissions' menu and set up permissions by category (approve then submit and then view), only the last category appear to be set up!
In preferences if I choose in 'Authorized groups to upload' -> Approvers Only, even if I had set up correctly permissions for Webmasters, I can't see the upload option in the form.
But if I choose -> Submitters and Approvers then it's ok.
The mini calendar used to select a start and/or end date isn't working with opera browser and is starting each time on January, 2000.

Just my modest contribution to your great work.

Mithrandir

XOOPS is my life!
Posted on: 2004/5/22 8:08
Mithrandir
Mithrandir (Show more)
XOOPS is my life!
Posts: 6320
Since: 2003/6/21
#2

Re: News v1.2 RC1

Yes, you will need to fix the typo in modules/system/admin/groupperm.php as described in This bug report re. multiple group permission forms

The mini calendar is a core XoopsForm element, which has that bug of starting on Jan. 2000 on first invoking on the page - this will be fixed in XOOPS 2.0.7

edit: Didn't spot all those things, divide them more, please
We have combined the input forms so that the admin area and the user area uses the same input form. I guess it is possible to add a little to make it stay in admin area after submissal - this was not really intended, but after I submit something, I like to see how it looks afterwards, so I let it stay in.

sylvainb

Not too shy to talk
Posted on: 2004/5/22 8:36
sylvainb
sylvainb (Show more)
Not too shy to talk
Posts: 168
Since: 2003/2/11
#3

Re: News v1.2 RC1

1 - Sorry, the next time I'll try to make my posts more readable.
2 - I corrected typo in the groupperm.php and it works fine (sorry again to haven't noticed this bug report before ).
3 - As the Webmaster/Submitter of an article (and with corrects permissions), I still can't see the upload option while submitting an article through the admin section with 'Approvers Only' selected.
4 - I understand your point of view concerning the redirection but what about if you have to approve several news? (this is only a reflexion)
5 - Is this post sufficiently divided?

Mithrandir

XOOPS is my life!
Posted on: 2004/5/22 9:18
Mithrandir
Mithrandir (Show more)
XOOPS is my life!
Posts: 6320
Since: 2003/6/21
#4

Re: News v1.2 RC1

1 - thank you
3 - Yes, just found a typo in include/submitform.inc.php line 76 should be
case 2:
instead of
case 1:

and Line 79 should be
case 3:

4 - The approval of news could be better, I grant you - perhaps a separate area with the introtext and a checkbox with an "Approve" and "Delete" button below the table?
5 - It is excellent, thank you

davidl2

XOOPS is my life!
Posted on: 2004/5/22 9:20
davidl2
davidl2 (Show more)
XOOPS is my life!
Posts: 4843
Since: 2003/5/26
#5

Re: News v1.2 RC1

This sounds excellent!