XOOPS 
Forum
Forum Index General Forums Community Support Modules Support Themes Support Development International Support Module Hack Reviews Theme Designer Talk
  1. Board index / 
  2. XOOPS Community Support forums / 
  3. 2.4.x Support 
  4.  / Banners
Register
11
JammerPro
Re: Banners

  • 2009/11/2 18:14

  • JammerPro

  • Just popping in

  • Posts: 39

  • Since: 2008/8/24


So, does anyone have a temporary fix? I'm sure the developers will get to this in the next release judging by the other posts in this forum... However, I have some very upset advertising clients now.

If there's anything we can do in the interim, please let us know!

Thanks again for getting to the bottom of this!
12
trabis
Re: Banners

  • 2009/11/2 18:29

  • trabis

  • Core Developer

  • Posts: 2269

  • Since: 2006/9/1 1


Quote:

So, does anyone have a temporary fix?


Open banners.php, line 310 and add a '0'
if ($GLOBALS['xoopsSecurity']->checkReferer(0)) {
13
Mamba
Re: Banners

  • 2009/11/2 18:43

  • Mamba

  • Moderator

  • Posts: 11366

  • Since: 2004/4/23


Yes, it works now!
14
ghia
Re: Banners

  • 2009/11/3 11:06

  • ghia

  • Community Support Member

  • Posts: 4953

  • Since: 2008/7/3 1


The referer check is done, for not having banner clicks from the outside (links in other sites).

PS The 0 option parameter seems silly to me.
If you don't want to do a check, don't call the function.
Also inside the function
$ref = xoops_getenv('HTTP_REFERER');
if ($docheck == 0) {
    return true;
}
No need to find out the referer, if you don't want to do something with it.
15
trabis
Re: Banners

  • 2009/11/3 13:55

  • trabis

  • Core Developer

  • Posts: 2269

  • Since: 2006/9/1 1


Quote:

ghia wrote:
PS The 0 option parameter seems silly to me.
If you don't want to do a check, don't call the function.


I noticed that to, does not make sense.

@Mamba,
adding 0 is just for making it work, it is not a fix because it defeats the propose of the function.
16
Mamba
Re: Banners

  • 2009/11/3 14:03

  • Mamba

  • Moderator

  • Posts: 11366

  • Since: 2004/4/23


Quote:
adding 0 is just for making it work, it is not a fix because it defeats the propose of the function.

I assumed it was only a temporary fix, so his client don't complain to him, till we find a permanent fix
17
trabis
Re: Banners

  • 2009/11/3 20:30

  • trabis

  • Core Developer

  • Posts: 2269

  • Since: 2006/9/1 1


I was trying to access the url directly and that was why I was not getting a referrer. If I browse the site(arabxoops.com) using firefox I have no problem. If I use IE I have problems only in the news page.

Now try to open this page using firefox:
http://www.arabxoops.com/modules/news/article.php?storyid=22&com_id=474&com_rootid=474&#comment474

The quick comment hack (used on this site) is issuing a redirect. Javascript bugs may be in the origin of banners not working in my opinion.

Can anyone point other site where banners are not working?



18
Anonymous
Re: Banners

  • 2009/11/3 20:49

  • Anonymous

  • Posts: 0

  • Since:


comments hack not the cause, this bug happened in other sites.

example:
http://www.zfaat.com/banners.php?op=click&bid=4
it is blank in IE8
19
ghia
Re: Banners

  • 2009/11/3 21:55

  • ghia

  • Community Support Member

  • Posts: 4953

  • Since: 2008/7/3 1


Using the link you get (of course) always a blank page.
You must start with a page where the banner is visible eg:
http://www.zfaat.com/modules/news/
and then click on it.

In ie6 the XOOPS banner works (bid=3) and open XOOPS.org in the same window. The others open a new blank window.

In the template seems to be a starting <p align="center"> tag but no closing one. Also in the table, there seems a </tr> too many.

Also weird is that when doing refresh, you get sometimes one and sometimes two articles listed.
20
JammerPro
Re: Banners

  • 2009/11/4 14:25

  • JammerPro

  • Just popping in

  • Posts: 39

  • Since: 2008/8/24


Thanks so much for the "temporary" fix!

I am not all that familiar with XOOPS, although I can program in PHP.

I understand that by turning off the security code with the 0 is not a cure for the problem, only a temporary fix until you gurus can agree on a proper solution.

Hopefully in a few months I'll become more familiar with the CMS and be able to contribute something back...

All the best and thanks again.
« 1 (2) 3 4 »

Login

Register now!  |  Lost Password?

Search

Advanced Search

Recent Posts

Who's Online

234 user(s) are online (159 user(s) are browsing Support Forums)

Members: 0

Guests: 234

more...

Donat-O-Meter

Stats
Goal: $100.00
Due Date: Apr 30
Gross Amount: $0.00
Net Balance: $0.00
Left to go: $100.00
Make donations with PayPal!

Latest GitHub Commits