xoops forums

kaotik

Just can't stay away
Posted on: 2009/8/10 14:33
kaotik
kaotik (Show more)
Just can't stay away
Posts: 861
Since: 2004/2/19
#1

First comments on 2.4

New oxygen theme for admin looks great. I really like the use of jquery with tooltip plugin.
A couple of minor issues:
- Some tooltips have misspelled words "whit blocks". I can provide a full list later on as I find them.
- In List groups, the column width group ID is bigger then any other (click on groups from control panel).
I'm using firefox 3.5.2

frankblack

Just can't stay away
Posted on: 2009/8/10 15:08
frankblack
frankblack (Show more)
Just can't stay away
Posts: 830
Since: 2005/6/13
#2

Re: First comments on 2.4

I still notice extra spaces / linefeeds in several files (smarty nearly all) after the closing ?>.

This COULD lead to problems (sometimes eventually)...

class/soap/soapfactory.php line instead of:
if (file_exists($GLOBALS['xoops']->path('class/soap/'.strtolower(XOOPS_SOAP_LIB).'/'.strtolower(XOOPS_SOAP_LIB).'.php'))

must be:
if (file_exists($GLOBALS['xoops']->path('class/soap/'.strtolower(XOOPS_SOAP_LIB).'/'.strtolower(XOOPS_SOAP_LIB).'.php')))


class/auth/auth_ads.php line 93 instead of:
else {

must be:
} else {


class/auth/auth_ldap.php line 146 instead of:
else {

must be:
} else {


edit: added to bug tracker

Anonymous

Posted on: 2009/8/10 17:43
Anonymous
Anonymous (Show more)
Posts: 0
Since:
#3

Re: First comments on 2.4

install/img/xoops_2.3.3.png file not linked to any page or css file.

plz delete it and remove this line from checksum.md5 file:

install/img/xoops_2.3.3.png:8ad0cec440ef48b45f92fb04b2e69ad2

xsell

Quite a regular
Posted on: 2009/8/10 19:32
xsell
xsell (Show more)
Quite a regular
Posts: 245
Since: 2008/9/2 1
#4

Re: First comments on 2.4

are we going to Have Pure Php in this Version .. wht i mean By Pure is that we dont have to go beg Our Hosting Companies to enable , ini_set.. or the Disabled Function for Security Reasons ..

trabis

Core Developer
Posted on: 2009/8/10 19:49
trabis
trabis (Show more)
Core Developer
Posts: 2268
Since: 2006/9/1 1
#5

Re: First comments on 2.4

Please do not update a live site with 2.4 beta
I found some serious problems related with the ERM implementation and the hashing processing overhead.
Thanks.

Mamba

Moderator
Posted on: 2009/8/10 19:53
Mamba
Mamba (Show more)
Moderator
Posts: 10777
Since: 2004/4/23
#6

Re: First comments on 2.4

Quote:
Please do not update a live site with 2.4 beta

As we've said in the 2.4 announcement:

Please remember:This release is ONLY for testing! Do NOT use it on productions sites. And if you're installing it over previous test installation, make a BACKUP first!
Please also note that some hacks done for previous XOOPS versions might not work with this release: testing before installing is always a good choice

ghia

Community Support Member
Posted on: 2009/8/10 22:59
ghia
ghia (Show more)
Community Support Member
Posts: 4954
Since: 2008/7/3 1
#7

Re: First comments on 2.4

/userinfo.php does not contain a closing php tag.
}
include 
XOOPS_ROOT_PATH '/footer.php';


Many files have their include for mainfile replaced from
include 'mainfile.php';

to
include dirname(__FILE__) . DIRECTORY_SEPARATOR 'mainfile.php';

What is the point for having this?
To me it seems not a progress for readability nor for efficiency and it makes XOOPS dependent to external vars, which aren't set always right.

Also the standard gpl header
Quote:
// $Id: userinfo.php 2309 2008-11-09 05:45:57Z phppp $
// ------------------------------------------------------------------------ //
// XOOPS - PHP Content Management System //
// Copyright (c) 2000 XOOPS.org //
// <https://xoops.org/> //
// ------------------------------------------------------------------------ //
// This program is free software; you can redistribute it and/or modify //
// it under the terms of the GNU General Public License as published by //
// the Free Software Foundation; either version 2 of the License, or //
// (at your option) any later version. //
// //
// You may not change or alter any portion of this comment or credits //
// of supporting developers from this source code or any supporting //
// source code which is considered copyrighted (c) material of the //
// original comment or credit authors. //
// //
// This program is distributed in the hope that it will be useful, //
// but WITHOUT ANY WARRANTY; without even the implied warranty of //
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the //
// GNU General Public License for more details. //
// //
// You should have received a copy of the GNU General Public License //
// along with this program; if not, write to the Free Software //
// Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA //
// ------------------------------------------------------------------------ //

is been replaced by

Quote:
/*
You may not change or alter any portion of this comment or credits
of supporting developers from this source code or any supporting source code
which is considered copyrighted (c) material of the original comment or credit authors.

This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
*/

/**
* XOOPS User
*
* See the enclosed file license.txt for licensing information.
* If you did not receive this file, get it at http://www.fsf.org/copyleft/gpl.html
*
* @copyright The XOOPS Project http://sourceforge.net/projects/xoops/
* @license http://www.fsf.org/copyleft/gpl.html GNU General Public License (GPL)
* @package core
* @since 2.0.0
* @author Kazumi Ono <webmaster@myweb.ne.jp>
* @version $Id: userinfo.php 3151 2009-04-18 13:25:43Z catzwolf $
*/

Seems not entirly according to the guidelines for me.

Did not yet test with 2.4, but in 2.3.3 there is an error when automatic converting hostnames to links. You mention eg www.myhost.com and without url tags it becomes a link anyway. When you mention the site at the end of a sentence as in
Have a look at www.mysite.com.
then the full stop (point) is taken also in the link, which makes the link unreachable. Probably a bad regexp.

trabis

Core Developer
Posted on: 2009/8/10 23:59
trabis
trabis (Show more)
Core Developer
Posts: 2268
Since: 2006/9/1 1
#8

Re: First comments on 2.4

Hi Ghia,
Closing missing tags are optional. I think they should be removed in every file. This would avoid undesirable output if someone accidentally types an empty space(new line, etc) after the closing tag. Bur for consistency, we should put the closing tag there :)

I usually use this
include dirname(__FILE__) . '/mainfile.php';

I'm not aware of the need of normalizing the directory separator but, I think is important not to use relative paths.
An example:
when you include cp functions file from yourmod/admin/subfolder you get a mainfile.php not found. This happens because mainfile is included with '../../../' making it relative to yourmod/admin folder. If we used dirname(__FILE__) we could be pretty sure that the file would be found.
Maybe catz can explain it better.

I have no idea on why the gpl header was changed.
Maybe catz can explain.

"There is an error when automatic converting hostnames to links"
I did not fix this, maybe catz did.



trabis

Core Developer
Posted on: 2009/8/11 0:06
trabis
trabis (Show more)
Core Developer
Posts: 2268
Since: 2006/9/1 1
#9

Re: First comments on 2.4

Quote:

frankblack wrote:
I still notice extra spaces / linefeeds in several files (smarty nearly all) after the closing ?>.


I have updated 4 or 5 files in smarty. Some times is your php editor that does that. Are you using eclipse? Can you point me one of that files so I can check here?

Anonymous

Posted on: 2009/8/11 0:52
Anonymous
Anonymous (Show more)
Posts: 0
Since:
#10

Re: First comments on 2.4

xoopseditor is too big size .. is it required or optional ? please keep it away of XOOPS package so the user can choose what he/she like.