XOOPS 
Forum
Forum Index General Forums Community Support Modules Support Themes Support Development International Support Module Hack Reviews Theme Designer Talk
  1. Board index / 
  2. Xoops Development / 
  3. XOOPS Module Development
  4. Blue Move 
  5.  / SimpleNewsletter 2.32 Beta 1 released for testing
Register
11
Mamba
Re: SimpleNewsletter 2.32 Beta 1 released for testing

  • 2013/5/1 7:48

  • Mamba

  • Moderator

  • Posts: 11409

  • Since: 2004/4/23


Quote:
It works good, but there should be some way to edit or delete members from the list

Now that we have xNewsletter that seems to be actively developed, we might look into merging those two. I would suggest to test xNewsletter and if it is missing some features from SimpleNewsletter that you find useful, then please communicate it to the xNewsletter developers.
Support XOOPS => DONATE
Use 2.5.11 | Docs | Modules | Bugs
12
SMEDrieben
Re: SimpleNewsletter 2.32 Beta 1: new bug: Solved

  • 2013/5/4 19:42

  • SMEDrieben

  • Not too shy to talk

  • Posts: 173

  • Since: 2009/6/17


There is another bug: icons for editing and deleting members are not displayed in the admin (members section). In the php-debug info, it is stated that $icones is not defined (admin/main.php line 777 and 778).

$icones is defined in include/common.php. This script wasn't changed since the previous version, but I think that the language definitions are loaded differently (already loaded befor loading of common.php). In the previous version common.php ended as:

// Définition des images
if( !defined("_SIMPLENEWSLETTER_EDIT")) {
    simplenewsletter_utils::loadLanguageFile('main.php');
    $icones = array(
        'edit' => ". SIMPLENEWSLETTER_IMAGES_URL ."edit.png' alt='"._SIMPLENEWSLETTER_EDIT."' align='middle' />",
        'delete' => ". SIMPLENEWSLETTER_IMAGES_URL ."delete.png' alt='"._SIMPLENEWSLETTER_DELETE."' align='middle' />",
        'validate' => ". SIMPLENEWSLETTER_IMAGES_URL ."button_ok.png' alt='"._SIMPLENEWSLETTER_VALIDATE."' align='middle' />"
    );
}


I changed the script to:

// Définition des images
if( !defined("_SIMPLENEWSLETTER_EDIT")) {
    simplenewsletter_utils::loadLanguageFile('main.php');
}
    $icones = array(
        'edit' => ". SIMPLENEWSLETTER_IMAGES_URL ."edit.png' alt='"._SIMPLENEWSLETTER_EDIT."' align='middle' />",
        'delete' => ". SIMPLENEWSLETTER_IMAGES_URL ."delete.png' alt='"._SIMPLENEWSLETTER_DELETE."' align='middle' />",
        'validate' => ". SIMPLENEWSLETTER_IMAGES_URL ."button_ok.png' alt='"._SIMPLENEWSLETTER_VALIDATE."' align='middle' />"
    );


The buttons are back !

SMEDrieben
13
SMEDrieben
Re: SimpleNewsletter 2.32 Beta 1: new bug: Solved

  • 2013/5/5 19:42

  • SMEDrieben

  • Not too shy to talk

  • Posts: 173

  • Since: 2009/6/17


Even better to refer to the system icons stored in Frameworks/moduleclasses/icons:

// Définition des images
if( !defined("_SIMPLENEWSLETTER_EDIT")) {
    simplenewsletter_utils::loadLanguageFile('main.php');
}
    $icones = array(
        'edit' => ". $pathIcon16 . "/edit.png' alt='"._SIMPLENEWSLETTER_EDIT."' align='middle' />",
        'delete' => ". $pathIcon16 ."/delete.png' alt='"._SIMPLENEWSLETTER_DELETE."' align='middle' />",
        'validate' => ". $pathIcon16 ."on.png' alt='"._SIMPLENEWSLETTER_VALIDATE."' align='middle' />"
    );


SMEDrieben
14
Mamba
Re: SimpleNewsletter 2.32 Beta 1: new bug: Solved

  • 2013/5/5 21:05

  • Mamba

  • Moderator

  • Posts: 11409

  • Since: 2004/4/23


Quote:
Even better to refer to the system icons stored in Frameworks/moduleclasses/icons:

Thanks for the testing and the reporting the issue, I'll fix it in the next version.
Support XOOPS => DONATE
Use 2.5.11 | Docs | Modules | Bugs
15
SMEDrieben
Re: SimpleNewsletter 2.32 Beta 1 released for testing

  • 2013/5/7 19:14

  • SMEDrieben

  • Not too shy to talk

  • Posts: 173

  • Since: 2009/6/17


In the main page (index.php, not the admin), common.php generates an error with $PathIcon16. It can be solved by adding a new line:

global $pathIcon16;
    $icones = array(
        'edit' => ". $pathIcon16 . "/edit.png' alt='"._SIMPLENEWSLETTER_EDIT."' align='middle' />",
        'delete' => ". $pathIcon16 ."/delete.png' alt='"._SIMPLENEWSLETTER_DELETE."' align='middle' />",
        'validate' => ". $pathIcon16 ."on.png' alt='"._SIMPLENEWSLETTER_VALIDATE."' align='middle' />"
    );


Furthermore, in php 5.3 the .htaccess generates an error. Removal of this file solves the problem.

SMEDrieben
16
chefry
Re: SimpleNewsletter 2.32 Beta 1 released for testing

  • 2013/5/8 12:00

  • chefry

  • Home away from home

  • Posts: 1005

  • Since: 2006/10/14


Quote:

Mamba wrote:
Quote:
It works good, but there should be some way to edit or delete members from the list

Now that we have xNewsletter that seems to be actively developed, we might look into merging those two. I would suggest to test xNewsletter and if it is missing some features from SimpleNewsletter that you find useful, then please communicate it to the xNewsletter developers.


SVN doesn't seem to reflect a lot of changes to xnewsletter I'm seeing in the forums.

THe last update in SVN was January and there were a lot of post in Feb/March.

So where is the most recent debugged version?
17
zyspec
Re: SimpleNewsletter 2.32 Beta 1 released for testing

  • 2013/5/8 13:31

  • zyspec

  • Module Developer

  • Posts: 1095

  • Since: 2004/9/21


chefry,

It would be better to ask this in a forum about xNewsletter (like https://xoops.org/modules/newbb/viewtopic.php?post_id=351893) instead of the SimpleNewsletter thread...

It appears alfred was the one committing to update xNewsletter so maybe you could send him a PM and ask the status.
18
chefry
Re: SimpleNewsletter 2.32 Beta 1 released for testing

  • 2013/5/8 14:12

  • chefry

  • Home away from home

  • Posts: 1005

  • Since: 2006/10/14


I like simple newsletter better anyway
19
Mamba
SimpleNewsletter 2.32 Beta 2 released for testing

  • 2013/5/12 7:38

  • Mamba

  • Moderator

  • Posts: 11409

  • Since: 2004/4/23


@ Black_beard:
Quote:
the bug happens by activating a block and when I return to my home page

I couldn't replicate it. Could you provide more details? Which exactly block is being activated in each module? What PHP version?

SMEDrieben fixed several things, and I have committed his code as 2.32 Beta 2 to our SVN. Thanks SMEDrieben for doing it!

Please test it and let us know about any bugs
Support XOOPS => DONATE
Use 2.5.11 | Docs | Modules | Bugs
20
chefry
Re: SimpleNewsletter 2.32 Beta 1 released for testing

  • 2013/5/12 8:03

  • chefry

  • Home away from home

  • Posts: 1005

  • Since: 2006/10/14


Edit and delete icons appear but there seems to be another icon missing

"Validate"

It appears for a member you have manually entered into the list

http://xxx/Frameworks/moduleclasses/icons/16on.png

I think it's supposed to be

http://xxx/Frameworks/moduleclasses/icons/16/on.png
« 1 (2) 3 »

Login

Register now!  |  Lost Password?

Search

Advanced Search

Recent Posts

Who's Online

335 user(s) are online (169 user(s) are browsing Support Forums)

Members: 0

Guests: 335

more...

Donat-O-Meter

Stats
Goal: $100.00
Due Date: Nov 30
Gross Amount: $0.00
Net Balance: $0.00
Left to go: $100.00
Make donations with PayPal!

Latest GitHub Commits