@blackrx:
Thank you for your test. specially I missed this one:
Module File for system-root Not Found!
I add system-root to userlog when there is no module ($xoopsModule == NULL) defined to distinct pages in YOURSITE/modules/MODULE_DIRNAME/script.php from root pages like YOURSITE/admin.php, YOURSITE/search.php, YOURSITE/index.php, ...
It is nothing more than an echo (so it not important because there is no error, warning,mal functioning, ...)
It is because after my definition XOOPS CORE think system-root is a module with "YOURSITE/modules/system-root" folder.
IMO XOOPS CORE should think about implement something in those root pages that no module defined because XOOPS is a completely modular CMS and always there is a module in action ( here: in YOURSITE/admin.php it is system module)
Anyway I will add a fix for this one.
Quote:
2. I cant have more than 1 setting... is this normal ?
maybe i didnt understand you well but i think you tried to have more than one setting for one (logby,unique id) eg: uid=1, gid=3, ...
It is useless and not allowed by the userlog module to have more than one setting for one (logby,unique id). you should have one setting for one (logby,unique id)
see in sql file i wrote:
CREATE TABLE mod_userlog_set (
set_id mediumint(8) unsigned NOT NULL auto_increment,
name varchar(100) NOT NULL default '',
logby varchar(10) NOT NULL default '',
unique_id int(11) unsigned NOT NULL default 0,
options TEXT NOT NULL,
scope TEXT NOT NULL,
PRIMARY KEY (set_id),
UNIQUE logby_id (logby, unique_id)
) ENGINE=MyISAM;
I defined a UNIQUE logby_id index so i am sure you cannot add more than one setting for one (logby, unique_id)
but now I find that userlog will not check when user try to edit a setting (logby,unique id) and change it to an
exist one in admin/setting.php
I will add an error checking.
Anyway if i missed some error checkings the great XOOPS CORE will not allow you to add bad configs!!!. It will be the beauty of using XOOPS API!!!
Quote:
3. column option not removed after updating setting
huum. If i understand you it seems you want to remove all options in a setting. it is impossible. I described it:
Quote:
Options
Log which user/page data? Notice: selecting no option means all options. Selecting no store option (File and/or Database) means Database. Selecting views means store uid, groups, script name, pagetitle,pageadmin, module dirname, module name, item name, item id in Database
so selecting no option means selecting all options and you should select at least one option. if you dont need a setting (you dont need to log somebody) you should
delete that settingQuote:
1. how to make referer url clickable ?
I intended to not add any new feature until the module got stable.
but this is a user side feature and it is very very easy to add because i used templates.
in templates/userlog_admin_logs.html you can customize anything for yourself:
e.g. to make referer url clickable:
<{elseif $header == "admin" || $header == "pageadmin"}>
<{if $log.$header == 1}><{$smarty.const._YES}><{else}><{$smarty.const._NO}><{/if}>
<{elseif $header == "referer"}>
<a href="<{$log.referer}>"><{$log.referer}></a>
<{elseif $header == "item_id"}>
<{if $log.item_id gt 0}><{$log.item_id}><{/if}>
you can find all $header values by turn smart debug on.
I will add this feature too.
It would be very good If some theme designers could show us better template for userlog.
EDIT:
I commit to svn:
revision 11368
http://svn.code.sf.net/p/xoops/svn/XoopsModules/userlog/trunk/
