I removed more hardcodes in newbb 4.3 and It is now even cleaner than XOOPS 2.5.5 :d
Please download the newest version(rev.9992):
http://www.jadoogaran.org/test255/modules/newbb43_rev9883_irmtfan_2012_08_06.zipchangelog for rev.9992 start from the last official rev.9883:
Changelog from rev.9883
date: 2012-08-06
================================================
1- hardcode fix: using header php command instead of redirect_header XOOPS function (deka87/irmtfan)
in newbb/search.php
(Also hardcoded in latest core in xoops2.5.5/htdocs/search.php)
2- hardcode fix: icon_path smarty variable was hardcoded in viewtopic and viewpost and is not defined in class/forum.php (irmtfan)
in newbb/viewtopic.php, newbb/viewpost.php, newbb/class/forum.php
3- hardcode icons and some hardcodes has been solved in templates:
in newbb/templates/newbb_thread.html, newbb/templates/newbb_index.html, newbb/templates/newbb_viewforum_subforum.html
4- add readme.txt
in docs/readme.txt
date: 2012-08-04
================================================
1- bug fixed: error in newbb/polls.php when the strtotime is not defined in XoopsLocal class (irmtfan)
solution: replace XoopsLocal::strtotime($end_time) by method_exists('XoopsLocal', 'strtotime') ? XoopsLocal::strtotime($end_time) : strtotime($end_time)
in newbb/polls.php
2- more hardcodes in newbb/templates has been removed
date: 2012-08-01
================================================
1- localization: input date localized (for other date systems like hegira) by replacing strtotime by XoopsLocal::strtotime
in newbb/polls.php
2- customization&localization: newbb style.css is fully localized and customized and is not hard-coded anymore.
in newbb/header.php
file changes:
-- deleted newbb/templates/style.css
-- added newbb/templates/images/language/english/style.css
-- added newbb/templates/images/language/persian/style.css
priorities:
if exist in themes/YOUR_THEME/modules/newbb/images/language/YOUR_LANG/style.css take it
else if exist in themes/default/modules/newbb/images/language/YOUR_LANG/style.css take it
else if exist in modules/newbb/templates/images/language/YOUR_LANG/style.css take it
else if exist in modules/newbb/templates/images/language/english/style.css take it
else if exist in modules/newbb/templates/style.css take it (for backward compatibility)
3- many hardcodes in newbb/templates and style.css has been removed
date: 2012-07-30
================================================
1- bug fix: edit not displayed when the reason is not filled (irmtfan)
2- bug fix: only the last edit is recorded. (irmtfan/alfred)
in newbb/class/post.php
3- bug fix: 'noapprove' permission incorrectly recorded in database. (irmtfan)
in newbb/class/permission.php
4- bug fix: load user ranks has been hardcoded. it works in old/upgraded websites but not works in new installed websites. a new getting rank introduced. (black_beard/irmtfan)
in newbb/class/user.php, newbb/templates/newbb_thread.html
5- minor bug fix: mysql 5.1 was incorrectly needed (irmtfan)
in newbb/xoops_version.php
6- hardcode: some style.css color hardcodes has been removed. (irmtfan)
in newbb/templates/style.css
7- feature added: text links instead of buttons. (deka87/irmtfan)
in newbb/class/icon.php , newbb/include/functions.render.php , newbb/include/plugin.php
Also i update the SVN:
(rev.9992)
http://xoops.svn.sourceforge.net/viewvc/xoops/XoopsModules/newbb/branches/irmtfan/newbbYurdal:
I checked your icons and they are visually better but their sizes are large than the original icons. could you reduce their sizes?
deka87:
Quote:
I also want to point out that here on xoops.org we have the same issue when making a reply or starting a new topic.
You are wrongly think this is the issue in xoops.org but i should tell you that the webmaster of this website (Mamba) intentionally set this redirect method to the old default redirect.
You can see the redirect in comments is also old redirect.
from the above i think you didnt set the redirect to jQuery?
in system -> preferences -> general setting -> replace old redirection by jGrowl redirection -> YES
if you already set it to yes i have another question from you.
Is that work in your whole website and only it is not work in newbb?
i mean when you submitting comments or login could you see the jQuery redirect?
If you only have this problem in newbb module we can continue debug this issue.
Nick_James:
IMO doing those hacks in xoops_version.php that Mamba suggest are risky and it should be done by a experienced webmaster who is completely familiar with XOOPS API, php and mysql
Also i should explain this Mamba sentence:
Quote:
But you'll need to do it everytime you update newBB to a new version.
mamba means
if you hack your old xoops_version.php you have to hack again the new xoops_version.php every time you update newbb.
it means if you dont touch xoops_version.php all your
old settings in preferences will be as before in any update.
eg: sub forums display mode will not changed after upgrade from 3.08 to 4.3
But obviously new settings (eg: settings that are not exist in 3.08 but introduced in 4.3) will be set by the default values in xoops_version.php
Anyway IMO setting the preferences options just take 5 minutes for any webmaster so do not bother yourself by hacking module files.
filpse:
is your problem solved with the attachment? I mean they should be shown to anonymous by setting in the preferences.
Cesag:
I dont know whether your problem with attachments is solved or not.
Mamba:
I also dont know the xoops.org issue with the templates has been solved or not?
