71
Mamba
Re: News 1.67 Final released for XOOPS 2.5.5
  • 2012/7/30 18:27

  • Mamba

  • Moderator

  • Posts: 11275

  • Since: 2004/4/23


Quote:
may I suggest that a news post be created so everyone knows about it. Maybe tell us what are the changes.

Cesag just added few icons. There were no other changes.

To get the icons, you will be able to just download the "ModuleAdmin" from XOOPS SVN.

Once we finalize the Basic Module Pack, the ModuleAdmin will be included there as well.
Support XOOPS => DONATE
Use 2.5.10 | Docs | Modules | Bugs

72
Mamba
Re: News 1.67 Final released for XOOPS 2.5.5
  • 2012/7/30 18:37

  • Mamba

  • Moderator

  • Posts: 11275

  • Since: 2004/4/23


Quote:
I think is necessary convert all module with this, and remove all personal make pdf.

That's exactly the plan

As you can see in the XOOPS SVN, we have added TCPDF to the /Frameworks, so all modules from the Basic Module Pack will be able to access it directly in one location.

Of course, the challenge will be to convert all modules to use TCPDF, but Black Beard showed how to do it with News, so hopefully others will use it as an example and do the same.
Support XOOPS => DONATE
Use 2.5.10 | Docs | Modules | Bugs

73
black_beard
Re: News 1.67 Final released for XOOPS 2.5.5

hello,
Tomorrow, I added these features in TCPDF Frameworks:
- Removal of exotic fonts (an idea mamba)
- Support for some local police (Chinese, Japanese, Korean, Arabic) with automatic selection in the file tcpdf_config.php (an idea irmtfan)
- Add files and schinese.php tchinese.php directory
- Update the class TCPDF (5.9.172 => 5.9.176)

If you have other ideas to suggest me, please,

74
Mamba
Re: News 1.67 Final released for XOOPS 2.5.5
  • 2012/7/31 3:18

  • Mamba

  • Moderator

  • Posts: 11275

  • Since: 2004/4/23


Quote:
If you have other ideas to suggest me, please,

Thank you so much for doing it, and following up. I wish, there would be more people like you! Thank you again!

Let's make this download as small as possible, with only the minimum required fonts. People can download all the "fancy" fonts later, if they want to

Support XOOPS => DONATE
Use 2.5.10 | Docs | Modules | Bugs

75
irmtfan
Re: News 1.67 Final released for XOOPS 2.5.5
  • 2012/7/31 5:19

  • irmtfan

  • Module Developer

  • Posts: 3419

  • Since: 2003/12/7


Quote:

Let's make this download as small as possible, with only the minimum required fonts. People can download all the "fancy" fonts later, if they want to

+1
It is very important. 11MB is very large.
Quote:

Support for some local police (Chinese, Japanese, Korean, Arabic) with automatic selection in the file tcpdf_config.php (an idea irmtfan)

Thank you so much black_beard.
I wish it could read the fonts from language/_LOCAL_LANG/fonts. It will greatly reduce the size of needed fonts for each local party.

76
panwac
Re: News 1.67 Final released for XOOPS 2.5.5
  • 2012/7/31 17:00

  • panwac

  • Just popping in

  • Posts: 62

  • Since: 2005/11/12


News 1.67 - an error in RSS for topic (news/backendt.php) - after upgrade I lost my polish signs (sth is wrong with encoding).

I replaced backendt.php file with older version (in this moment I don't remember, it was from news by trabis or other) and now everything is O.K.

Below a code from old backendt.php (three differences in first part of code are on red)

Quote:
<?php
// $Id$
// ------------------------------------------------------------------------ //
// XOOPS - PHP Content Management System //
// Copyright (c) 2000 XOOPS.org //
// <https://xoops.org/> //
// ------------------------------------------------------------------------ //
// This program is free software; you can redistribute it and/or modify //
// it under the terms of the GNU General Public License as published by //
// the Free Software Foundation; either version 2 of the License, or //
// (at your option) any later version. //
// //
// You may not change or alter any portion of this comment or credits //
// of supporting developers from this source code or any supporting //
// source code which is considered copyrighted (c) material of the //
// original comment or credit authors. //
// //
// This program is distributed in the hope that it will be useful, //
// but WITHOUT ANY WARRANTY; without even the implied warranty of //
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the //
// GNU General Public License for more details. //
// //
// You should have received a copy of the GNU General Public License //
// along with this program; if not, write to the Free Software //
// Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA //
// ------------------------------------------------------------------------ //
/**
* RSS per topics
*
* This script is used to generate RSS feeds for each topic.
* You can enable and disable this feature with the module's option named "Enable RSS feeds per topics ?"
* The script uses the permissions to know what to display.
*
* @package News
* @author Xoops Modules Dev Team
* @copyright (c) The Xoops Project - www.xoops.org
* @param type $nomvariable description
*/
include_once 'header.php';
include_once '../../mainfile.php';
include_once XOOPS_ROOT_PATH.'/class/template.php';
include_once XOOPS_ROOT_PATH.'/modules/news/class/class.newsstory.php';
include_once XOOPS_ROOT_PATH.'/modules/news/class/class.newstopic.php';
include_once XOOPS_ROOT_PATH.'/modules/news/include/functions.php';

error_reporting(0);
$GLOBALS['xoopsLogger']->activated = false;

if(!news_getmoduleoption('topicsrss')) {
exit();
}

$topicid = isset($_GET['topicid']) ? intval($_GET['topicid']) : 0;
if($topicid == 0) {
exit();
}

if (function_exists('mb_http_output')) {
mb_http_output('pass');
}

$restricted = news_getmoduleoption('restrictindex');
$newsnumber = news_getmoduleoption('storyhome');

$charset = 'utf-8';

header ('Content-Type:text/xml; charset='.$charset);
$story = new NewsStory();
$tpl = new XoopsTpl();
$tpl->xoops_setCaching(2);
$tpl->xoops_setCacheTime(3600);
if (!$tpl->is_cached('db:news_rss.html',$topicid)) {
xoops_load('XoopsLocal');
$xt = new NewsTopic($topicid);
$sarray = $story->getAllPublished($newsnumber, 0, $restricted, $topicid);
if (is_array($sarray) && count($sarray)>0) {
$sitename = htmlspecialchars($xoopsConfig['sitename'], ENT_QUOTES);
$slogan = htmlspecialchars($xoopsConfig['slogan'], ENT_QUOTES);
$tpl->assign('channel_title', XoopsLocal::convert_encoding($sitename));
$tpl->assign('channel_link', XOOPS_URL.'/');
$tpl->assign('channel_desc', XoopsLocal::convert_encoding($slogan));
$tpl->assign('channel_lastbuild', formatTimestamp(time(), 'rss'));
$tpl->assign('channel_webmaster', checkEmail($xoopsConfig['adminmail'],true)); // Fed up with spam
$tpl->assign('channel_editor', checkEmail($xoopsConfig['adminmail'],true)); // Fed up with spam
$tpl->assign('channel_category', $xt->topic_title());
$tpl->assign('channel_generator', 'XOOPS');
$tpl->assign('channel_language', _LANGCODE);
$tpl->assign('image_url', XOOPS_URL.'/images/logo.png');
$dimention = getimagesize(XOOPS_ROOT_PATH.'/images/logo.png');
if (empty($dimention[0])) {
$width = 88;
} else {
$width = ($dimention[0] > 144) ? 144 : $dimention[0];
}
if (empty($dimention[1])) {
$height = 31;
} else {
$height = ($dimention[1] > 400) ? 400 : $dimention[1];
}
$tpl->assign('image_width', $width);
$tpl->assign('image_height', $height);
$count = $sarray;
foreach ($sarray as $story) {
$storytitle = $story->title();
//if we are allowing html, we need to use htmlspecialchars or any bug will break the output
$description = htmlspecialchars($story->hometext(), ENT_QUOTES);
$tpl->append('items', array(
'title' => XoopsLocal::convert_encoding(htmlspecialchars($storytitle, ENT_QUOTES)) ,
'link' => XOOPS_URL.'/modules/news/article.php?storyid='.$story->storyid(),
'guid' => XOOPS_URL.'/modules/news/article.php?storyid='.$story->storyid(),
'pubdate' => formatTimestamp($story->published(), 'rss'),
'description' => XoopsLocal::convert_encoding($description)));
}
}
}
$tpl->display('db:news_rss.html', $topicid);
?>

77
Mamba
Re: News 1.67 Final released for XOOPS 2.5.5
  • 2012/7/31 20:04

  • Mamba

  • Moderator

  • Posts: 11275

  • Since: 2004/4/23


Can you change the line:

$tpl->xoops_setCaching(2);

to

$tpl->caching=2;


and see if it makes a difference?

This is the last changed that we've done to this file in Revision 9523, so I am curious if it is causing trouble.

If it still works, try to remove other lines and see which one line is responsible for the problem.
Support XOOPS => DONATE
Use 2.5.10 | Docs | Modules | Bugs

78
panwac
Re: News 1.67 Final released for XOOPS 2.5.5
  • 2012/7/31 21:36

  • panwac

  • Just popping in

  • Posts: 62

  • Since: 2005/11/12


Quote:

Mamba wrote:
Can you change the line:

$tpl->xoops_setCaching(2);

to

$tpl->caching=2;


and see if it makes a difference?

I will try to do it and test tomorrow (it's 23:27 o'clock in my country) - in this moment I'm realy dead after 16 hours spending at work (changes in news templates ), so I haven't a power to do enything except... go to bed.

OT Sorry for my... confused info sending by me from time to time - I'm not a coder (only a webmaster without a solid php bacground), so for me the most important is to have modules working good (not to have "good code"). :)

79
panwac
Re: News 1.67 Final released for XOOPS 2.5.5
  • 2012/8/1 10:42

  • panwac

  • Just popping in

  • Posts: 62

  • Since: 2005/11/12


Mamba,
Line:
$tpl->xoops_setCaching(2);

was changed to
$tpl->caching=2;


and I don't see any differences - an effect is good.

80
Mamba
Re: News 1.67 Final released for XOOPS 2.5.5
  • 2012/8/1 10:44

  • Mamba

  • Moderator

  • Posts: 11275

  • Since: 2004/4/23


Can you do some more tests to see what difference between these two files is causing the problem?
Support XOOPS => DONATE
Use 2.5.10 | Docs | Modules | Bugs

Login

Who's Online

63 user(s) are online (36 user(s) are browsing Support Forums)


Members: 1


Guests: 62


laurawoods,

more...

Donat-O-Meter

Stats
Goal: $100.00
Due Date: Nov 30
Gross Amount: $0.00
Net Balance: $0.00
Left to go: $100.00
Make donations with PayPal!

Latest GitHub Commits