11
Shine
Re: WF-Links 1.09?
  • 2012/6/24 17:56

  • Shine

  • Just can't stay away

  • Posts: 822

  • Since: 2002/7/22


Quote:
Yes, 100%




Latest Beta 1.09: So far so good. Mentioned bugs are solved. Conversion went succesfull!

Suggestion 1:
File: admin/menu.php
deactivate Documentation (prox line 88). Better would be to activate this within the HELP file (language/english/help), under Tutorials/Manual.

Suggestion 2:
File: admin/menu.php
Add menulabel Link management. If you have menulabel 'category management' there shoudl also be seperate 'link management'.

I've done the above. If you want you can download zipfile and replace specific files.
changes/updates for WFlinks 1.09Beta


Grtz., Shine

12
Mamba
Re: WF-Links 1.09?
  • 2012/6/24 20:28

  • Mamba

  • Moderator

  • Posts: 11366

  • Since: 2004/4/23


Excellent idea.

I've merged it into SVN and updated the XOOPS File Repository.

Please download it and check if this is OK.

There are still these error notices in the front, but I'll look later into it:
NoticeUndefined indexextensions in file /class/module.textsanitizer.php line 622
Warning
array_filter() expects parameter 1 to be array, null given in file /class/module.textsanitizer.php line 622
Support XOOPS => DONATE
Use 2.5.10 | Docs | Modules | Bugs

13
Shine
Re: WF-Links 1.09?
  • 2012/6/24 20:54

  • Shine

  • Just can't stay away

  • Posts: 822

  • Since: 2002/7/22


Quote:
Notice: Undefined index: extensions in file /class/module.textsanitizer.php line 622
Warning: array_filter() expects parameter 1 to be array, null given in file /class/module.textsanitizer


I know. But this goes way above my codeskill knowledge unfortunately. Hopefully you can solve it.
Also the -other- famous Xoopstree msg is there:
Quote:
Class 'XoopsTree' is deprecated, check 'XoopsObjectTree' in tree.php

Seems complicated to solve this?? (https://xoops.org/modules/newbb/viewtopic.php?topic_id=72162&forum=75&post_id=332163#forumpost332163 )

Yeah, we are getting around with Mc Donalds WF-Links. Great!

14
Mamba
Re: WF-Links 1.09?
  • 2012/6/24 21:02

  • Mamba

  • Moderator

  • Posts: 11366

  • Since: 2004/4/23


Quote:
Hopefully you can solve it.

I'll look into it when I find some more time.

Quote:
Also the -other- famous Xoopstree msg is there:
Seems complicated to solve this??

I never worked with XoopsTree, so I don't how to do it. If somebody has experience, maybe they could help.
Support XOOPS => DONATE
Use 2.5.10 | Docs | Modules | Bugs

15
Shine
Re: WF-Links 1.09?
  • 2012/6/25 9:17

  • Shine

  • Just can't stay away

  • Posts: 822

  • Since: 2002/7/22


BUG: Screenshot automaticly!

File:
templates/linkload.html
Prox line:28
<{if $wfllink.autoscrshot == 1}> <div> <a href="<{$xoops_url}>/modules/<{$wfllink.module_dir}>/visit.php?cid=<{$wfllink.cid}>&lid=<{$wfllink.id}>" target="_blank"><img src="http://mozshot.nemui.org/shot/128x128?<{$wfllink.url}>" align="right" /></a> </div> <{/if}>

Replace with:
<{if $wfllink.autoscrshot == 1}> <div> <a href="<{$xoops_url}>/modules/<{$wfllink.module_dir}>/visit.php?cid=<{$wfllink.cid}>&lid=<{$wfllink.id}>" target="_blank"><img src="http://open.thumbshots.org/image.pxf?url=<{$wfllink.url}>" align="right" /></a> </div> <{/if}>


16
Mamba
Re: WF-Links 1.09?
  • 2012/6/26 2:19

  • Mamba

  • Moderator

  • Posts: 11366

  • Since: 2004/4/23


NoticeUndefined indexextensions in file /class/module.textsanitizer.php line 622
Warning
array_filter() expects parameter 1 to be array, null given in file /class/module.textsanitizer.php line 622

This was a tricky bug, at least for me!

First, I was looking at the chain of events, trying to figure out what was calling the function executeExtensions, inside which the array_filter was located?

It was:

displayTarea
--> xoopsCodeDecode($text);
------> executeExtensions

I was looking at the parameters of the various displayTarea calls from within WF-Links, like this one:

$link['description2'] = $wfmyts -> displayTarea$link_arr['description'], 1111);

but couldn't find anything wrong.

But in the debugger, I saw that the value for $this->config['extensions'] was null:

$this->config['extensions'] = null

I compared a similar call to displayTarea in xForms,

$xoopsTpl->assign('forms_intro'$myts->displayTarea($xoopsModuleConfig['intro']));

and it was:

$this->config['extensions'] = {array}[11]
iframe 0
image
1
flash 
1
youtube 
1
mp3 
0
wmp 
0
wiki 
false
mms 
0
rtsp 
0
ul 
0
li 
0

So something was wrong with our $wfmyts.

WF-Links, the same as XoopsTube, is extending MyTextSanitizer in /class/myts_extended.php

class wflTextSanitizer extends MyTextSanitizer
{
    function 
wflTextSanitizer() {
    } 
    function 
htmlSpecialCharsStrip$text )
    {
        return 
$this -> htmlSpecialChars$this -> stripSlashesGPC$text) );
    } 
}

Now the question, what is wrong with it, and what consequences does it have?

I realized that the function

function wflTextSanitizer() {
    }

was overriding the original construction method of MyTextSanitizer:

function __construct()
    {
        
$this->path_basic XOOPS_ROOT_PATH '/class/textsanitizer';
        
$this->path_plugin XOOPS_ROOT_PATH '/Frameworks/textsanitizer';
        
$this->config $this->loadConfig();
    }

and as a result the "$this->loadConfig()", which was loading the extensions, was never executed.

After removing it, all the errors related to "Undefined index: extensions" are gone.
Support XOOPS => DONATE
Use 2.5.10 | Docs | Modules | Bugs

17
Mamba
Re: WF-Links 1.09?
  • 2012/6/26 2:41

  • Mamba

  • Moderator

  • Posts: 11366

  • Since: 2004/4/23


Quote:
BUG: Screenshot automaticly!

Thanks, Shine. It's now in XOOPS SVN.

I also changed the Editor to a dynamic list, instead of hard coded, as it was before. I need to do more tests on this.
Support XOOPS => DONATE
Use 2.5.10 | Docs | Modules | Bugs

Login

Who's Online

164 user(s) are online (110 user(s) are browsing Support Forums)


Members: 0


Guests: 164


more...

Donat-O-Meter

Stats
Goal: $100.00
Due Date: Apr 30
Gross Amount: $0.00
Net Balance: $0.00
Left to go: $100.00
Make donations with PayPal!

Latest GitHub Commits