1
wishcraft
Merger header bug (Core Error)

I am not sure what this feature is but i wish it was turned off by default, as it is erroring my HTML on http://www.istreamtv.co.nz. I spoke with trabis who said the passkey system i was doing on flowplayer needed to be with sessions to support it but I have done that and it IS STILL CAUSING CORRUPT THE HTML.

Whomever thought headers need to be merged is a fool and daft, it is just corrupting all the HTML the smarty cache puts out.

For example if you look at the HTML on istreamtv.co.nz you will see this line repeat 3 times which loads once from a block. where i seem to have reported a MAJOR Error and snooty nosed off cause people are too good at introducing flaws.

<script type="text/javascript">
//dojson_player("http://www.istreamtv.co.nz","flowplayer","player_block_one");
//]]>


You will see this line repeat 3 times which is loaded once from a preloader.

<script type="text/javascript">
//  var _gaq _gaq || [];
  
_gaq.push(['_setAccount''UA-26507006-1']);
  
_gaq.push(['_setDomainName''none']);
  
_gaq.push(['_setAllowLinker'true]);
  
_gaq.push(['_trackPageview']);

  (function() {
    var 
ga document.createElement('script'); ga.type 'text/javascript'ga.async true;
    
ga.src = ('https:' == document.location.protocol 'https://ssl' 'http://www') + '.google-analytics.com/ga.js';
    var 
document.getElementsByTagName('script')[0]; s.parentNode.insertBefore(gas);
  })();
//]]>
Resized Image
http://www.ohloh.net/accounts/226400

Follow, Like & Read:-

twitter.com/RegaltyFamily
github.com/Chronolabs-Cooperative
facebook.com/DrAntonyRoberts

2
trabis
Re: Merger header bug (Core Error)
  • 2011/12/6 0:35

  • trabis

  • Core Developer

  • Posts: 2269

  • Since: 2006/9/1 1


Please replace class/theme.php method:
public function addMeta($type 'meta'$name ''$value '')
    {
        if (!isset(
$this->metas[$type])) {
            
$this->metas[$type] = array();
        }
        if (!empty(
$name)) {
            
$this->metas[$type][$name] = $value;
        } else {
            
$this->metas[$type][md5(serialize(array($value)))] = $value;
        }
        return 
$value;
    }


If it works for you, I'll commit it on 2.5.5 SVN.

And please don't call me a fool. Headers need to be cached to allow cached pages to use css and js. Headers need to be merged to allow blocks adding css and js to the cached pages.

The problem here is that addScript('', '', 'content here') has not a unique identifier.

3
wishcraft
Re: Merger header bug (Core Error)

Sorry trabis, as you know I can be a lot harsher, it just I have been speaking to you about this error for 3 weeks now. Anyway, that seem to fix it thanks. I am just a bit frustrated at the moment as I have been working on this IPTV site for sometime now and it was another flaw thats all. I hope you can accept my appologies.

Simon
Resized Image
http://www.ohloh.net/accounts/226400

Follow, Like & Read:-

twitter.com/RegaltyFamily
github.com/Chronolabs-Cooperative
facebook.com/DrAntonyRoberts

4
trabis
Re: Merger header bug (Core Error)
  • 2011/12/6 1:00

  • trabis

  • Core Developer

  • Posts: 2269

  • Since: 2006/9/1 1


No problem, we're good :)

Login

Who's Online

375 user(s) are online (102 user(s) are browsing Support Forums)


Members: 0


Guests: 375


more...

Donat-O-Meter

Stats
Goal: $100.00
Due Date: Oct 31
Gross Amount: $0.00
Net Balance: $0.00
Left to go: $100.00
Make donations with PayPal!

Latest GitHub Commits