I'm testing this module for a site based on xoops 2.5 and I've had some problem using the menu (main menu basic skin) because links were not highlighted when using friendly url or in general htaccess redirect.
This was a limit due to the $menu.selected/$menu.topselected variable which is builded php side and need to be equal to the exact server request.. so if you have yoursite/module/news redirected to yoursite/articles the link won't be highlighted when your are in the page linked by menu

A working solution to me is using smarty to do the trick.. because that way even if the server request is redirected by htaccess you can have highlighted links:

in mymenus\skins\mainmenu\templates\template.html
changed in line 4

to

and in line 11 from

<a class="menuSub <{if $sub.selected}>maincurrent<{/if}>"

to

<a class="menuSub <{if stristr($sub.link,$smarty.server.REQUEST_URI)}>maincurrent<{/if}>"

I know I could use $xoops_requesturi instead of $smarty.server.REQUEST_URI.. but in xoops 2.5 does not print anything to me, even if shown in smarty debug

May be it not 'clean' but that way I'm having current link highlighted always and without issues
probably this method can be used with all skin of the module (and may be in all templates generating menus..)
let me know your opinion

Ian

class/builder.php


Mymenus will not highlight the exact match, it will highlight the closest match. If $self is not holding the correct value then maybe you could find a way to fix, that would avoid touching templates and closest match would still work.

Your fix does not support closest match.

Hi Trabis,
I'm not a php programmer.. but to me the matching was kind of buggy and was working only if using a clean url such:
modules/news

inserting the complete url http://www. mysite.com/modules/news
was not working and if there's an url rewrite I have to write the original url in the menu link field to have the match.. but this can be a contraddiction for seo purposes

I guess smarty solution don't give me problem because smarty works after php.. but this solve also asmall bug:
- when browsing in page not linked in the mymenus block, where the block is visibile I've the top link always highlighted

If there's a php solution allowing for rewrited url it would be obviously better

thanks
Ian

Hi guys,

I'm using MyMenus 1.1 and XOOPS 2.5.6. I can't figure out how to get the current page link to highlight. I've tried setting CSS info in the links, but it has no effect on the appearance of the menu - no highlighting. I tried the hack that ianez showed below, but nothing changes.

Any ideas?

Cheers,

- b -