XOOPS 
Forum
Forum Index General Forums Community Support Modules Support Themes Support Development International Support Module Hack Reviews Theme Designer Talk
  1. Board index / 
  2. XOOPS Community Support forums / 
  3. 2.4.x Support 
  4.  / Bug in imagemanager in 2.4.4 and 2.4.5
Register
1
Fabrice
Bug in imagemanager in 2.4.4 and 2.4.5

  • 2010/7/18 12:22

  • Fabrice

  • Just popping in

  • Posts: 5

  • Since: 2010/4/3 1


This bug is still present in Xoops 2.4.5.

I think it's due to Smarty
Quote:

Parse error: syntax error, unexpected T_STRING, expecting ',' or ';' in http%253A%252F%252Fwww.chtiland.com%252Fv5%25%25system-chtiland-chtiland^%%5D^5DD^5DDC7D64%%db%3Asystem_imagemanager.html.php on line 54


This line looks like this

<?php $language = $GLOBALS['xoopsConfig']['language']; if(file_exists(XOOPS_ROOT_PATH.'/language/'.$language.'/style.css')){ echo "<link rel="stylesheet" type="text/css" media="all" href="language/$language/style.css" />"; }


Each time I empty smarty_cache, i must correct this line like this :

<?php $language = $GLOBALS['xoopsConfig']['language']; if(file_exists(XOOPS_ROOT_PATH.'/language/'.$language.'/style.css')){ echo '<link rel="stylesheet" type="text/css" media="all" href="language/'.$language.'/style.css" />'; }


Then everything works.

Where should i made change to well generate this file ?

Thanks.
2
iHackCode
Re: Bug in imagemanager in 2.4.4 and 2.4.5

location: htdocs/modules/system/templates/system_imagemanager.html

you will probably have to update the system module for it to reload the template files.


Also i've submitted it to the bug tracker
https://sourceforge.net/tracker/?func=detail&aid=3031264&group_id=41586&atid=430840
CBB / LatestNews / Publisher / XM-Spotlight

(ﾉ◕ヮ◕)ﾉ*:･ﾟ✧
3
P3DI
Re: Bug in imagemanager in 2.4.4 and 2.4.5

  • 2010/9/18 16:39

  • P3DI

  • Just popping in

  • Posts: 7

  • Since: 2010/9/14


Has anyone found a workable solution for this? I am getting the same error when opening image manager.
I have tried changing the string of code in the file htdocs/modules/system/templates/system_imagemanager.html to the same as posted above and then updated system module from admin but without any luck.

Any ideas?
4
trabis
Re: Bug in imagemanager in 2.4.4 and 2.4.5

  • 2010/9/18 19:25

  • trabis

  • Core Developer

  • Posts: 2269

  • Since: 2006/9/1 1


Try clean smarty compiles.

I have tested it under 2.5 and could not reproduce it. If this problem affects only 2.4.5 then it wont be fixed.
5
ghia
Re: Bug in imagemanager in 2.4.4 and 2.4.5

  • 2010/9/19 5:30

  • ghia

  • Community Support Member

  • Posts: 4953

  • Since: 2008/7/3 1


It is probably some special use case, where some PHP or server settings may invoke the problem.
As the code is also present in that template for 2.5, similar complaints may be expected.
It can be easy changed:
echo "<link rel="stylesheet" type="text/css" media="all" href="language/$language/style.css" />";
=>
echo '<link rel="stylesheet" type="text/css" media="all" href="language/'.$language.'/style.css" />';

6
P3DI
Re: Bug in imagemanager in 2.4.4 and 2.4.5

  • 2010/9/19 15:40

  • P3DI

  • Just popping in

  • Posts: 7

  • Since: 2010/9/14


Thanks trabis and ghia, by editing the file directly in smarty_compile like Fabrice posted, image manager works fine.

However, when making the corrections to the file

htdocs/modules/system/templates/system_imagemanager.html,

I still get the same error even after cleaning cache files and updating system module.

I have version 2.4.5 on a linux server running PHP 4.4.9. I have had other issues with not having a higher version of PHP, could this also be part of my problem?

7
trabis
Re: Bug in imagemanager in 2.4.4 and 2.4.5

  • 2010/9/19 17:35

  • trabis

  • Core Developer

  • Posts: 2269

  • Since: 2006/9/1 1


Quote:

P3DI wrote:
However, when making the corrections to the file

htdocs/modules/system/templates/system_imagemanager.html,

I still get the same error even after cleaning cache files and updating system module.



Are you using default template set or a custom one?
Does your theme has a modules/system/system_imagemanager.html file?
Are you using a system manager module using preloads?

8
P3DI
Re: Bug in imagemanager in 2.4.4 and 2.4.5

  • 2010/9/19 18:15

  • P3DI

  • Just popping in

  • Posts: 7

  • Since: 2010/9/14


Thanks for responding so quickly.

Customized default template, mainly changes to the style.css file and a few other minor mods.

Yes, my system has system_imagemanager.html, file path is:

modules/system/templates/system_imagemanager.html

I am not using a system manager module with preloads, my system module is the default module, no mods.
9
ghia
Re: Bug in imagemanager in 2.4.4 and 2.4.5

  • 2010/9/20 5:05

  • ghia

  • Community Support Member

  • Posts: 4953

  • Since: 2008/7/3 1


Check also for theme overloading: /themes/yourtheme/modules/system/templates/system_imagemanager.html
10
P3DI
Re: Bug in imagemanager in 2.4.4 and 2.4.5

  • 2010/9/20 13:08

  • P3DI

  • Just popping in

  • Posts: 7

  • Since: 2010/9/14


Sorry ghia, that is not my case, my directory is:

/themes/mytheme/modules/system (no templates) and includes only the files index.html, system_redirect.html and system_siteclosed.html
(1) 2 »

Login

Register now!  |  Lost Password?

Search

Advanced Search

Recent Posts

Donat-O-Meter

Stats
Goal: $15.00
Due Date: Aug 31
Gross Amount: $0.00
Net Balance: $0.00
Left to go: $15.00
Make donations with PayPal!