If you have a form with a select box and you set it to true for validation it does not work. I found this with all Xoops versions. My modules need it to work right so here is what I found.

It is in the function renderValidationJS

here is the function from version 2.4.4


function renderValidationJS()
{
// render custom validation code if any
if (! empty($this->customValidationCode)) {
return implode("\n", $this->customValidationCode);
// generate validation code if required
} elseif ($this->isRequired()) {
$eltname = $this->getName();
$eltcaption = $this->getCaption();
$eltmsg = empty($eltcaption) ? sprintf(_FORM_ENTER, $eltname) : sprintf(_FORM_ENTER, $eltcaption);
$eltmsg = str_replace('"', '"', stripslashes($eltmsg));
return "\nvar hasSelected = false; var selectBox = myform.{$eltname};" . "for (i = 0; i < selectBox.options.length; i++ ) { if (selectBox.options[i].selected == true) { hasSelected = true; break; } }" . "if (!hasSelected) { window.alert("{$eltmsg}"); selectBox.focus(); return false; }";
}
return '';
}



I changed it to:


function renderValidationJS()
{
// render custom validation code if any
if (! empty($this->customValidationCode)) {
return implode("\n", $this->customValidationCode);
// generate validation code if required
} elseif ($this->isRequired()) {
$eltname = $this->getName();
$eltcaption = $this->getCaption();
$eltmsg = empty($eltcaption) ? sprintf(_FORM_ENTER, $eltname) : sprintf(_FORM_ENTER, $eltcaption);
$eltmsg = str_replace('"', '"', stripslashes($eltmsg));
return "\nvar hasSelected = false; var selectBox = myform.{$eltname};" . "for (i = 0; i < selectBox.options.length; i++ ) { if (selectBox.value != "") { hasSelected = true; break; } }" . "if (!hasSelected) { window.alert("{$eltmsg}"); selectBox.focus(); return false; }";
}
return '';
}


Now it will work correctly.

I have included this file (for each Xoops Version) with the changes, in my Jobs and Classified modules.

Maybe this is not the best way to change this, but it works.

Thanks,

John

Hi John,

I too reported this problem in this post.

In my experience it affects DHTML text area too?.

I simply commented-out the JS code and everything works, so I am wondering that by adding code to every class it conflicts with the validation code in the main xoops form class.

If this is a bug, I would welcome a confirmation and an official 'fix' so I can alert module users that they need to change those Xoops core files.

Peekay,

How are you.

I have not had the problem for dhtml text area, just the select boxes in my modules.

But if commenting them out works, then that means it is done somewhere else, probably formelement.php. No need to do it twice, is there?

But we do need an official fix, either by removing it from some files or fixing it like I did for formselect.php.

Thanks,

John

Bump. Can anyone from the core team take a look at this?

I will bump this back out. I hope someone will point this out to the core team.

Thank You,

John

Reported in tracker

The best way is always to report it in Source Forge Tracker, with link to the Forum discussion

This code works:


I assume that you are using select box with 1 field height, in that case the current field is marked as selected(by the browser I guess) and will always pass validation.

I assume you are using something like ''=> 'Select a field';
Notice that your solution will also fail validation if the first option is not empty. Example:('field_0'=>'Yes', 'field_1'=>'No')

I would prefer not changing core. You could change the size of the select box, just make it > 1;

Regarding the DhtmlTextArea, it should be fixed in 2.5 now.

I've created a testform.php in the root of my Xoops Instalation. Here is the code I used:

Hello,

To solve the problem in checkbox validation with a single option, you must modify the file formcheckbox.php located in the / root / class / xoopsform directory.

We must replace the line 241 (in the XOOPS version 2.5.0) that contains:

by


This is because if there is only one option the element is not an array.
We must first check if the length is not null to determinate if there is only one or more options in the checkbox.

Satrebil
(Excuse me for my english)

Please read whole post.

This post was originally about select boxes not checkboxes. But they both seem to have this problem.

First I never said my fix was the right fix, it just works for my modules.

Ghia wrote

Quote:

First, Why would you not want to fix the core? Shouldn't it work under any circumstance?

Second, No I can't change the size of the select box.

It would be better if the core was changed to fit all uses. I would prefer that I and users of my module not have to change the core, the core team should change the core.



Peekay says that if you remove that code all together it works correctly. How can that be? There must be double code. MAYBE that is where the core team should look. But this has never worked in any version of Xoops, so I think it is time to fix this.



Satrebil has found the same problem with checkboxes, Please fix the core!



Thanks,

John