XOOPS 
Forum
Forum Index General Forums Community Support Modules Support Themes Support Development International Support Module Hack Reviews Theme Designer Talk
  1. Board index / 
  2. XOOPS Themes and Templates Support forums / 
  3. Website reviews of Xoops sites 
  4.  / My 2nd theme, let me know what you think
Register
11
ghia
Re: My 2nd theme, let me know what you think

  • 2010/2/15 0:53

  • ghia

  • Community Support Member

  • Posts: 4953

  • Since: 2008/7/3 1


See also this.
12
mjoel
Re: My 2nd theme, let me know what you think

  • 2010/2/15 3:20

  • mjoel

  • Quite a regular

  • Posts: 325

  • Since: 2006/12/9


Deka87.......

nice simple theme....

it will be better if you include a username title tooltip to identify who is the user behind all the avatar

13
deka87
Re: My 2nd theme, let me know what you think

  • 2010/2/15 5:54

  • deka87

  • Friend of XOOPS

  • Posts: 1125

  • Since: 2007/10/5


Quote:
it will be better if you include a username title tooltip to identify who is the user behind all the avatar


well you're totally right! that's much better. the new code with tooltips is like this:

global $xoopsDB;  
$sql = "SELECT u.uid, u.user_avatar, u.uname  FROM ".$xoopsDB->prefix("users")." u, ".$xoopsDB->prefix("groups_users_link")." g, ".$xoopsDB->prefix("profile_profile")." p WHERE u.uid = g.uid AND u.uid = p.profile_id AND u.level > 0 AND user_avatar <> 'blank.gif' AND u.uid NOT IN (1) ORDER BY RAND()";  
$result = $xoopsDB->query($sql, 45);    
while (list($uid, $user_avatar, $uname) = $xoopsDB->fetchRow($result))    
{    
    echo '. XOOPS_URL . '/userinfo.php?uid=' . $uid . '" title="' . $uname . '">. XOOPS_URL . '/uploads/' . $user_avatar . '" alt="Avatar" height="30" width="30"/>
';
}
echo '






';


Quote:

See also this.


you've got a good memory mate the code credits go to ghia that's no doubt im not a php coder in any way


14
aph3x
Re: My 2nd theme, let me know what you think

  • 2010/3/22 15:32

  • aph3x

  • Theme Designer

  • Posts: 834

  • Since: 2004/12/26


Can i make 2 suggestions?

Replace the br / tags with a div which height should be the sum of those br / . Dont get me wrong is fine like that too, but there's nothing elegant in a duplicated code x7

Also align="something" is bound to become obsolete with HTML5 as its deprecated code not W3C standard, use text-align: within the given style and play more with the padding, that should remove the need to use align tag

So please don't get me wrong, I'm not criticizing ..I'm merely show alternate option to make your code better :)
15
deka87
Re: My 2nd theme, let me know what you think

  • 2010/3/22 16:10

  • deka87

  • Friend of XOOPS

  • Posts: 1125

  • Since: 2007/10/5


aph3x, you're like a debugger, one can't be mad at a debugger haha. criticism is always for good. if you could say anything bad about the website itself i'd be only grateful.
« 1 (2)

Login

Register now!  |  Lost Password?

Search

Advanced Search

Recent Posts

Who's Online

329 user(s) are online (254 user(s) are browsing Support Forums)

Members: 0

Guests: 329

more...

Donat-O-Meter

Stats
Goal: $100.00
Due Date: Nov 30
Gross Amount: $0.00
Net Balance: $0.00
Left to go: $100.00
Make donations with PayPal!

Latest GitHub Commits