XOOPS 
Forum
Forum Index General Forums Community Support Modules Support Themes Support Development International Support Module Hack Reviews Theme Designer Talk
  1. Board index / 
  2. Xoops Development / 
  3. Xoops Bug Reports 
  4.  / Profile Module - Website Row is displayed even value is empty
Register
1
maxxy
Profile Module - Website Row is displayed even value is empty

  • 2009/12/29 6:07

  • maxxy

  • Quite a regular

  • Posts: 286

  • Since: 2007/6/11


xoops 2.42

the website row in template is displayed even when the url value is empty

should be hidden if the value is empty ..just like other field....

demo: https://xoops.org/modules/profile/userinfo.php?uid=62978

look at the website row..displayed even when its empty

any quick fix ?



is this related ? or had not yet been fixed

https://sourceforge.net/tracker/?func=detail&aid=1847253&group_id=41586&atid=430840

2
ghia
Re: Profile Module - Website Row is displayed even value is empty

  • 2009/12/29 11:32

  • ghia

  • Community Support Member

  • Posts: 4953

  • Since: 2008/7/3 1


The fix is in the PHP code of 2.4.x, but if you want the suppression of empty websites, you must alter your template /modules/system/templates/user_info.html as in the first example.
<{if $user_websiteurl != ""}>
<tr>
<td class="head"><{$lang_website}></td>
<td class="even"><{$user_websiteurl}></td>
</tr>
<{/if}>
3
maxxy
Re: Profile Module - Website Row is displayed even value is empty

  • 2009/12/29 13:13

  • maxxy

  • Quite a regular

  • Posts: 286

  • Since: 2007/6/11


i'm using profile module - modules/profiles
that does not fix it

any other suggestion ?

4
maxxy
Re: Profile Module - Website Row is displayed even value is empty

  • 2009/12/30 4:40

  • maxxy

  • Quite a regular

  • Posts: 286

  • Since: 2007/6/11


anyone ?

had this same problem last without the profile module

https://xoops.org/modules/newbb/viewtopic.php?topic_id=59901&forum=5&post_id=276823#forumpost276823


Fixed by dugris in 2.018.1
http://xoops.svn.sourceforge.net/viewvc/xoops?view=rev&revision=1246


not sure if this really has been fixed ?


right now using profile module
5
trabis
Re: Profile Module - Website Row is displayed even value is empty

  • 2009/12/30 14:06

  • trabis

  • Core Developer

  • Posts: 2269

  • Since: 2006/9/1 1


Can you try this on class/field.php line 247
switch ($this->getVar('field_type')  ) {
            default:
            case "textbox":
                if ( $this->getVar('field_name') == 'url' && $value != '') {
                     return '<a href="' . formatURL($value) . '" rel="external">' . $value . '</a>';
                   } else {
                     return $value;
                }
                break;
6
maxxy
Re: Profile Module - Website Row is displayed even value is empty

  • 2009/12/30 14:49

  • maxxy

  • Quite a regular

  • Posts: 286

  • Since: 2007/6/11


Thank you..yes it works


hope this change can be commit to svn

can the mode help to change the title to Fixed

7
Mamba
Re: Profile Module - Website Row is displayed even value is empty

  • 2009/12/30 23:33

  • Mamba

  • Moderator

  • Posts: 11545

  • Since: 2004/4/23


Quote:
hope this change can be commit to svn
It is now

Login

Register now!  |  Lost Password?

Search

Advanced Search

Recent Posts

Donat-O-Meter

Stats
Goal: $15.00
Due Date: Sep 30
Gross Amount: $0.00
Net Balance: $0.00
Left to go: $15.00
Make donations with PayPal!