One thing I noticed about the Criteria class suite is that it has incomplete support for the order and limit functions of SQL. It has properties for these syntax elements but they don't render.

-- SAMPLE DELETED BY AUTHOR --

I originally modified the Criteria objects before fully understanding their implmentation in XOOPS. Since there are rationale (if not an absolute requirement) for separating the limit and sort fields in XOOPS you can't really do that.

So I have written an extension class for CriteriaCompo that effects the same thing. Note that I am working in PHP 5.0 and so have not tested this on 4.x platforms.

Note also that this will cascade functionally to renderWhere() and renderLdap() execution. As I am not Ldap-educated I can't really say how appropriate this is.

For core patches, plz submit to
http://sourceforge.net/tracker/?group_id=41586&atid=430842

or discuss at
http://sourceforge.net/forum/forum.php?forum_id=347994

Since this subject has already been brought up here, I'll add another comment.

Another restriction of the Critera class is that it doesn't allow multiple specifications for the ORDER BY clause. For example: "ORDER BY col1 ASC, col2 DESC"

Maybe bingomanatee's patch addresses that, but it doesn't look like it.

This could be handled by changing

var $order = 'ASC';
var $sort = '';

to an array:

var $order_by = array();

The elements of the array would each be two-element arrays. The example "ORDER BY col1 ASC, col2 DESC" would be represented as:

$order_by = array(
array('col_name' => 'col1', 'asc' => true),
array('col_name' => 'col2', 'asc' => false),
);

If the new variable $order_by is added, and the old variables $order and $sort kept, downward-compatibility could be achieved.