ghia,

indeed I did. I could see in the page source the label tags but didn't know about the change in 2.4 that caused this effect. I chose your second option, adding the code below the existing label selector and it works fine now. Once again, I am in your debt.

Incidentally, you probably saw my question about the * caption marker appearing for every element in the form. As I said, I saw your post some days ago about this on the XOOPS site. Can you make any comment about it relevant to these forms in bbedit, etc? Where in the CSS would the code you suggested be placed?

barryc

Quote:

What theme are you using? As I said above, I am using a slightly modified version of Kris's zen-ocean. You can see the effect by looking at www.aka.org. Just start a post and you'll see it but you'd have to register to do so.

Here is an image showing the effect




I am still trying to figure out why this is happening. Obviously a line feed is being inserted after every radio button and message icon and it must be a problem with the theme CSS. However, so far I haven't been able to find identifiers in the theme corresponding to these elements.

Again, if anyone can point to where the problem might lie, I'd truly appreciate it.

Also, the required caption marker is being inserted for every element in the form. Ghia posted some code recently related to this problem on the XOOPS site. However, I was not sure where to place that code in my theme. Ghia, if you see this?

barryc

I'm not sure if this is the best place to post this, rather than the modules forums. I have just updated my site to 2.4.2. I notice that now the forum icons that appear above the text box when posting a message are arranged vertically rather than horizontally. This is unattractive and a waste of screen space. This seems to be a consequence of the upgrade. Is there a way to either rearrange or eliminate those icons? There must be a way to rearrange them because I notice they are horizontal above this window.

[Edit] OK, it just occurred to me that this might be a theme problem, and it is. If I use a different theme the icons are horizontal. I'll have to look closely at the theme I use as the default (zen-ocean). Of course, if any of you CSS experts out there can quickly see the problem, I'd appreciate your advice.

barryc

Mamba,

I saw that and downloaded the upgrade packages for 2.3.3 to 2.4.2 and 2.4.1 to 2.4.2. I ran the latter, for which, apparently, no upgrade folder needs to be accessed after copying the files. Should that be mentioned in the readme?

Should include/license.php be set back to 444?

barryc

Thanks for that news. I was wondering about that because there was mention of the 2.4.2 version coming soon. I'll hold off a day or two.

Occasionally my stumbles reveal a genuine problem. More often they are just my stumbles.

barryc

Mamba,

I really appreciate you taking the time to look at this. It did not occur to me to check the permissions because they were previously set correctly to 777 and are so set on my live site. This test site is essentially a duplicate, although there are modules installed that I'm just testing.

I think what might have happened is this: The first time I tried to upgrade I made a mistake in the use of my FTP client (clicked the wrong button), which caused some of the files that were not being updated to be deleted. I therefore copied over all the original files from backup, then tried again. I think that the xoops_cache/caches permissions were changed in the backup file, something I didn't expect. I checked that file, which I still have, and indeed they are set to 755. So, I learned not to assume that files in a backup are set as in the originals.

Once again, thanks.

barryc

Mamba,

To access the admin pages at all I had to "break" protector by renaming its dir. I then updated the system module and cleared the smarty_compile cache. I decided I would uninstall protector then install it again after having done the update. I can't reinstall it because it does not appear in the list of uninstalled modules. I see that same Fatal error message. Error reporting is turned on on the site.

I sent you a PM with info to log on by FTP and to the site as admin.

I'll be going out for most of today but will check in this evening when I get home. If necessary, I can restore the 2.3.3 site, although that may now be difficult after having done the system update as I assume that changes the db.

I look forward to your comments.

barryC

Well, I found the readme in xoops_lib/modules/protector and that makes it clear that you need all the files in both the /modules/protector and xoops_lib/modules/protector dirs. So, I uploaded the complete /modules/protector files and once again got the original error. I looked again at my mainfile.php and found that the last several lines are like this:



I was under the impression that the precheck and postcheck has been removed for Protector under 2.3.3 but I am probably wrong about that. I tried deleting these lines, leaving



intact. However, I still get the error.

I could give you ftp access to this installation if that would help and I can give you temporary admin access to this test site. I keep it for just these kind of issues, so that I don't screw up my live site before I work out problems.

I'll have to get back to this tomorrow. Got to get up early.

barryC

Mamba,

I think we are talking at cross purposes. I understood the comments in the readme about not duplicating the xoops_lib dir and copying the files in the upgrade package from xoops-lib into the corresponding dir on the server, which in my case is outside the server root, as recommended, as well as having a modified name.

The problem is that one is told to upload the files in the upgrade package to the server, overwriting the corresponding files that are already there. My 2.3.3 XOOPS installation was running Protector 3.2.2. The files for that were in the /modules/protector dir.

In the upgrade package there are a small number of files in the htdocs/modules/protector dir. Those got copied to the /modules dir on my server. This left quite a few other files already in that dir intact. There is a folder xoops_lib/modules/protector in the upgrade package. That got copied to my trust path dir (i.e. my name modified xoops-lib dir, above the server root).

These are the dirs and files that are in /modules/protector now. Note there is a folder preload (which I think is from the 2.3.3 version and another called preloads, from 2.4.1. I suspect that one should replace the modules/protector folder with the one in htdocs/modules/protector, deleting the other files. A number of these are duplicated in xoops_lib/modules/protector.

/modules/protector/admin/
/modules/protector/blocks/
/modules/protector/images/
/aka/modules/protector/index.css
/modules/protector/index.php
/modules/protector/module_icon.php
/modules/protector/mytrustdirname.php
/modules/protector/notification_update.php
/modules/protector/notification.php
/modules/protector/oninstall.php
/modules/protector/onuninstall.php
/modules/protector/onupdate.php
/modules/protector/preload
modules/protector/preloads
/modules/protector/search.php
/modules/protector/xoops_version.php

In other words, I am not clear what files the /modules/protector dir should contain and what should be in xoops_lib/modules/protector. Hopefully you can straighten me out on that.

The point I was trying to make about the readme was meant to cover this situation.

Sorry for the long post but I hope it explains my dilemma.

barryC

OK, I was careful not to end up with two xoops_lib dirs. I did not have two trust path dirs, or at least not two copies of xoops_lib, but the Protector module was already installed in my 2.3.3 version in the regular modules dir. The upgrade to 2.4.1 has a dir for protector in xoops_lib/modules. I assume that is where it is meant to be installed in 2.4.1? I saw that but did not realize that it constituted a duplicate copy.

I changed the name of the protector dir in the regular modules dir to test this and now I can see the admin pages. However, this obviously isn't right because I see the message module file protector not found. I suspect that the /modules/protector dir should only contain the files in the upgrade package and that the rest of the protector module files reside in /xoops_lib/modules/protector. Is that right? If not, please advise me.

I think this is really confusing. Surely the upgrade readme should say something about how to deal with the Protector module if it is already installed in the modules dir, other than removing those precheck/postcheck lines, that is?

Right now I have all the original protector files in the "old" modules/protector dir, with the new files in the upgrade having overwritten the corresponding old file, or having been added. What should I do now?

The other thing that is worth mentioning is that the readme states that include/license.php should be set to 777 if upgrading from 2.4.0. That implies that you don't have to change the perms if upgrading from 2.3.x. In my case, after copying the files, license.php was set to 644. Should it be left that way or set to 777?

barryC