51
reynaldo
Re: FAQ problem (strange URL)
  • 2004/3/1 10:18

  • reynaldo

  • Not too shy to talk

  • Posts: 106

  • Since: 2004/2/13


Quote:

Mikhail Miguel wrote:
hum... there some problems with pmlite.php and readmsg.php (without ".XOOPS_URL."/ or something)


Hey,
I found a quickfix for this error, but I don't like quickfixes. When I started coding ShortUrls, I didn't know Urls like
http://www.domain.com/readpmsg.php?start=0&total_messages=1&PHPSESSID=4500f8ec8e0e17a704b4533aab2cb5e3
could exists. What I mean is, urls with scripts running from the Xoop root dir and with more than 2 parameters.

I think the best way to go is to once more slightly modify the way ShortUrls works in the following way:
1) URLs like:
/modules/newbb/viewtopic.php?topic_id=1&forum=1&post_id=1#forumpost1
Will become:
m-newbb-viewtopic+topic_id-1-forum-1-post_id-1.html#forumpost1
(note the '+' (plus) sign separating files from parameters, and that modules folder is now referred as 'm')

2) URLs in the root, as
/readpmsg.php?start=0&total_messages=1&PHPSESSID=4500f8ec8e0e17a704b4533aab2cb5e3
will become:
/readpmsg+start-0-total_messages-1-PHPSESSID-4500f8ec8e0e17a704b4533aab2cb5e3.html

I would like to know the opinion of each one of you who have been testing ShortURLs and helping me debug it. I think this change is necessary to allow ShortURLs have greater compatibility with current version of XOOPS and with a newer version whenever it is released.



52
reynaldo
Re: FAQ problem (strange URL)
  • 2004/3/1 4:09

  • reynaldo

  • Not too shy to talk

  • Posts: 106

  • Since: 2004/2/13


Hey:

Found a fix for this bug. But i'm a little tired and I would like to confirm I am not breaking anything else

I'll take a look again in the morning and post the revised solution. Night!



53
reynaldo
Re: FAQ problem (strange URL)
  • 2004/3/1 3:45

  • reynaldo

  • Not too shy to talk

  • Posts: 106

  • Since: 2004/2/13


Quote:

Mikhail Miguel wrote:
hum... there some problems with pmlite.php and readmsg.php (without ".XOOPS_URL."/ or something)


Checking....



54
reynaldo
Re: FAQ problem (strange URL)
  • 2004/3/1 3:25

  • reynaldo

  • Not too shy to talk

  • Posts: 106

  • Since: 2004/2/13


Hey!

Last fix is posted at
http://www.wtmmail.com/XoopsShortUrls/xoops_shorturls.txt5

I addressed latest bugs and it seems to be working fine, test it in yours and let me know how it goes



55
reynaldo
Re: FAQ problem (strange URL)
  • 2004/3/1 1:53

  • reynaldo

  • Not too shy to talk

  • Posts: 106

  • Since: 2004/2/13


Quote:

Koreus wrote:

Go there :http://test.koreus.com/xoopsfaq-index-cat_id-2.html#q5

And goes to the 2nd line of the page, you should see this :
»» Le Site
Intead of this :
Principale »» Le Site


This is not an error or bug, this is they way Within-page links work
For example, go to
https://xoops.org/modules/newbb/viewtopic.php?topic_id=16663&forum=14&post_id=72629#forumpost72629

You will see that insted of the page opening and staying on top, it will inmediately scroll to post #72629

Quote:

Now look at the link, weird isn't it ?
http://test.koreus.com/modules/xoopsfaq/index.php%3EPrincipale%3C/a%3E%A0%3Cspan%20style=

Instead of :
http://test.koreus.com/modules/xoopsfaq/index.php

This one IS a bug I'll take a look at it. It seems I broke something while trying to fix compatibility problems with myAds




56
reynaldo
Re: Latest fix
  • 2004/2/29 11:44

  • reynaldo

  • Not too shy to talk

  • Posts: 106

  • Since: 2004/2/13


Alexon:

Thank you for reporting.
Yes, those bugs have been fixed.
Use the last *test* version at:
http://www.wtmmail.com/XoopsShortUrls/xoops_shorturls.txt4

Just download that text file, rename it to xoops_shorturls.php and overwrite the distribution version with it.

By the way, thanks for the checklink page, I'm using it right now



57
reynaldo
Re: Latest fix
  • 2004/2/29 11:19

  • reynaldo

  • Not too shy to talk

  • Posts: 106

  • Since: 2004/2/13


Guys, I taking the day off, if you would like to try the next fix, go ahead and download it here:

http://www.wtmmail.com/XoopsShortUrls/xoops_shorturls.txt4

I've fixed a few module specific errors, most of them, image related.

I can't repeat enough: this is a test version and it is not supposed to be used in a live unmonitored site. If you have errors, revert to the previous stable version.



58
reynaldo
Re: Customized ShortURLs
  • 2004/2/29 11:12

  • reynaldo

  • Not too shy to talk

  • Posts: 106

  • Since: 2004/2/13


Martinjn (wtravel):

We are looking at a very customized version here, it is possible, but it may have its own list of bugs.

I can't promise anything but as soon as Short URLs is error free I can help you customize it.

Anyway I have to say, there are other solutions which address search engine friendly urls by using "virtual" dirs. I really don't like "virtual" dirs as I had poor results with them. Search Engines don't usually /like/content/that/is/so/deep/within/a/dir, but as always, your millage may vary.



59
reynaldo
Re: loadpage.php defaultmodule
  • 2004/2/29 3:05

  • reynaldo

  • Not too shy to talk

  • Posts: 106

  • Since: 2004/2/13


Tl:

Search results are not being rewritten because of the space right before &PHPSESSID

I think this one can be included without breaking anything.

[Edited:]
It is also because the script expects the url to start with "/modules" not with "modules".


Anyway, I don't think this one is so important as I really doubt Search Engines will fill out a search form



60
reynaldo
Re: loadpage.php defaultmodule
  • 2004/2/29 2:18

  • reynaldo

  • Not too shy to talk

  • Posts: 106

  • Since: 2004/2/13


LOL, I just replied to your message.

So that's what is happening with your URLs? I saw the two equal signs (==) at the end of the url but it never occurred to me it was the result of base64 encoding.

Well, that's the reason why they aren't rewritten. I would have to check if I can add that functionality without breaking something else.

If it is not absolutely necessary, you may try not encoding the date variable, maybe converting it to a unix timestamp instead?

Keep me posted.




TopTop
« 1 ... 3 4 5 (6) 7 8 9 ... 11 »



Login

Who's Online

222 user(s) are online (153 user(s) are browsing Support Forums)


Members: 0


Guests: 222


more...

Donat-O-Meter

Stats
Goal: $100.00
Due Date: Apr 30
Gross Amount: $0.00
Net Balance: $0.00
Left to go: $100.00
Make donations with PayPal!

Latest GitHub Commits