31
wanikoo
Re: Let
  • 2005/4/4 20:45

  • wanikoo

  • Not too shy to talk

  • Posts: 129

  • Since: 2003/12/27


Quote:

submit them to the trackers, so we can deal with them

I did right now.
Umm..
btw..
this has just started..
and..
still going on ..
so..
just for reference



32
wanikoo
Re: Let's make XOOPS valid xhtml1.0 transitional!
  • 2005/4/4 19:51

  • wanikoo

  • Not too shy to talk

  • Posts: 129

  • Since: 2003/12/27


-----------------------------------
pages with form class (ex: edituser.php)
--------------------------------

</td></tr><input type='hidden' name='uid' id='uid' value='1' /><tr><td>
or
</td></tr><tr><input type='hidden' name='uid' id='uid' value='1' /><td>
or
<table><input type='hidden' name='uid' id='uid' value='1' /><tr><td>
or
</td></tr><input type='hidden' name='uid' id='uid' value='1' /></table>

This kind of coding above always give us some error message like this....

document type does not allow element "input" here

The element named above was found in a context where it is not allowed. This could mean that you have incorrectly nested elements -- such as a "style" element in the "body" section instead of inside "head" -- or two elements that overlap (which is not allowed).

One common cause for this error is the use of XHTML syntax in HTML documents. Due to HTML's rules of implicitly closed elements, this error can create cascading

Refer to this page
http://www.w3.org/TR/2002/REC-xhtml1-20020801/DTD/xhtml1-transitional.dtd

So..
If we use form classes such as XoopsTableForm(tableform.php), XoopsThemeForm(themeform.php) with XoopsFormHidden(formhidden.php),
we can never get the message," "This Page Is Valid XHTML 1.0 Transitional!" from W3 validator.

ex)
tableform.php
function render()
    {
        
$ret $this->getTitle()."n<form name='".$this->getName()."' id='".$this->getName()."' action='".$this->getAction()."' method='".$this->getMethod()."'".$this->getExtra().">n<table border='0' width='100%'>n";
        foreach ( 
$this->getElements() as $ele ) {
            if ( !
$ele->isHidden() ) {
                
$ret .= "<tr valign='top' align='left'><td>".$ele->getCaption();
                if (
$ele->getDescription() != '') {
                    
$ret .= '<br /><br /><span style="font-weight: normal;">'.$ele->getDescription().'</span>';
                }
                
$ret .= "</td><td>".$ele->render()."</td></tr>";
            } else {
                
$ret .= $ele->render()."n";
            }
        }
        
$ret .= "</table>n</form>n";
        return 
$ret;
    }

if element is hidden,
it will be rendered like this!
$ret .= $ele->render()."\n";

formhidden.php
function render(){
        return 
"<input type='hidden' name='".$this->getName()."' id='".$this->getName()."' value='".$this->getValue()."' />";
    }


Umm...
I think there are some solutions for this problem..
At my first thought,
maybe...
the most simplest solution is to just remove if ( !$ele->isHidden() ) process like this below.
tableform.php
//if ( !$ele->isHidden() ) {
                
$ret .= "<tr valign='top' align='left'><td>".$ele->getCaption();
                if (
$ele->getDescription() != '') {
                    
$ret .= '<br /><br /><span style="font-weight: normal;">'.$ele->getDescription().'</span>';
                }
                
$ret .= "</td><td>".$ele->render()."</td></tr>";
            
//} else {
            //    $ret .= $ele->render()."n";
            //}

themeform.php
if (!is_object($ele)) {
                
$ret .= $ele;
            
//} elseif (!$ele->isHidden()) {
            
} else {
                
//if ($count % 2 == 0) {
                    
$class 'even';
                
//} else {
                //    $class = 'odd';
                //}
                
$ret .= "<tr valign='top' align='left'><td class='head'>".$ele->getCaption();
                if (
$ele->getDescription() != '') {
                    
$ret .= '<br /><br /><span style="font-weight: normal;">'.$ele->getDescription().'</span>';
                }
                
$ret .= "</td><td class='$class'>".$ele->render()."</td></tr>";
                
//$count++;
            //} else {
            //    $ret .= $ele->render();
            
}


------------------------------
After this modification,
(......although we use form classes.....)
we can get this message, "This Page(ex: edituser.php) Is Valid XHTML 1.0 Transitional!" from W3 validator.

--------To be continued--------------



33
wanikoo
Re: Let's make XOOPS valid xhtml1.0 transitional!
  • 2005/4/4 19:50

  • wanikoo

  • Not too shy to talk

  • Posts: 129

  • Since: 2003/12/27


-------------------------------------------
system_userinfo.html(userinfo.php)
------------------------------------------

document type does not allow element "h4" here; missing one of "object", "applet", "map", "iframe", "button", "ins", "del" start-tag

<h4>Downloads</h4>

The mentioned element is not allowed to appear in the context in which you've placed it; the other mentioned elements are the only ones that are both allowed there

From:
<!-- start module search results loop -->
<{foreach 
item=module from=$modules}>

<
p>
<
h4><{$module.name}></h4>

  <!-- 
start results item loop -->
  <{foreach 
item=result from=$module.results}>

  <
img src="<{$result.image}>" alt="<{$module.name}>" /><b><a href="<{$result.link}>"><{$result.title}></a></b><br /><small>(<{$result.time}>)</small><br />

  <{/foreach}>
  <!-- 
end results item loop -->

<{
$module.showall_link}>
</
p>

<{/foreach}>
<!-- 
end module search results loop -->

To:
<!-- start module search results loop -->
<{foreach 
item=module from=$modules}>

<
p></p>
<
h4><{$module.name}></h4>

  <!-- 
start results item loop -->
  <{foreach 
item=result from=$module.results}>

  <
img src="<{$result.image}>" alt="<{$module.name}>" /><b><a href="<{$result.link}>"><{$result.title}></a></b><br /><small>(<{$result.time}>)</small><br />

  <{/foreach}>
  <!-- 
end results item loop -->

<{
$module.showall_link}>
<
p></p>

<{/foreach}>
<!-- 
end module search results loop -->

or
instead of <p></p>, we can use other tags such as <br />...etc.

----------

After this modification,
we can get this message, "This Page(userinfo.php) Is Valid XHTML 1.0 Transitional!" from W3 validator.



34
wanikoo
Re: Let's make XOOPS valid xhtml1.0 transitional!
  • 2005/4/4 17:14

  • wanikoo

  • Not too shy to talk

  • Posts: 129

  • Since: 2003/12/27


Quote:

Herko Coomans wrote:
If you find any code or templates that need to be adjusted because of this, submit them to the trackers, so we can deal with them

Herko

Ok^^
--------------------------------
/html/viewpmsg.php

----------------------
line 68
echo "<tr align='left' class='$class'><td valign='top' width='2%' align='center'><input type='checkbox' id='msg_id[]' name='msg_id[]' value='".$pm_arr[$i]->getVar("msg_id")."' /></td>\n";

During validation check(http://validator.w3.org/ ),
the code above gives us this error message.....

Errors: character "[" is not allowed in the value of attribute "id"

so...we need to change it like this...
from
id='msg_id[]'
to
id='msg_id".$i."'

And...

<table><form> </form></table>
the structure above also gives us some error message in case of viewpmsg.php.
so we need to change it like this..
From:
<table><form> </form></table>
To:
<form><table> </table></form>

------------------------------
After this modification,
we can get this message, "This Page(viewpmsg.php) Is Valid XHTML 1.0 Transitional!" from W3 validator.

------------To be continued--------

PS:
btw,
I will make my PM-hack valid XHTML 1.0 transitional in the next version^^;;



35
wanikoo
Let's make XOOPS valid xhtml1.0 transitional!
  • 2005/4/4 14:47

  • wanikoo

  • Not too shy to talk

  • Posts: 129

  • Since: 2003/12/27


Let's make XOOPS valid xhtml1.0 transitional!

First,
replacing <br>,<hr> with <br />,<hr />

Empty elements must either have an end tag or the start tag must end with />
------------------------------------------
<br> -> <br />
----------------------------------------
/html/class/errorhandler.php
line 169
$output .= sprintf( "%s in file %s line %s<br>\n", $error['errstr'], $error['errfile'], $error['errline'] );

/html/modules/xoopspoll/admin/index.php
line 441
echo "<br>View Log<br> Sorry, not yet. ";

/html/modules/mydownloads/blocks/mydownloads_top.php
line 74
$form .= "&nbsp;<br>"._MB_MYDOWNLOADS_CHARS."&nbsp;<input type='text' name='options[]' value='".$options[2]."' />&nbsp;"._MB_MYDOWNLOADS_LENGTH."";

/html/modules/mylinks/blocks/mylinks_top.php
line 71
$form .= "&nbsp;<br>"._MB_MYLINKS_CHARS."&nbsp;<input type='text' name='options[]' value='".$options[2]."' />&nbsp;"._MB_MYLINKS_LENGTH."";

/html/modules/news/blocks/news_top.php
line68
$form .= "&nbsp;<br>"._MB_NEWS_CHARS."&nbsp;<input type='text' name='options[]' value='".$options[2]."' />&nbsp;"._MB_NEWS_LENGTH."";


/html/modules/system/admin/banners/xoops_version.php
$modversion['author'] = "Francisco Burzi <br>(http://phpnuke.org/ )";

/html/modules/system/admin/findusers/xoops_version.php
$modversion['author'] = "Kazumi Ono<br>(http://www.myweb.ne.jp/ )";

/html/modules/system/admin/mailusers/xoops_version.php
$modversion['author'] = "Kazumi Ono<br>(http://www.myweb.ne.jp/ )";

/html/modules/system/admin/modulesadmin/xoops_version.php
$modversion['author'] = "Kazumi Ono<br>(http://www.mywebaddons.com/ )";

/html/modules/system/admin/users/xoops_version.php
$modversion['author'] = "Francisco Burzi<br>(http://phpnuke.org/ )";

/html/modules/xoopsheadline/xoops_version.php
$modversion['author'] = "Kazumi Ono<br>(https://xoops.org/http://www.xoopscube.jp/http://www.myweb.ne.jp/ )";

and in lang file
/html/modules/newbb/language/english/admin.php
define("_MD_A_YDNFOATPOTFDYAA","You did not fill out all the parts of the form.<br>Did you assign at least one moderator? Please go back and correct the form.");
/html/modules/newbb/language/english/main.php
define("_MD_ANONNOTALLOWED","Anonymous user not allowed to post.<br>Please register.");
/html/modules/sections/language/english/main.php
define("_MD_MUSTREGFIRST","You need to be a registered user or logged in to send a modify request.<br>Please register or login first!");

-------------------------------------------
<hr> -> <hr />
--------------------------------------
/html/modules/mydownloads/admin/index.php
line 335
echo "<hr>";

/html/modules/mylinks/admin/index.php
line 311
echo "<hr>";

/html/modules/sections/admin/index.php
line 49
echo "<hr>
line 61
<hr><h4><?php echo _MD_ADDARTICLE; ?></h4>
line 82
<hr><h4><?php echo _MD_LAST20ART; ?></h4>
line 103
<hr><h4><?php echo _MD_ADDNEWSEC; ?></h4>
line 146
<hr><h4><?php echo _MD_EDITARTICLE; ?></h4>

--------------------------------------------
& -> &amp;
--------------------------------------------
/html/search.php
line 191
$search_url .= "&mid=$mid&action=showall&andor=$andor";
line 253
$search_url .= "&mid=$mid&action=$action&andor=$andor";
line 255
$search_url .= "&uid=$uid";
line 261
$search_url_prev = $search_url."&start=$prev";
line 269
$search_url_next = $search_url."&start=$next";

/html/modules/system/admin/blocksadmin/blockform.php
line 61
$form->addElement(new XoopsFormLabel(_AM_CONTENT, '<a href="'.XOOPS_URL.'/modules/system/admin.php?fct=tplsets&op=edittpl&id='.$btemplate[0]->getVar('tpl_id').'">'._AM_EDITTPL.'</a>'));
line 65
$form->addElement(new XoopsFormLabel(_AM_CONTENT, '<a href="'.XOOPS_URL.'/modules/system/admin.php?fct=tplsets&op=edittpl&id='.$btemplate2[0]->getVar('tpl_id').'" target="_blank">'._AM_EDITTPL.'</a>'));

---------------------------------------------
<input ~~~~~ > -> <input ~~~~~ />
-----------------------------------------
/html/modules/system/admin/banners/banners.php
line 165
"._AM_USEHTML." <input type='checkbox' name='htmlbanner' value='1'>
line 300
echo " <input type='checkbox' name='htmlbanner' value='1' checked='checked'>";
line 302
echo " <input type='checkbox' name='htmlbanner' value='1'>";

----------------------------------------
embed -> object
-----------------------------------------
/include/functions.php

function xoops_getbanner()

From:
if (stristr($imageurl'.swf')) {
                
$bannerobject $bannerobject
                    
.'<object classid="clsid:D27CDB6E-AE6D-11cf-96B8-444553540000" codebase="http://download.macromedia.com/pub/shockwave/cabs/flash/swflash.cab#version=6,0,40,0" width="468" height="60">'
                    
.'<param name=movie value="'.$imageurl.'">'
                    
.'<param name=quality value=high>'
                    
.'<embed src="'.$imageurl.'" quality=high pluginspage="http://www.macromedia.com/shockwave/download/index.cgi?P1_Prod_Version=ShockwaveFlash"; type="application/x-shockwave-flash" width="468" height="60">'
                    
.'</embed>'
                    
.'</object>';
            } else {
                
$bannerobject $bannerobject.'<img src="'.$imageurl.'" alt="" />';
            }

( btw, in ShockwaveFlash"; Umm.. no need ; !! )

to:
if (stristr($imageurl'.swf')) {
                
$bannerobject $bannerobject
                    
.'<object type="application/x-shockwave-flash" data="'.$imageurl.'" width="468" height="60">'
                    
.'<param name="movie" value="'.$imageurl.'" />'
                    
.'<param name="quality" value="high" />'
                    
.'</object>';
            } else {
                
$bannerobject $bannerobject.'<img src="'.$imageurl.'" alt="" />';
            }

same fix needed in /html/banners.php

Read this article if you want more info.
http://www.alistapart.com/articles/flashsatay/
---------------------------------

and bug fix!

/html/modules/system/admin/smiles/smiles.php
line 70
From:
if ($smiles['display'] == 1) {
echo ' checked="checked"';
}
To:
if ($smiles['display'] == 1) {
echo ' checked="checked"';
}
echo " />";

Umm...
I think it's still not perfect.

-------To be continued---------^^;;



36
wanikoo
Re: All xoops headline mods DO NOT WORK with PHP5
  • 2005/3/25 14:14

  • wanikoo

  • Not too shy to talk

  • Posts: 129

  • Since: 2003/12/27


Quote:

joeboe wrote:
I attempted the fix described above and I now get blank pages after submitting changes and when viewing the front page with the headlines module enabled.

Umm...
I checked and reconfirmed it works well.
Quote:

joeboe wrote:
the News module does not appear to be acting properly either. It does not let me add any articles.

Just replace the formers with the latters
And...
all basic modules included in XOOPS core package will work well.
( exception: myheadline )
$HTTP_GET_VARS to $_GET
$HTTP_POST_VARS to $_POST
$HTTP_COOKIE_VARS to $_COOKIE
$HTTP_POST_FILES to $_FILES
$HTTP_ENV_VARS to $_ENV
$HTTP_SERVER_VARS to $_SERVER
$HTTP_SESSION_VARS to $_SESSION

PS:
If you don't have free time to replace them,
Just visit this link below.
http://www.xoopscube.jp/modules/mydownloads/singlefile.php?cid=4&lid=192
(I didn't check this package in detail...
but..someone told me that although it's not perfect, he at least did replace all of them(mentioned above))



37
wanikoo
Re: XOOPS PM(Private Message)-Hack
  • 2005/3/22 14:29

  • wanikoo

  • Not too shy to talk

  • Posts: 129

  • Since: 2003/12/27


Quote:

Tabasco wrote:
What is wanipmhack section(I mean ////////////////WANIPMHACK3.0)?

^^;;
Please open&compare /html/footer.txt and /html/footer.php( original file ) ,
and you can easily understand what it is ^^;;
Quote:

kumzzy wrote:
is there a latest file to download after all this discussion here?

At this point,
the latest is Ver4.6 ^^;
And maybe some upgrades...
but not much change...
(^^;;--;;(--)// Just enjoy!! )

Umm..
If you want the latest version of this PM-hack,
please, just monitor this thread and you can easily acquire the latest.

Quote:

suico wrote:
Great job wanikoo I love this, it was exactly what i were looking for.

^^I'm happy to hear that ^^;;
Quote:

suico asked:
Some questions for you:
Q1:
Is it possible to, when we set that users can t set the refusal or filter, those options dispear from the config form?
Q2:
ON the [PM System Function Status] could you make it showing only for admins? The members when they see a feature that is disable he asks us to have it and sometimes we don t want it and don t want to explain why.
Q3:
Also in the same screen agood idea would be to not show the whole column backup when we chose to not enable backup for members, the way it is we see a column without the options but the column is there

Q1,Q3:
Umm...
Thanks for your suggestion!
I will try to make your suggestion realized in the next version^^;;
Q2:
Umm...
Basically,
I plan to keep the current policy that users can access PM System Function Status.
but...
for some like you who don't want users to access it,
I will release the modified version of configpmsg.php... sooner or later.

----------------
PS:
btw....
....
irmtfan (who gave me lots of help for this PM-hack) had suggested PM category function..before like this.
Quote:

3- users can create category inside savebox and save pms in individual branchs.

Umm...
You guys really want this function???
Umm...
I have some idea and draft to realize this now....
but...
I guess it will result in lots of change in the current version of this PM-hack.
so...
I want to know whether you guys really want this function^^;;



38
wanikoo
Re: XOOPS PM(Private Message)-Hack
  • 2005/3/17 11:21

  • wanikoo

  • Not too shy to talk

  • Posts: 129

  • Since: 2003/12/27


Quote:

Hisoka wrote:
What a pretty good work!
Windows are very nice now!

I am happy that you like this PM-hack^^
Quote:

Hisoka wrote:
EDIT: Just one Question.
I would like to know where i can modify the name of the button we have when we send a PM to search the Name and the IUD of The PM Partner.

Umm...

In case of Ver4.6,
Find this code! (pmlite.php)
echo "&nbsp;<input type='button' name='search' value='"._SEARCH."' onclick='javascript:openWithSelfMain("".XOOPS_URL."/usersearch.php","searchuser",".$usersearch_width.",".$usersearch_height.");' /></td>";

and change this, value='"._SEARCH."'
(Umm... _SEARCH is defined in global.php )
-------------------
in case of 3.x-4.5
Find this code!(pmlite.php)
echo "&nbsp;<input type='button' name='search' value='Click' onclick='javascript:openWithSelfMain("".XOOPS_URL."/usersearch.php","searchuser",550,430);' /></td>";

and change this, value='Click'

PS:
From.. Ver4.6
You can easily customize the size of popup-windows!
(pmlite.php, viewpmsg.php, readpmsg.php )
ex:
pmlite.php
Find this code^^and customize them for your system.
//usersearch popup size value
$usersearch_width = 550;
$usersearch_height = 600;
And if you want to change the size and other attributes of Help popup,
please open/edit.../include/pm_functions.php
function pm_overDivEcho()
{
    echo 
"<script language='Javascript' src='".XOOPS_URL."/overlib_mini.js' type='text/javascript'></script>n";
    echo 
"<DIV id='overDiv' style='Z-INDEX: 10000; VISIBILITY: hidden; POSITION: absolute; width: 250px;'></DIV>n";
}

function 
pm_overDivaction($pmhelptext$pmhelpcaption)
{
    return 
"<a href='#' onmouseover="return overlib('".$pmhelptext."'CAPTION'".$pmhelpcaption."'BELOWRIGHT);"  onmouseout='return nd();'><img src='".XOOPS_URL."/images/pmhelp.png' /></a>&nbsp;";
}

function 
pm_overDivaction2($pmhelptext$pmhelpcaption)
{
    return 
"onmouseover="return overlib('".$pmhelptext."'CAPTION'".$pmhelpcaption."'BELOWRIGHT);"  onmouseout='return nd();'";
}



39
wanikoo
Re: Auto PM greeting?
  • 2005/3/17 11:01

  • wanikoo

  • Not too shy to talk

  • Posts: 129

  • Since: 2003/12/27


My old Hack^^
But it still works well!

If you want to send a welcome PM to your new member automatically, please follow this link below^^
(It's written in Japanese..but...I think you can easily understand it ^^)

http://www.xoopscube.jp/modules/newbb/viewtopic.php?topic_id=6253&forum=14



40
wanikoo
Re: PHP5 vs xhld, xmline, headlines
  • 2005/3/16 14:27

  • wanikoo

  • Not too shy to talk

  • Posts: 129

  • Since: 2003/12/27


Umm...
I succeed^^;;
If you want to use xoopsheadline on PHP5,
you have to fix some bug and change some code^^;;

(1)First, this change is necessary!!
---target file: /xoopsheadline/class/headline.php---
From:
get_class($headline) != 'xoopsheadlineheadline'
To:
strtolower(get_class($headline)) != 'xoopsheadlineheadline'

because In PHP5, get_class($headline) returns XoopsheadlineHeadline !

And
---target files: /xoopsheadline/admin/index.php , /xoopsheadline/index.php---
Change like this^^;;

$HTTP_GET_VARS to $_GET
$HTTP_POST_VARS to $_POST

(2)Some bug fixes needed^^;;
---------------------
/xoopsheadline/admin/index.php
From:
$hlman =& xoops_getmodulehandler('headline');;
To: ( I mean not ;; just ; )
$hlman =& xoops_getmodulehandler('headline');
--------------------
And
/xoopsheadline/class/headlinerenderer.php

From:(Yeah^^This bug is one of real culprits !!!!!!!)
class XoopsHeadlineRenderer
{
// holds reference to xoopsheadline class object
var $_hl;

var $_tpl;

// XoopTemplate object
var $_tpl;

To:
class XoopsHeadlineRenderer
{
// holds reference to xoopsheadline class object
var $_hl;

var $_tpl;

// XoopTemplate object
//var $_tpl;
I mean not two $_tpl just one $_tpl !!!!!!!!!!!!!!

Umm...
I confirmed it works well on PHP5 after this change.
(3) this change is also necessary!!
/html/class/xml/saxparser.php
From:
function free()
{
xml_parser_free($this->parser);

unset($this);
$this = null;
}
To:
function free()
{
xml_parser_free($this->parser);

unset($this);
//$this = null;
}
I mean //$this = null;

And
this is optional....
but...I recommend that you use snoopy instead of fopen^^;;




TopTop
« 1 2 3 (4) 5 6 7 ... 12 »



Login

Who's Online

219 user(s) are online (162 user(s) are browsing Support Forums)


Members: 0


Guests: 219


more...

Donat-O-Meter

Stats
Goal: $100.00
Due Date: Mar 31
Gross Amount: $0.00
Net Balance: $0.00
Left to go: $100.00
Make donations with PayPal!

Latest GitHub Commits