Hi Ghia, thanks for your help, to be honest I did not understand what you said, I'm afraid my knowledge of PHP is limited and that stuff is just way over my head.
However I have made a couple of hacks to xml.php code if anyone is interested in using it.
1. Before when viewing RSS for a category the page title showed as SiteName::Category, it did not show the actual category name it just showed the word 'category', I have modified it so the pagetitle shows the actual category name example
here2. Hardcoded in links to shortened URLs created by the XoWreriteModules hack by Dugris before the links showed the old "/modules/" urls
3. Hardcoded in a diifferent image so it can show a custom image (image would display on feedburner pages) instead of the module logo.
Here is my revised code for xml.php:
<?php
/**
* Article module for XOOPS
*
* You may not change or alter any portion of this comment or credits
* of supporting developers from this source code or any supporting source code
* which is considered copyrighted (c) material of the original comment or credit authors.
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
*
* @copyright The XOOPS Project http://sourceforge.net/projects/xoops/
* @license http://www.fsf.org/copyleft/gpl.html GNU public license
* @package article
* @since 1.0
* @author Taiwen Jiang <phppp@users.sourceforge.net>
* @version $Id: xml.php 2283 2008-10-12 03:36:13Z phppp $
*/
ob_start();
include "header.php";
error_reporting(0);
$xoopsLogger->activated = false;
if (art_parse_args($args_num, $args, $args_str)) {
$args["article"] = !empty($args["article"]) ? $args["article"] : @$args_num[0];
$args["type"] = @$args_str[0];
}
$article_id = intval( empty($_GET["article"]) ? @$args["article"] : $_GET["article"] );
$category_id = intval( empty($_GET["category"]) ? @$args["category"] : $_GET["category"] );
$page = intval( empty($_GET["page"]) ? @$args["page"] : $_GET["page"] );
$uid = intval( empty($_GET["uid"]) ? @$args["uid"] : $_GET["uid"] );
$type = empty($_GET["type"]) ? (empty($_GET["op"]) ? @$args["type"] : $_GET["op"]) : $_GET["type"];
$type = strtoupper($type);
$category_handler =& xoops_getmodulehandler("category", $GLOBALS["artdirname"]);
$article_handler =& xoops_getmodulehandler("article", $GLOBALS["artdirname"]);
$article_obj =& $article_handler->get($article_id);
if ($article_id > 0) {
$criteria = new CriteriaCompo(new Criteria("ac.ac_publish", 0, ">"));
$categories_obj =& $category_handler->getByArticle($article_id, $criteria);
if (count($categories_obj) ==0 || !in_array($category_id, array_keys($categories_obj))) $category_id=0;
unset($categories_obj);
$category_id = empty($category_id)?$article_obj->getVar("cat_id"):$category_id;
}
$category_obj =& $category_handler->get($category_id);
$_uid = empty($xoopsUser) ? 0 : $xoopsUser->getVar("uid");
$isAuthor = ( $article_obj->isNew() || $_uid == $article_obj->getVar("uid") );
$isAdmin = $category_handler->getPermission($category_obj, "moderate");
if ($isAuthor || ($isAdmin && $article_handler->getCategoryStatus($category_id, $article_id) !== NULL)) {
} elseif (
empty($category_id)
|| !$category_handler->getPermission($category_obj, "view")
|| !$article_obj->getVar("art_time_publish")
){
art_trackback_response(1, art_constant("MD_NOACCESS"));
}
if ($type == "RDF") $type = "RSS1.0";
if ($type == "RSS") $type = "RSS0.91";
$valid_format = array("RSS0.91", "RSS1.0", "RSS2.0", "PIE0.1", "MBOX", "OPML", "ATOM", "ATOM0.3", "HTML", "JS");
if (empty($type) || !in_array($type, $valid_format)) {
$type = "RSS";
}
if ($article_id > 0) {
$myuid = empty($xoopsUser) ? 0 : $xoopsUser->getVar("uid");
$isAuthor = ($article_obj->isNew() || $myuid == $article_obj->getVar("uid"));
$isAdmin = $category_handler->getPermission($category_obj, "moderate");
if ($isAuthor || ($isAdmin && $article_handler->getCategoryStatus($category_id, $article_id)!==NULL)){
} elseif (
empty($category_id)
|| !$category_handler->getPermission($category_obj, "view")
|| !$article_obj->getVar("art_time_publish")
){
art_trackback_response(1, art_constant("MD_NOACCESS"));
}
}
$xml_charset = empty($xoopsModuleConfig["do_rssutf8"]) ? _CHARSET : "UTF-8";
include_once XOOPS_ROOT_PATH . '/class/template.php';
$tpl = new XoopsTpl();
$tpl->caching = 2;
$tpl->cache_lifetime = 3600;
load_functions("cache");
$xoopsCachedTemplateId = md5( mod_generateCacheId() . str_replace( XOOPS_URL, '', $_SERVER['REQUEST_URI'] ) );
if (!$tpl->is_cached('db:system_dummy.html', $xoopsCachedTemplateId)) {
if (!empty($article_id)) $source = "article";
elseif (!empty($category_id)) $source = "category";
elseif (!empty($uid)) $source = "author";
else $source = "index";
$items = array();
switch ($source) {
case "article":
$category_id = empty($category_id)?$article_obj->getVar("cat_id"):$category_id;
$category_obj =& $category_handler->get($category_id);
if (empty($category_obj) || !$category_handler->getPermission($category_obj, "view")) {
art_trackback_response(1, art_constant("MD_NOACCESS"));
}
$pagetitle = art_constant("MD_ARTICLE");
$rssdesc = art_constant("MD_XMLDESC_ARTICLE");
$author = $article_obj->getAuthor(true);
$text = $article_obj->getText($page);
$content = art_constant("MD_CATEGORY") . ": " . $category_obj->getVar("cat_title");
if ($text["title"]) {
$content .= "<br />" . art_constant("MD_SUBTITLE") . ": " . $text["title"];
}
$source_author = $author["author"];
$source_source = $article_obj->getVar("art_source");
if (!empty($source_author)||!empty($source_source)) {
$content .= "<br />" . art_constant("MD_SOURCE") . ": " . $source_author . "(" . $source_source . ")";
}
if ($article_obj->getVar("art_keywords")) {
$content .= "<br />" . art_constant("MD_KEYWORDS") . ": " . $article_obj->getVar("art_keywords");
}
if ($summary = $article_obj->getSummary()) {
$content .= "<br />" . art_constant("MD_SUMMARY") . ": " . $summary;
}
$content .= $text["body"] . "<br />";
$items[] = array(
"title" => $article_obj->getVar("art_title"),
"link" => XOOPS_URL . "/news/view.article.php" . URL_DELIMITER . $article_obj->getVar("art_id") . "/c" . $category_id,
"description" => $content,
"descriptionHtmlSyndicated" => true,
"date" => $article_obj->getTime("rss"),
"source" => XOOPS_URL . "/modules/" . $GLOBALS["artdirname"] . "/",
"author" => $author["name"]
);
$xml_link = XOOPS_URL . "/news/view.article.php" . URL_DELIMITER . $article_obj->getVar("art_id") . "/c" . $category_id;
break;
case "category":
$category_obj =& $category_handler->get($category_id);
if (empty($category_obj) || !$category_handler->getPermission($category_obj, "access")) {
art_trackback_response(1, art_constant("MD_NOACCESS"));
}
$pagetitle = art_constant("MD_CATEGORY");
$rssdesc = sprintf(art_constant("MD_XMLDESC_CATEGORY"), $category_obj->getVar("cat_title"));
$criteria = new CriteriaCompo(new Criteria("ac.ac_publish", 0, ">"));
$articles_obj =& $article_handler->getByCategory(
$category_id,
$xoopsModuleConfig["articles_perpage"],
0,
$criteria,
array("a.art_title", "a.art_time_publish", "a.art_keywords", "a.art_summary", "a.uid", "a.art_source")
);
foreach ($articles_obj as $id => $article) {
$uids[$article->getVar("uid")] = 1;
}
$users = art_getUnameFromId(array_keys($uids));
foreach ($articles_obj as $id => $article) {
$content = art_constant("MD_TITLE") . ": " . $article->getVar("art_title"). "<br />";
$content .= art_constant("MD_SUMMARY") . ": " . $article->getSummary(true);
$items[] = array(
"title" => $article->getVar("art_title"),
"link" => XOOPS_URL . "/news/view.article.php" . URL_DELIMITER . $article->getVar("art_id") . "/c" . $category_id,
"description" => $content,
"descriptionHtmlSyndicated" => true,
"date" => $article->getTime("rss"),
"source" => XOOPS_URL . "/modules/" . $GLOBALS["artdirname"] . "/",
"author" => $users[$article->getVar("uid")]
);
}
$xml_link = XOOPS_URL . "/news/view.category.php" . URL_DELIMITER . $category_id;
break;
case "author":
$author_name = XoopsUser::getUnameFromId($uid);
$pagetitle = art_constant("MD_AUTHOR");
$rssdesc = sprintf(art_constant("MD_XMLDESC_AUTHOR"), $author_name);
$categories_obj = $category_handler->getAllByPermission("access", array("cat_title", "cat_moderator"));
$categories_id = array_keys($categories_obj);
if (count($categories_id) == 0) {
$items = array();
break;
}
$criteria = new CriteriaCompo(new Criteria("a.uid", intval($uid)));
$criteria->add(new Criteria("ac.ac_publish", 0, ">"));
$articles_obj =& $article_handler->getByCategory(
$categories_id,
$xoopsModuleConfig["articles_perpage"],
0,
$criteria,
array("a.art_title", "a.cat_id", "a.art_time_publish", "a.art_keywords", "a.art_summary", "a.art_source")
);
foreach ($articles_obj as $id => $article) {
$content = art_constant("MD_CATEGORY") . ": " . $categories_obj[$article->getVar("cat_id")]->getVar("cat_title") . "<br />";
$content .= art_constant("MD_TITLE") . ": " . $article->getVar("art_title") . "<br />";
$content .= art_constant("MD_SUMMARY") . ": " . $article->getSummary(true);
$items[] = array(
"title" => $article->getVar("art_title"),
"link" => XOOPS_URL . "/news/view.article.php" . URL_DELIMITER . $article->getVar("art_id") . "/c" . $article->getVar("cat_id"),
"description" => $content,
"descriptionHtmlSyndicated" => true,
"date" => $article->getTime("rss"),
"source" => XOOPS_URL . "/modules/" . $GLOBALS["artdirname"] . "/",
"author" => $author_name
);
}
$xml_link = XOOPS_URL . "/news/view.author.php" . URL_DELIMITER . $uid;
break;
case "index":
default:
$pagetitle = art_constant("MD_INDEX");
$rssdesc = art_constant("MD_XMLDESC_INDEX");
$categories_obj = $category_handler->getAllByPermission("access", array("cat_title", "cat_moderator"));
$categories_id = array_keys($categories_obj);
if(count($categories_id)==0){
$items=array();
break;
}
$criteria = new CriteriaCompo(new Criteria("cat_id", "(".implode(",",$categories_id).")", "IN"));
$criteria->add(new Criteria("art_time_publish", 0, ">"));
$criteria->setLimit($xoopsModuleConfig["articles_perpage"]);
$articles_obj = $article_handler->getAll($criteria,
array("art_title", "uid", "cat_id", "art_time_publish", "art_keywords", "art_summary", "art_source")
);
/*
$articles_obj =& $article_handler->getPublished(
$xoopsModuleConfig["articles_perpage"],
0,
$criteria,
array("art_title", "uid", "cat_id", "art_time_publish", "art_keywords", "art_summary", "art_author", "art_source")
);
*/
foreach ($articles_obj as $id => $article) {
$uids[$article->getVar("uid")] = 1;
}
$users = art_getUnameFromId(array_keys($uids));
foreach ($articles_obj as $id => $article) {
$content = art_constant("MD_CATEGORY") . ": " . $categories_obj[$article->getVar("cat_id")]->getVar("cat_title") . "<br />";
$content .= art_constant("MD_TITLE") . ": " . $article->getVar("art_title") . "<br />";
$content .= art_constant("MD_SUMMARY") . ": " . $article->getSummary(true);
$items[] = array(
"title" => $article->getVar("art_title"),
"link" => XOOPS_URL . "/news/view.article.php" . URL_DELIMITER . $article->getVar("art_id") . "/c" . $article->getVar("cat_id"),
"description" => $content,
"descriptionHtmlSyndicated" => true,
"date" => $article->getTime("rss"),
"source" => XOOPS_URL . "/news/",
"author" => $users[$article->getVar("uid")]
);
}
$xml_link = XOOPS_URL . "/news/";
break;
}
$xml_charset = empty($xoopsModuleConfig["do_rssutf8"]) ? _CHARSET : "UTF-8";
$xml_handler =& xoops_getmodulehandler("xml", $GLOBALS["artdirname"]);
$xml = $xml_handler->create($type);
$xml->setVar("encoding", $xml_charset);
//edited line below to add cat_title 11sep09
$xml->setVar("title", $xoopsConfig["sitename"] . " : " . $category_obj->getVar("cat_title"),"UTF-8", $xml_charset, true);
$xml->setVar("description", $rssdesc, true);
$xml->setVar("descriptionHtmlSyndicated", true);
$xml->setVar("link", $xml_link);
$xml->setVar("syndicationURL", XOOPS_URL . "/" . xoops_getenv("PHP_SELF"));
$xml->setVar("webmaster", checkEmail($xoopsConfig["adminmail"], true));
$xml->setVar("editor", checkEmail($xoopsConfig["adminmail"], true));
$xml->setVar("category", $xoopsModule->getVar("name"), true);
$xml->setVar("generator", $xoopsModule->getInfo("version"));
$xml->setVar("language", _LANGCODE);
//$dimention = @getimagesize(XOOPS_ROOT_PATH . "/modules/" . $GLOBALS["artdirname"] . "/" . $xoopsModule->getInfo("image"));
$image = array(
"width" => @$dimention[0],
"height" => @$dimention[1],
"title" => $xoopsConfig["sitename"],
"url" => XOOPS_URL . "/images/psnews_feed_img.gif",
"link" => XOOPS_URL . "/news/",
"description" => $rssdesc
);
$xml->setImage($image);
/*
$item = array(
"title" => $datatitle,
"link" => $dataurl,
"description" => $datadesc,
"descriptionHtmlSyndicated" => true,
"date" => $datadate,
"source" => $datasource,
"author" => $dataauthor
);
*/
$xml->addItems($items);
$dummy_content = $xml_handler->display($xml, XOOPS_CACHE_PATH."/".$GLOBALS["artdirname"].".xml.tmp");
$dummy_content = $xml_handler->display($xml);
$tpl->assign_by_ref('dummy_content', $dummy_content);
}
//$content = ob_get_contents();
ob_end_clean();
header('Content-Type:text/xml; charset=' . $xml_charset);
$tpl->display('db:system_dummy.html', $xoopsCachedTemplateId);
?>
Something you may have to change to suit your own site.
Things still needing fixed or hacked:
1. Feeds for index page RSS need fixed to show 10 most recent articles instead of the 10 oldest.
2. Hack to show the uploaded article image in the feed would be good to.
playsome
