seems the issue I was talking about is still present in the 2.0.18.1 release (not RC).

the solution still applies.
don't know if this is a local thing (like only from my computer I can't login), but I wasn't going to try it either

you're right.
sorry for my spreading of misinformation.
I guess I got something mixed up. Though I had a lot of files and version opened at the same time... then I focused on the 2.0.18 and got thru the code to see what is going on.

thanx for the link.

I was already going thru the code, and got to that part.

basically the problem is that they now made the getsmilies function to have a boolean parametar which says wheter to get all the smilies or only the "display" ones. no param means get all.

the problem will manifest with any modules that call the function directly and think they will get only the display ones.

but I guess it is fixed...

bah.

if anyone is reading this, this still don't fix things like I though it does. it comes to be the same as checking all of the smilies...

too bad...

at first it seemed that it was all ok, because I stayed log in...
when tested in another browser it wouldn't log in. but I also tested some other stuff so I figured there is another problem.

but tommorow I couldn't log with any user in any browser...

it simply says the standard "thank you for loging in..." message, but you are not logged in. it is not a cashe problem for sure.

so I tried returning the files to the 2.0.18 version.

when I returned the file "XOOPS_ROOT/kernel/session.php" to it's previous version it started working again.

so I guess the problem is in this file. thou the only differance is line 78.
it states "var $enableRegenerateId = false;" in 2.0.18.1, and it said "true" in 2.0.18.
Not sure how this affectes the problem, but it has to be it.
it is only used for a check in one place, and I am not sure what it does.

it seems that the 2.0.18.1 has fixed this problem.

as far as I have seen, the solution is very similar to the code I came up with :)

I've read the topic (a lot to read :)), and I think I do understand the problems.

I had my fingers into some designing, and some (more) in developing and mostly in trying to get a lot of old things to work on new servers. I've tried to adapt some modules to look good on my site, but some even had hard coded html attributes, not even classes! so I gave up on some of them.

and I would also like to support the designers. we need some guidelines for the developers. but then again I do understand how hard it is to do that. I had to give up on a bunch of modules because my servers are php5, and most weren't converted yet, most aren't even now. don't know what would happen if we draw the line and drop the design for all the old modules. but I do know that at some point we will have to, or just give up on everything.

I think we need to think of some kind of a transition. meaning making a great new system, that will be good for design, and also good for developers with a nice guide of what classes to use with a few examples. they could even use just tables and I guess we'll live with that.
but also there would be a need for some kind of a support for old modules, maybe even some kind of a secondary theme? maybe that is where some kind of a template like the ones proposed could be used, to cover those problems. I know it is not nice to have some modules look different, but then again sometimes you just need them to work more than you need them to look nice...

I know I didn't give any real answers, but I hope that I gave some points to think about. I hope.

I would have to say that in my case the proposed code didn't do much.
though enabling the display check box next to the smileys in the admin panel did help, with both the old and the new code.

so I am guessing that someone decided that the check box no longer means
1)display the smiley in the list on post (reply, new topic etc.) pages, but otherwise use it regularly
instead now it is
2)display the smilie when the code is used. which also means that ALL smileys are displayed below post dialogs. which also means that the "more smileys" button don't make any sense anymore.

I would also point out that option 2 doesn't really make much sense. Besides the thing that it ruins the old way of doing things, and goes against the descriptions, it also don't make much sense to me to have smileys in my db and then disabling them from use. that is what the "delete" button is for? am I wrong?

please return this to the old ways? should I complain on some official channel? I don't know where... on the bug tracker?

anyway the solution that works for me is
in /class/module.textsanitizer.php
line #97

replace with


this will return the old behaviour. or at least it did for me.

xoopspoll is old, and has problems with new php. at least I think.

on my site it also didn't work. just showed the list no mater what I cliked in the admin list. then I edited the php, to use $_REQUEST instead of $HTTP_POST_VAR and it worked.

but any poll that I add doesn't have no title, options or nothing. just empty.

so try something newer. I'm looking at
http://xprojects.co.uk/modules/xproject/index.php?op=viewSummary&pid=3

it should be okay. I'm about to test it.