At present the js Calendar used by XoopsFormTextDateSelect and XoopsFormDateTime pops up the first time showing the date for January 2000. Subsequent popups show the correct date.

FIX:

Filename: /include/calendarjs.php
Function: function showCalendar(id)

Suggested Code:

function showCalendar(id) {
var el = xoopsGetElementById(id);
if (calendar != null) {
calendar.hide();
} else {
var cal = new Calendar(true, , selected, closeHandler);
calendar = cal;
cal.setRange(2000, 2015);
calendar.create();
}
calendar.sel = el;
calendar.parseDate(el.value);
calendar.showAtElement(el);
Calendar.addEvent(document, "mousedown", checkCalendar);
return false;
}

Explanation:
The only change is to move the parseDate() call to after the calendar has been set to point to the function's element id parameter.

The calendar's selected date is then set correctly whether the calendar is being created for first time or not.


Venezia

Great, thanks. Can you submit this patch to the sourceforge.net XOOPS project tracker, so the core devs can look at it and add it to the core? Thanks!

Herko

Herko,

Should fixes such as these be posted directly to the XOOPS project tracker, or should they be posted here first? Or does it matter?

Venezia

that depends on what you want. If you post them here, people can fix it for themselves, if you post them on the tracker, they will be included in a next release. Posting them on both places is the best, I think. If you link to the tracker item in your posts here, poeple can monitor its status too.

herko

Great, thanks.

This bug has ... erhm... bugged me for a long time, but my JavaScript skills are below zero.

I'll see to it that this one and your xoopstree bugfix are put in XOOPS 2.0.7