1
jordi_rc
Buddyfriends module vs directfriends
  • 2006/10/12 13:42

  • jordi_rc

  • Not too shy to talk

  • Posts: 114

  • Since: 2006/8/21


Hello.

I was trying to make DirectFriends module work in XOOPS 2.0.15, wich is impossible due to the big number of bugs.
I suggest you remove it from the module repository, or explain that it only works in some old releases of xoops.

Instead of using that, I tested BUDDYFRIENDS module and at least it works. It has some bugs, but I will try to fix them.

There are some variables not defined, like $p, that seem not to have sense, and some variables not defined that need to, and some already defined constants that throw errors, BUT WORKS OK!

I would need to know if someone has done some improvements over buddyfriends module (wich is based on directfriends) and may help me to fix the bugs.

I also will be happy if someone can help me to fix the bugs, maybe we can work together by email or msn, yim, or jabber, and when we finish fixing the bug, post the module as Buddyfriends 2.4 or something, GPL, to contribute continue developing it by XOOPS community.

Someone wants?

Thanks.

Jordi
"Battles are fought by those with the courage to believe. They are won by those who find the heart to share." -MANOWAR

2
jordi_rc
Re: Buddyfriends module vs directfriends
  • 2006/10/14 9:28

  • jordi_rc

  • Not too shy to talk

  • Posts: 114

  • Since: 2006/8/21


Hi again

I am trying to remobe bugs to buddyfriends module.

There are minor bugs that I am solving.

There is one that is fatal error, that is thrown when someone post a private message to a user that has him in his friendlist and tries to reply from this module.

I think the call to the function of private message reply may not be right.

The error is:
Quote:

Fatal Error: Call to a member function getVar() on a non-object in /opt/lampp/htdocs/website/pmlite.php line 84


If I go to that file pmlite.php line 84:
Quote:

if ($reply == 1) {
$pm_handler =& xoops_gethandler('privmessage');
$pm =& $pm_handler->get($msg_id);
if ($pm->getVar("to_userid") == $xoopsUser->getVar('uid')) {
$pm_uname = XoopsUser::getUnameFromId($pm->getVar("from_userid"));
$message = "Quote:
\n";
$message .= sprintf(_PM_USERWROTE,$pm_uname);
$message .= "\n".$pm->getVar("msg_text", "E")."\n
";
} else {
unset($pm);
$reply = $send2 = 0;
}
}




The function in modules/buddy.php that seems to call this is like this:
Quote:


function buddycompose($to, $subject, $prev_msg) {
echo "<SCRIPT LANGUAGE=\"JavaScript\">
document.location.href=\"".XOOPS_URL."/pmlite.php?reply=1&msg_id=".$prev_msg."\"
</SCRIPT>";
exit;
}


In the end of the file we found this:

Quote:

switch($task) {
case "buddel":
buddel($prev_msg);
break;
case "buddyread":
buddyread($msg_id, $msg_time);
break;
case "buddycompose":
buddycompose($to, $subject, $prev_msg);
break;
case "buddyfriend":
displayFriendsList($beg);
break;
case "mod":
displayUsersList($beg, $letter);
break;
case "ajouter":
addFriend($uid);
break;
case "retirer":
deleteFriend($uid);
break;
default:
buddylist();
break;
}




I think that someone that knows how pmlite works can solve this easily. Please help me and help all the people here, that may want a version of Buddyfriends working all right.

When we fix it all, I will email the module to the developer so he can place this here in XOOPS site to be downloaded by all people.

Jordi.
"Battles are fought by those with the courage to believe. They are won by those who find the heart to share." -MANOWAR

3
jordi_rc
Re: Buddyfriends module vs directfriends
  • 2006/10/19 10:57

  • jordi_rc

  • Not too shy to talk

  • Posts: 114

  • Since: 2006/8/21


OK

I changed Buddyfriends, now it seems to work ok.

I modified part of the code to make it work, added an online caption in friends table, removed many bugs, added list of new messages ( before only 1 was showed)...

I need to know, as Buddyfriends is GPL, if I can host it or send it somewhere, to someone, to be shared with all XOOPS community, as I want this module to be developed more in the future by others.
I just added that bugfix and improvements were made by me under the names of the people that developed it before me.

Maybe many things may be fixed in the code, as I didn't removed all old variables, left those wich work.
But now, at least it works.

I need it to be tested by others, developed by us all, and please share improvements with all as I want to do.

Just please tell me where or to whom send it, or should I host it somewhere in my websites and give a link?

Jordi
"Battles are fought by those with the courage to believe. They are won by those who find the heart to share." -MANOWAR

4
jordi_rc
Re: Buddyfriends module vs directfriends
  • 2006/11/17 6:19

  • jordi_rc

  • Not too shy to talk

  • Posts: 114

  • Since: 2006/8/21


http://usuarios.lycos.es/ancientgames/xoops/buddyfriends24.zip

This is the temporary place where to download the bugfixed Buddyfriends until I find the author or post it to XOOPS dev.

Jordi
"Battles are fought by those with the courage to believe. They are won by those who find the heart to share." -MANOWAR

5
jordi_rc
Re: Buddyfriends module vs directfriends
  • 2006/11/21 10:54

  • jordi_rc

  • Not too shy to talk

  • Posts: 114

  • Since: 2006/8/21


To anyone that tried to install this module bugfixed by me and couldn't:

There was an error in the folder name. Now it is fixed. Try to download and install again.

http://usuarios.lycos.es/ancientgames/xoops/buddyfriends24.zip

Jordi.
"Battles are fought by those with the courage to believe. They are won by those who find the heart to share." -MANOWAR

Login

Who's Online

56 user(s) are online (25 user(s) are browsing Support Forums)


Members: 0


Guests: 56


more...

Donat-O-Meter

Stats
Goal: $100.00
Due Date: Aug 31
Gross Amount: $0.00
Net Balance: $0.00
Left to go: $100.00
Make donations with PayPal!

Latest GitHub Commits