2
If you only have 1 item, creating the array and then looping through it is kind of silly, so change this:
$item_list = array(
'1' => _AM_GPERM_G_ADD ,
'2' => _AM_GPERM_G_APPROVE ,
) ;
$form = new MyXoopsGroupPermForm( _AM_GROUPPERM , $xoopsModule->mid() , 'jobs_submit' , _AM_GROUPPERMDESC ) ;
foreach( $item_list as $item_id => $item_name) {
$form->addItem( $item_id , $item_name ) ;
}
To this:
$form = new MyXoopsGroupPermForm( _AM_GROUPPERM , $xoopsModule->mid() , 'jobs_submit' , _AM_GROUPPERMDESC ) ;
form->addItem( '1', _AM_GPERM_G_ADD) ;
The software industry is the only industry where selling goods known to be defective is perfectly legal, and then you can charge extra for fixing the defects.