1
incama
Flaw in Thin Line Theme
  • 2004/8/13 17:32

  • incama

  • Friend of XOOPS

  • Posts: 513

  • Since: 2003/10/24


We just want to say sorry to the people who have downloaded the theme 'Thin Line' fromhttp://www.incama.nl, before august 13th. It seems (it is) we forgot to remove a piece of code from the theme.html. The file calls a .js file that we use for our own statistics for our site. We recieved a lot of emails and comments with the question why the file contains this code.
As stated on Incama.nl we have made a workaround/removel. So please, remove the code or download the adjusted file.

Thank you all

Incama -staff-

2
Ichthys
Re: Flaw in Thin Line Theme
  • 2004/8/13 21:29

  • Ichthys

  • Just popping in

  • Posts: 1

  • Since: 2004/7/7 2


I really like the theme and am using it on my site right now. However, there seams to be another bug in it: I cant put additional blocks in the center, only the side blocks work.
Any ideas ?

3
Stewdio
Re: Flaw in Thin Line Theme
  • 2004/8/14 3:02

  • Stewdio

  • Community Support Member

  • Posts: 1560

  • Since: 2003/5/7 1


Something isn't right withthe theme, I got the same problem. It appears as though a {foreach_ccblocks} etc is missing from the code.

4
Stewdio
Re: Flaw in Thin Line Theme
  • 2004/8/14 3:11

  • Stewdio

  • Community Support Member

  • Posts: 1560

  • Since: 2003/5/7 1


I just confirmed that this is indeed the case. I added my own code for center right, center center center left blocks and the content appeared. I don't feel like coding all the .css myself, so I'll just have to pass until there is a fix.

You can try adding the following code, but the .css data will make everything look way too big in comparison to the rest of the site. I borked my right colums by placing this code in the wrong spot, I'm not a designer, I was just testing. Maybe someone can add and change this code to reflect proper .css definitions used in the theme.

[size=xx-small]
<{if $xoops_showcblock == 1}>
<table cellspacing="0">
<tr>
<td id="centerCcolumn" colspan="2"> <!-- Start center-center blocks loop -->
<{foreach item=block from=$xoops_ccblocks}>
<table cellspacing="0" style="margin-bottom: 8px;">
<tr>
<td class="blockTitle"><img src="<{$xoops_imageurl}>title_icon.gif" width="22" height="22" align="absmiddle"><{$block.title}></td>
</tr>
<tr>
<td class="blockContent"><{$block.content}></td>
</tr>
</table>
<{/foreach}>
<!-- End center-center blocks loop --> </td>
</tr>
<tr>
<td id="centerLcolumn"> <!-- Start center-left blocks loop -->
<{foreach item=block from=$xoops_clblocks}>
<table cellspacing="0" style="margin-bottom: 8px;">
<tr>
<td class="blockTitle"><img src="<{$xoops_imageurl}>title_icon.gif" width="22" height="22" align="absmiddle"><{$block.title}></td>
</tr>
<tr>
<td class="blockContent"><{$block.content}></td>
</tr>
</table>
<{/foreach}>
<!-- End center-left blocks loop --> </td>
<td id="centerRcolumn"> <!-- Start center-right blocks loop -->
<{foreach item=block from=$xoops_crblocks}>
<table cellspacing="0" style="margin-bottom: 8px;">
<tr>
<td class="blockTitle"><img src="<{$xoops_imageurl}>title_icon.gif" width="22" height="22" align="absmiddle"><{$block.title}></td>
</tr>
<tr>
<td class="blockContent"><{$block.content}></td>
</tr>
</table>
<{/foreach}>
<!-- End center-right blocks loop --> </td>
</tr>
</table>
<{/if}>
<!-- End display center blocks -->
<div id="content"><{$xoops_contents}>
[/size]

5
Stewdio
Re: Flaw in Thin Line Theme
  • 2004/8/14 3:38

  • Stewdio

  • Community Support Member

  • Posts: 1560

  • Since: 2003/5/7 1


This just keep getting strager by the minute.

I went to look at the code on incama, and it code is identical (except the .js they use). I can see center blocks just fine on their site, but not on mine, and as another user claimed neither can he.

So what gives? Pardon my ignorance, I'm not a designer.

6
Stewdio
Re: Flaw in Thin Line Theme
  • 2004/8/14 3:50

  • Stewdio

  • Community Support Member

  • Posts: 1560

  • Since: 2003/5/7 1


Sorry to keep nudging this up, but I keep finding out a few new things here and there.

The reason why it works fine on incama, is because they are not using any center blocks. They also use the news module as the default, so that explains that away.

I, like some other users, do not use a module for the home. I personaly find that a bit tacky for my own personal reasons. (no offence to those that do use this method).

So, I suppose it goes back to the original bit of code being missing from the theme. Code for modules works great as intended. I have no problems browsing the site, except anywhere I have defined ceneter blocks, be that on the home page or other pages, they will not display in the center.

Thats the last of my reporting the issue, now that I know the why's and why nots. I'll leave it up to others to fix!

7
incama
Re: Flaw in Thin Line Theme
  • 2004/8/14 6:57

  • incama

  • Friend of XOOPS

  • Posts: 513

  • Since: 2003/10/24


Hey Stew

Indeed you are right, we haven't defined the center block, this because we want to archive a none XOOPS blog theme. We think when adding the center block's people could instantly say, 'hey, that's Xoops!'.
Just for you (and anyone else who wants it) we have the following for you:
<?xml version="1.0" encoding="iso-8859-1"?>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="<{$xoops_langcode}>" lang="<{$xoops_langcode}>">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" />
<meta http-equiv="content-language" content="<{$xoops_langcode}>" />
<meta name="robots" content="<{$xoops_meta_robots}>" />
<meta name="Keywords" content="<{$xoops_meta_keywords}>" />
<meta name="Description" content="<{$xoops_meta_description}>" />
<meta name="rating" content="<{$xoops_meta_rating}>" />
<meta name="author" content="<{$xoops_meta_author}>" />
<meta name="copyright" content="<{$xoops_meta_copyright}>" />
<meta name="generator" content="XOOPS" />
<title><{$xoops_sitename}> - <{$xoops_pagetitle}></title>
<link href="<{$xoops_url}>/favicon.ico" rel="SHORTCUT ICON" />
<link rel="stylesheet" type="text/css" media="all" href="<{$xoops_url}>/xoops.css" />
<link rel="stylesheet" type="text/css" media="all" href="<{$xoops_themecss}>" />
<script type="text/javascript">
<!--
<{$xoops_js}>
//-->
</script>
<style type="text/css">
</style>
</head>

<body>
<table width="800" border="0" align="center" cellpadding="0" cellspacing="0">
  <tr> 
    <td id="1p1" width="150"><img src="<{$xoops_imageurl}>images/logo.gif" width="149" height="50" /></td>
    <td id="1p2"colspan="2">&nbsp;</td>
  </tr>
  <tr> 
    <td width="150" valign="top" id="2p1"> 
      <div ><{foreach item=block from=$xoops_lblocks}></div>
      <div align="left"> 
        <table width="100%" border="0" align="center" cellpadding="0" cellspacing="0">
          <tr> 
            <td class="blockTitle"><{$block.title}></td>
          </tr>
          <tr> 
            <td class="blockContent"><{$block.content}></td>
          </tr>
          <tr> 
            <td class="blockFoot">&nbsp;</td>
          </tr>
        </table>
        <{/foreach}> </div></td>
    <td valign="top" bgcolor="#F8F8F8" id="2p2"><br />
      <table width="94%" border="0" align="center" cellpadding="0" cellspacing="0">
        <tr> 
          <td id="content" valign="top"><{foreach item=block from=$xoops_ccblocks}>
            <div align="left"> 
              <table width="100%" border="0" align="center" cellpadding="0" cellspacing="0">
                <tr> 
                  <td><{$block.title}></td>
                </tr>
                <tr> 
                  <td><{$block.content}></td>
                </tr>

              </table>
              <{/foreach}> </div> </td>
        </tr>
      </table>
      <br />
      <table width="94%" border="0" align="center" cellpadding="0" cellspacing="0">
        <tr> 
          <td id="content" valign="top"><{$xoops_contents}> </td>
        </tr>
      </table>
      <br />
    </td>
    <td width="150" valign="top" id="2p3"> 
      <div ><{foreach item=block from=$xoops_rblocks}></div>
      <div align="left"> 
        <table width="100%" border="0" align="center" cellpadding="0" cellspacing="0">
          <tr> 
            <td class="blockTitleright"><{$block.title}></td>
          </tr>
          <tr> 
            <td class="blockContentright"><{$block.content}></td>
          </tr>
          <tr> 
            <td class="blockFoot">&nbsp;</td>
          </tr>
        </table>
        <{/foreach}> </div> </td>
  </tr>
  <tr> 
    <td colspan="2" valign="top" id="3p1">
<div class="weare">Powered by <a href="https://xoops.org">Xoops</a> | Designed 
        by <a href="http://www.incama.nl">Incama</a></div></td>
    <td id="3p2" width="150"><img src="<{$xoops_imageurl}>images/xt.gif" width="149" height="50" /></td>
  </tr>
</table>
</body>
</html>


This file contains the center center block.
We haven't found time yet to test it, but I'm sure you will

Greetings Incama

8
Stewdio
Re: Flaw in Thin Line Theme
  • 2004/8/14 13:48

  • Stewdio

  • Community Support Member

  • Posts: 1560

  • Since: 2003/5/7 1


Ahh, ok, I see your reasoning behind that theory of presentation. Its a good idea in principle and in fact I may actually emply that line of reasoning when I revamp my site a bit.

Thanks for the code snip, it works just fine. I think I might still use a center block as an intro to my site or something. Not sure what considerations I am going to take, but center blocks is essential to my sites design.

Thanks!

Login

Who's Online

161 user(s) are online (108 user(s) are browsing Support Forums)


Members: 0


Guests: 161


more...

Donat-O-Meter

Stats
Goal: $100.00
Due Date: Apr 30
Gross Amount: $0.00
Net Balance: $0.00
Left to go: $100.00
Make donations with PayPal!

Latest GitHub Commits