xoops forums

anderssk

Quite a regular
Posted on: 2009/8/12 17:19
anderssk
anderssk (Show more)
Quite a regular
Posts: 335
Since: 2006/3/21
#31

Re: First comments on 2.4

This is not enough
"/(^|[^]_a-z0-9-="'/:.])([a-z0-9-_.]+?)@([{$valid_chars}]+[{$end_chars}])/ei"


The local part of an email adresse (the characters before the @-sign) can contain;
* Uppercase and lowercase English letters (a-z, A-Z)
* Digits 0 through 9
* Characters ! # $ % & ' * + - / = ? ^ _ ` { | } ~
* Character . (dot, period, full stop) provided that it is not the first or last character, and provided also that it does not appear two or more times consecutively.

Same as in bug 1988039

ghia

Community Support Member
Posted on: 2009/8/12 20:37
ghia
ghia (Show more)
Community Support Member
Posts: 4954
Since: 2008/7/3 1
#32

Re: First comments on 2.4

For the www (second) pattern, maybe this:
/(^|[^]_a-z0-9-=\"'\/:\.])www\.((([a-zA-Z0-9\-]*\.){1,}){1}([a-zA-Z]{2,6}){1})((\/([a-zA-Z0-9\-\._\?\,\'\/\\+&%\$#\=~])*)*)/
The replacement must be
"'\\1<a href=\"http://www.\\2\\6\" title=\"www.\\2\\6\" rel=\"external\">'.MyTextSanitizer::truncate( 'www.\\2\\6' ).'</a>'"

For the email (fourth) pattern, maybe this:
"/(^|[^]_a-z0-9-=\"'\/:\.])([-_a-z0-9\'+*$^&%=~!?{}]++(?:\.[-_a-z0-9\'+*$^&%=~!?{}]+)*+)@((?:(?![-.])[-a-z0-9.]+(?<![-.])\.[a-z]{2,6}|\d{1,3}(?:\.\d{1,3}){3})(?::\d++)?)/ei"

The bug were you reference to is at another place (checking for registering). If it uses also a regexp, then this part could be used:
[-_a-z0-9\'+*$^&%=~!?{}]++(?:\.[-_a-z0-9\'+*$^&%=~!?{}]+)*+@(?:(?![-.])[-a-z0-9.]+(?<![-.])\.[a-z]{2,6}|\d{1,3}(?:\.\d{1,3}){3})(?::\d++)?

DuGris

Core Developer
Posted on: 2009/8/13 12:09
DuGris
DuGris (Show more)
Core Developer
Posts: 67
Since: 2004/3/14
#33

Re: First comments on 2.4

on install, this line return sql error and configuration item is not inserted

install/include/makedata.php
$dbm->insert('config'" VALUES (111, 0, 1, 'systemkey', '_MD_AM_SYSTEMKEY', '".buildXoopsSystemKey()."', '_MD_AM_SYSTEMKEYDSC', 'textbox', 'text', 99999)");

Mamba

Moderator
Posted on: 2009/8/13 12:26
Mamba
Mamba (Show more)
Moderator
Posts: 10817
Since: 2004/4/23
#34

Re: First comments on 2.4

What environment?

trabis

Core Developer
Posted on: 2009/8/13 13:53
trabis
trabis (Show more)
Core Developer
Posts: 2268
Since: 2006/9/1 1
#35

Re: First comments on 2.4

Hi ghia, the email pattern is working fine, thanks!
the www pattern is producing good link but is echoing 'myTextSanitizer...etc between > and

PS: I added /ei and seems to work fine!

DuGris

Core Developer
Posted on: 2009/8/13 13:56
DuGris
DuGris (Show more)
Core Developer
Posts: 67
Since: 2004/3/14
#36

Re: First comments on 2.4

Quote:

Mamba wrote:
What environment?


XOOPS Version XOOPS 2.4.0 Beta
PHP Version 
5.2.8
MySQL Version 
5.0.51b-community-nt
Server API Version 
apache2handler
OS Version 
WINNT


safe_mode 
Off
register_globals 
Off
magic_quotes_gpc 
Off
allow_url_fopen 
On
fsockopen 
On
allow_call_time_pass_reference 
Off
post_max_size 
8M
max_input_time 
60
output_buffering 
4096
max_execution_time 
6000
memory_limit 
128M
file_uploads 
On
upload_max_filesize 
2M

ghia

Community Support Member
Posted on: 2009/8/13 15:00
ghia
ghia (Show more)
Community Support Member
Posts: 4954
Since: 2008/7/3 1
#37

Re: First comments on 2.4

Quote:
the www pattern is producing good link but is echoing 'myTextSanitizer...etc
Use the existing replacement and change all www.\\2.\\3 to www.\\2\\6

Quote:
I added /ei and seems to work fine!

Sorry, I added only the strings/content.

djynnius

Just popping in
Posted on: 2009/8/14 20:03
djynnius
djynnius (Show more)
Just popping in
Posts: 59
Since: 2006/10/21
#38

Re: First comments on 2.4

Great seeing XOOPS 2.4! especially with the multi database capability. but i got a few questions.
1. how do you install on an alternate database (that is other than mysql) since i did not see the option in the dropdown menu while installing.

2. whats the XOOPS system key about?

DuGris

Core Developer
Posted on: 2009/8/16 19:30
DuGris
DuGris (Show more)
Core Developer
Posts: 67
Since: 2004/3/14
#39

Re: First comments on 2.4

Fixed on svn (rev 3451)

trabis

Core Developer
Posted on: 2009/8/16 20:15
trabis
trabis (Show more)
Core Developer
Posts: 2268
Since: 2006/9/1 1
#40

Re: First comments on 2.4

Quote:

trabis wrote:
Hi ghia, the email pattern is working fine, thanks!
the www pattern is producing good link but is echoing 'myTextSanitizer...etc between > and

PS: I added /ei and seems to work fine!



Added to SVN, thanks Ghia!