xoops forums

irmtfan

Module Developer
Posted on: 2012/8/31 3:03
irmtfan
irmtfan (Show more)
Module Developer
Posts: 3419
Since: 2003/12/7
#231

Re: Newbb 4.3

Alfred and Roby73:
as i wrote in the past:
Quote:

the official version is Alfred version.
He is the true developer of newbb.
Im not a developer and i dont develop this newbb module.
if you see my changes i just want to clean this newbb from:
1- hardcodes in using php commands instead of XOOPS API
2- hardcodes css like style=" and align="left/right" in php and html files
3- find minor mistypes like an extra / here and there
4- copy/paste better codes from other modules/core. eg: newbb/makepdf.php is completely re-writen.

Also you can see i emphasis all my changes with "irmtfan". i did that because i want to make it easier for anybody to implement my changes.


what i done is using the newbb/xoops API instead of other php/html commands like enhance newbb basic image functionality introduced in class/icon.php to its highest level.
in the latest revision 10136 i successfully remove all <img> html code from templates and use newbb_displayImage function instead.
There is bigger plans to implement this newbb "full customization of images" feature in the core 2.6.0 so i want to show the core team and community what can be achieved with "full customization of images"

I hope my codes will free Alfred from some extra works like cleaning codes/templates, find minor bugs, .... and could help him to continue developing more easy with more understandable templates.
IMO open developing have benefits for everybody.
I hope more people could contribute.
for example we have many good designers in xoops like playsome . one of them can create a full set of newbb templates with div only html5 and css3.

everybody in the community can contribute and help.
This newbb is very big module and we should not expect that one Alfred do everything himself.
hope i could explain .

Roby73

Friend of XOOPS
Posted on: 2012/8/31 4:25
Roby73
Roby73 (Show more)
Friend of XOOPS
Posts: 262
Since: 2011/6/15
#232

Re: Newbb 4.3

@irmtfan
Your is a big job, thanks very much.

My problem is i have in my site version of alfred 9883.
i want understand what is the best version and secure of alfred, because the forum is popolated. i don't test and find a bugs in a site in production...

In local i don't problem i use your version, and all rev of alfred.

Better and stable as 9883 what is?
I must leave this?

Thanks

irmtfan

Module Developer
Posted on: 2012/8/31 13:37
irmtfan
irmtfan (Show more)
Module Developer
Posts: 3419
Since: 2003/12/7
#233

Re: Newbb 4.3

as far as i can concern about stability and security, the latest alfred revisions are stable enough.
There are maybe a few functional bugs remains which are not important.
eg: 1- when you dont fill the edit reason it will not display the edit record
2- loading the local style.css from language
3- some notices

The main problem to announce this version as stable is IMO we dont receive much feedback from users. especially admins of xoops.org should test this newbb more and confirm the functionality.

Quote:

In local i don't problem i use your version, and all rev of alfred.

you mean your issue with more.png is solved in the latest revisions (irmtfan - Alfred) or not?
You still dont confirm it.

Roby73

Friend of XOOPS
Posted on: 2012/9/1 0:52
Roby73
Roby73 (Show more)
Friend of XOOPS
Posts: 262
Since: 2011/6/15
#234

Re: Newbb 4.3

Thanks irmtfan.

the problem of the more.png is other my error....now i find old and other templates in new newbb. sorry.

i think to use new last rev of alfred and several your code (es. show edit without edit reason ). This is my stable version and if received feedback report in discussion.

with rev 9883 i am not have problem from the user.

Thanks a lot!!

irmtfan

Module Developer
Posted on: 2012/9/8 6:00
irmtfan
irmtfan (Show more)
Module Developer
Posts: 3419
Since: 2003/12/7
#235

Re: Newbb 4.3

I hope the main developer Alfred could back and continue open developing here in sf.net svn.
As i said before with open developing community can help developer to find bugs and add new features and solutions and developer can help community to move the module forward.

you can see yourself. many bugs in newbb had been found only when we install it in xoops.org and some websites with huge community. eg: i found many bugs with the help of my website community.
Nobody can found all bugs himself and implement all solutions himself.
every single help should be welcomed to improve a module.
I still cannot understand what is wrong with the above. why a developer should do everything alone?
IMO this newbb is stable enough and is ready for release as final 4.3 version.
currently im working on a full div, and functional css templates for newbb 4.3.
I finish the newbb_thread.html and i hope i could do it in the 10 days.
because this newbb is very huge and templates are really complicated.

Roby73

Friend of XOOPS
Posted on: 2012/9/10 1:57
Roby73
Roby73 (Show more)
Friend of XOOPS
Posts: 262
Since: 2011/6/15
#236

Re: Newbb 4.3

@irmtfan

In 10159 update don't show top button.

I add in viewtopic.php
$xoopsTpl->assign('up'newbb_displayImage('up',_MD_TOP));


and add
<{$up}>&nbsp;

in template newbb_viewtopic.html in your code

<a id="threadbottom"></a><{$up}>&nbsp;<a href="#threadtop"><{$smarty.const._MD_TOP}></a>&nbsp;&nbsp;<{$previous}>&nbsp;<a href="viewtopic.php?viewmode=flat&amp;order=<{$order_current}>&amp;topic_id=<{$topic_id}>&amp;forum=<{$forum_id}>&amp;move=prev"><{$smarty.const._MD_PREVTOPIC}></a>&nbsp;&nbsp;<{$next}>&nbsp;<a href="viewtopic.php?viewmode=flat&amp;order=<{$order_current}>&amp;topic_id=<{$topic_id}>&amp;forum=<{$forum_id}>&amp;move=next"><{$smarty.const._MD_NEXTTOPIC}></a>


But the next and previous topic button don't work with seo rewrite on.
i modified link in template adding <{$xoops_url}>/modules/newbb/ in template code down and up:

<a id="threadtop"></a><{$down}>&nbsp;<a href="#threadbottom"><{$smarty.const._MD_BOTTOM}></a>&nbsp;&nbsp;<{$previous}>&nbsp;<a href="<{$xoops_url}>/modules/newbb/viewtopic.php?order=<{$order_current}>&amp;topic_id=<{$topic_id}>&amp;forum=<{$forum_id}>&amp;move=prev"><{$smarty.const._MD_PREVTOPIC}></a>&nbsp;&nbsp;<{$next}>&nbsp;<a href="<{$xoops_url}>/modules/newbb/viewtopic.php?order=<{$order_current}>&amp;topic_id=<{$topic_id}>&amp;forum=<{$forum_id}>&amp;move=next"><{$smarty.const._MD_NEXTTOPIC}></a>

irmtfan

Module Developer
Posted on: 2012/9/10 3:57
irmtfan
irmtfan (Show more)
Module Developer
Posts: 3419
Since: 2003/12/7
#237

Re: Newbb 4.3

Yes Roby73.
Im in the middle of creation of a new full div template set for newbb and i find some bugs that remain even from 3.08.
I will solve them one by one sooner or later.
you can see i correct the prev and next buttons. but i dont solve the up button yet.
I need to know the community idea what is better looking.
1- having UP - PREV - NEXT icons only
2- having UP(icon) UP(link) - PREV(icon) PREV(link) - NEXT(icon) NEXT(link) (the current look)
also please pay attention:
1- do not add a new smarty for up.
The current smarty is this:
$xoopsTpl->assign('p_up'newbb_displayImage('up',_MD_TOP));


we will use this:
<{$p_up}>

Quote:

But the next and previous topic button don't work with seo rewrite on.

Nice finding.
All links should have the full URL to work in all conditions.
it is better to add this:
<{$xoops_url}>/modules/<{$xoops_dirname}>/

i will update the irmtfan branch today with some corrections.

Roby73

Friend of XOOPS
Posted on: 2012/9/10 4:21
Roby73
Roby73 (Show more)
Friend of XOOPS
Posts: 262
Since: 2011/6/15
#238

Re: Newbb 4.3

Sorry i did not remember that smarty
$xoopsTpl->assign('p_up'newbb_displayImage('up',_MD_TOP));

already existed

Roby73

Friend of XOOPS
Posted on: 2012/9/14 1:42
Roby73
Roby73 (Show more)
Friend of XOOPS
Posts: 262
Since: 2011/6/15
#239

Re: Newbb 4.3

There is a problem with 'status' (view mode) in 'View New Posts' and in topic page.
The problem seem to be also in xoop.org forum.

irmtfan

Module Developer
Posted on: 2012/9/15 1:50
irmtfan
irmtfan (Show more)
Module Developer
Posts: 3419
Since: 2003/12/7
#240

Re: Newbb 4.3

I cannot understand the issue in 'View New Posts'
this is showing fine:
https://xoops.org/modules/newbb/viewpost.php?status=new

please explain or show us an image.