xoops forums

alfred

Quite a regular
Posted on: 2012/8/25 8:39
alfred
alfred (Show more)
Quite a regular
Posts: 249
Since: 2005/10/29
#211

Re: Newbb 4.3

Quote:

andrax wrote:
It's just my impression or we have two independent lines of work in this module?!?


newbb 4.3 to sf.net

newBB 4.4 to private SVN, later then to sf.net

irmtfan

Module Developer
Posted on: 2012/8/25 12:17
irmtfan
irmtfan (Show more)
Module Developer
Posts: 3419
Since: 2003/12/7
#212

Re: Newbb 4.3

thank you alfred.
I update my branch with some merging with your version and some updates.

download: http://www.jadoogaran.org/test255/mod ... 95_irmtfan_2012_08_25.zip

changelog from rev10095:
date2012-08-25
================================================
1Extra new lines removed from php files.
newbb/votepolls.phpnewbb/include/notification.inc.phpnewbb/class/permission.forum.phpnewbb/admin/admin_groupmod.php

2
Apply Alfred Id in the head of php files:
newbb/class/xoopsformloader.phpnewbb/votepolls.phpnewbb/class/tree.phpnewbb/topicmanager.phpnewbb/class/readtopic.php
newbb
/class/readforum.phpnewbb/class/read.phpnewbb/ratethread.phpnewbb/class/rate.phpnewbb/class/newbbtree.php
newbb
/blocks/newbb_block_tag.phpnewbb/index.phpnewbb/admin/*.php,
newbb/include/sitemap.plugin.php, newbb/include/search.inc.php, newbb/include/notification.inc.php, newbb/include/functions.user.php, 
newbb/include/module.v100.php, newbb/include/module.v220.php, newbb/include/module.php, newbb/include/functions.ini.php
newbb/include/form.forum.php,
newbb/notification_update.php, newbb/report.php, newbb/reply.php

3- Change the status of module to RC4.
newbb/xoops_version.php

4- Solve SEO (replace files from Alfred)
newbb/viewpost.php, newbb/viewtopic.php, newbb/blocks/newbb_block.php

5- Add do_latestedit config to display the latest edit (do_latestedit=0) or all edit (do_latestedit=1) by Alfred
newbb/class/post.php, newbb/include/plugin.php

6- Replace files from Alfred (better code, bug fixes, merge and develop):
newbb/class/permission.php, newbb/class/forum.php, newbb/sql/mysql.400.sql, newbb/rss.php, newbb/admin/admin_permissions.php
newbb/include/functions.image.php, newbb/include/form.post.php, newbb/viewforum.php
newbb/seo.php, newbb/post.php, newbb/search.php, newbb/docs/changelog.txt, newbb/language/german/*.php

7- Add new language definitions.
newbb/language/english/admin.php, newbb/language/english/main.php, newbb/language/persian/admin.php, newbb/language/persian/main.php, 
newbb/docs/lang_diff.txt

8- Fix Undefined variable: pseudo_height (Cesag/irmtfan)
in newbb/include/functions.image.php line 86

9- Change the default syncOnUpdate value to false. It is dangerous because it will delete all pending and deleted posts/topics/forums from database on update.
newbb/include/plugin.php

10- easier group getting - reduce queries - use Xoops API instead of directly access to db (irmtfan)
newbb/class/user.php


SVN irmtfan:
http://xoops.svn.sourceforge.net/view ... b/branches/irmtfan/newbb/
*/

Roby73

Friend of XOOPS
Posted on: 2012/8/26 1:24
Roby73
Roby73 (Show more)
Friend of XOOPS
Posts: 262
Since: 2011/6/15
#213

Re: Newbb 4.3

Quote:

alfred wrote:
Quote:

andrax wrote:
It's just my impression or we have two independent lines of work in this module?!?


newbb 4.3 to sf.net

newBB 4.4 to private SVN, later then to sf.net


i try last version in the sf.net
The small problem are:
Undefined variable: menumode nel file /modules/newbb/viewtopic.php alla linea 588
Undefined variable: menumode_other nel file /modules/newbb/viewtopic.php alla linea 589
Undefined variable: pollmodules nel file /modules/newbb/viewforum.php alla linea 99
And don't work the hide/show info box of the user.....

The config option do_latestedit, don't view edit message. seem to don't save the edit

Where is the version stable of this module?

In my site i use one fusion alfred irmtfan version.

The 4.3 in sf.net is stable?

irmtfan

Module Developer
Posted on: 2012/8/26 8:39
irmtfan
irmtfan (Show more)
Module Developer
Posts: 3419
Since: 2003/12/7
#214

Re: Newbb 4.3

I update irmtfan branch with merging the latest changes of alfred branch and fix a bug and introduce a better localized newbb style.css

changelog from alfred latest rev.10109:
date2012-08-26
================================================
1merge with alfred.
newbb/votepolls.phpnewbb/polls.phpnewbb/print.phpnewbb/seo.php

2
bug in getting $op and  typoaddmor -> addmore
newbb
/polls.php

3
better method for getting the customize/localize newbb style.css
newbb
/header.php


download:
http://www.jadoogaran.org/test255/mod ... 09_irmtfan_2012_08_26.zip

I also update the irmtfan SVN.

IMO cooperating and open developing is a win-win deal.
The xoops community can have a great developer for supporting and implementing new features to the module and the developer can have a great community for testing, debugging and feature requesting.

Roby73:
The alfred branch have still these bugs:
1bug fixedit not displayed when the reason is not filled.
2bug fixload user ranks has been wrongly linked in newbb_thread.html (black_beard reported it)


use irmtfan latest rev and report.
IMO we need more test and also some advise from Alfred about my changes.
Also it would be great if Mamba could take some time and find the root of that headers_sent() issue.

irmtfan

Module Developer
Posted on: 2012/8/27 8:12
irmtfan
irmtfan (Show more)
Module Developer
Posts: 3419
Since: 2003/12/7
#215

Re: Newbb 4.3

i update irmtfan branch with a brand new feature improve.
CSS3 buttons requested by DCrussader and now you can use that.
just change this setting in include/plugin.php:
// Display text links instead of image buttons for edit, reply, .... set true or false
$customConfig["display_text_links"] = false;

set to true and newbb is the fisrt ever xoops mlodule that can have css3 buttons.

source: http://jsfiddle.net/VTLmj/
you can customize each button like this in
newbb/templates/images/language/english/style.css (or your lang directory)
button.forum_icon#p_edit
button.forum_icon#p_edit:hover
button.forum_icon#p_edit:active
find all image names in newbb/include/images.php

download:
http://www.jadoogaran.org/test255/mod ... 09_irmtfan_2012_08_27.zip

look:
Resized Image

changelog from alfred rev.10109 (the latest is 10121):
date2012-08-27
================================================
1remove icon_path and use newbb_displayImage
newbb
/class/forum.phpnewbb/templates/newbb_index.htmlnewbb/templates/newbb_viewforum_subforum.html

2
remove icon_path and define anonym icon and use newbb_displayImage
newbb
/viewpost.phpnewbb/viewtopic.phpnewbb/include/images.phpnewbb/templates/newbb_thread.html

3
simplyify infobox and add alt and title show/hide definitions and alt key
newbb
/viewtopic.phpnewbb/templates/newbb_thread.htmlnewbb/include/js/newbb_toggle.jsnewbb/language/english/main.php newbb/docs/lang_diff.txt
newbb
/templates/images/language/english/style.css
newbb
/templates/images/icon/less.png

4
a little correctnessdot removed
newbb
/class/user.php

5
feature improvecss3 text buttons introduced and used (DCrussader/irmtfan)
newbb/class/icon.phpnewbb/templates/images/language/english/style.css class="forum_icon" id=$image_name

date
2012-08-26
================================================
1merge with alfred.
newbb/votepolls.phpnewbb/polls.phpnewbb/print.phpnewbb/seo.php

2
bug in getting $op and  typoaddmor -> addmore
newbb
/polls.php

3
better method for getting the customize/localize newbb style.css
newbb
/header.php


look newbb/docs/lang_diff.txt for language definition changes:
Version 4.3 rev.10109
----------------
main.php
---------
revise:
define('_MD_NEWBB_SEEUSERDATA','See User information');
added:
define('_MD_NEWBB_HIDEUSERDATA','Hide User information');


I also update the irmtfan SVN.
http://xoops.svn.sourceforge.net/view ... b/branches/irmtfan/newbb/

Mamba

Moderator
Posted on: 2012/8/27 8:33
Mamba
Mamba (Show more)
Moderator
Posts: 10819
Since: 2004/4/23
#216

Re: Newbb 4.3

Quote:
irmtfan branch with a brand new feature improve.
CSS3 buttons requested by DCrussader and now you can use that.

I assume, this is optional, and not as a default, right?
Our overall direction is to have a set of standard, easily recognizable set of icons, so "edit" or "delete" will be always represented by the same icon.

While there will be always few people who prefer text over image, there is truth to the saying that "picture/image is worth 1,000 words", and the research into GUI and UX shows it again and again.

Resized Image

I know that this was only an example, but having a GUI with links to Facebook and Twitter spelled out for me, instead of their icons, would not be a good direction for us, in my view.

But the good thing is that we're having modules being "locally aware", and that's a good direction.
Support XOOPS => DONATE
Use 2.5.10 | Docs | Modules | Bugs

irmtfan

Module Developer
Posted on: 2012/8/27 11:33
irmtfan
irmtfan (Show more)
Module Developer
Posts: 3419
Since: 2003/12/7
#217

Re: Newbb 4.3

Quote:

I assume, this is optional, and not as a default, right?

Mamba, i improve the feature with the help of your comments.
Honestly in this newbb version everything is optional more than core 2.6.0
I removed almost all hardcoded html, css, php commands and ...

regarding css3 buttons i implement your suggestions and now you can do everything you want.
- you can change all image buttons to text buttons with change the setting in newbb/include/plugin.php
// Display text links instead of image buttons for edit, reply, .... set true or false
$customConfig["display_text_links"] = false;

to true

OR

- you can customize each button one by one to
1- show text link or image in newbb/class/post.php
2- if show text ->
2-1- customize the text show in style.css with the help of class="forum_icon" id=$image_name
eg:
for buttons:
button.forum_icon#p_edit
button.forum_icon#p_edit:hover
button.forum_icon#p_edit:active
or for others
span.forum_icon
span.forum_icon:hover
span.forum_icon:active

2-2- leave it to just show the text

3- if show image ->
3-1- customize the image show in style.css with the help of:
img.forum_icon
img.forum_icon:hover
img.forum_icon:active

3-2- leave it to just show the image

look:
Resized Image

if you dont like the above and want to show social links with image you can do it easily.

you can show each link in image or in text or in css3 style.

download:
http://www.jadoogaran.org/test255/mod ... _irmtfan_2012_08_27_2.zip

changelog from alfred rev.10109 (the latest is 10121):
date2012-08-27 2
================================================
1improve text link instead of buttons to only show text buttons whenaalt key is set b)display is not set to true c)only buttons like replyedit
newbb
/include/functions.render.phpnewbb/class/icon.php

2
add alt key for quickreply button and remove one extra space ( ) and sort reply addpoll newtopic
newbb
/viewtopic.phpnewbb/templates/newbb_viewtopic.html

date
2012-08-27
================================================
1remove icon_path and use newbb_displayImage
newbb
/class/forum.phpnewbb/templates/newbb_index.htmlnewbb/templates/newbb_viewforum_subforum.html

2
remove icon_path and define anonym icon and use newbb_displayImage
newbb
/viewpost.phpnewbb/viewtopic.phpnewbb/include/images.phpnewbb/templates/newbb_thread.html

3
simplyify infobox and add alt and title show/hide definitions and alt key
newbb
/viewtopic.phpnewbb/templates/newbb_thread.htmlnewbb/include/js/newbb_toggle.jsnewbb/language/english/main.php newbb/docs/lang_diff.txt
newbb
/templates/images/language/english/style.css
newbb
/templates/images/icon/less.png

4
a little correctnessdot removed
newbb
/class/user.php

5
feature improvecss3 text buttons introduced and used (DCrussader/irmtfan)
newbb/class/icon.phpnewbb/templates/images/language/english/style.css class="forum_icon" id=$image_name

date
2012-08-26
================================================
1merge with alfred.
newbb/votepolls.phpnewbb/polls.phpnewbb/print.phpnewbb/seo.php

2
bug in getting $op and  typoaddmor -> addmore
newbb
/polls.php

3
better method for getting the customize/localize newbb style.css
newbb
/header.php



SVN:
http://xoops.svn.sourceforge.net/view ... b/branches/irmtfan/newbb/

Mamba

Moderator
Posted on: 2012/8/27 12:31
Mamba
Mamba (Show more)
Moderator
Posts: 10819
Since: 2004/4/23
#218

Re: Newbb 4.3

Thanks, Irmtfan.

This is the example, toward we should be going:

Resized Image

You can see here two different modules in two different languages:

News in English (top), and NewBB in German (bottom).

If both are sharing the same icons, for example for bookmarks, or for printing, then it's easy to recognize it, and first time users will have no problems finding their way in a new module.

This is also a good example of what should not happen - the PDF icon is different in both modules, and therefore will cause problems.

It also shows that we need a "Bookmarks" plugin, so the "Bookmarks" would look the same in every module. Right now News has a different implementation than NewBB.

So our goal is to have the same standard set of icons provided by Core. User (or theme designer) can provide their individual set of icons), and each module will first look for custom icons in the theme, and if not available, it will use the Core "default" icons. This would be the same process as with templates.

We just need to define the flow, i.e. where is XOOPS checking for icons first, second, and third, probably, as described in your document:

- theme
- module
- core

In my personal view, we should use as "default" icons/images, and provide "text buttons" as option, except the typical uses like "Cancel" or "Submit" on forms, etc.

I guess, it's time to provide a "Module Development Guidelines", where we spell out those kind of requirements. Of course, your Internationalization document should be part of it.
Support XOOPS => DONATE
Use 2.5.10 | Docs | Modules | Bugs

Roby73

Friend of XOOPS
Posted on: 2012/8/27 16:41
Roby73
Roby73 (Show more)
Friend of XOOPS
Posts: 262
Since: 2011/6/15
#219

Re: Newbb 4.3

@irmtfan
I test your last version.
I have installed xoops in subdirectory..
The link of the image, for hide/show info box, is wrong
correct is www.site.com/subdir/modules/ne ... ates/images/icon/more.png
but in your code www.site.com/modules/newbb/templates/images/icon/more.png
subdir don't there is.

sorry for my cryptic english

Roby73

Friend of XOOPS
Posted on: 2012/8/28 1:31
Roby73
Roby73 (Show more)
Friend of XOOPS
Posts: 262
Since: 2011/6/15
#220

Re: Newbb 4.3

@alfred

In your 4.4 rev 75 don't load style.css and function include/js/newbb_toggle.js