Quote:

newbb 4.3 to sf.net

newBB 4.4 to private SVN, later then to sf.net

thank you alfred.
I update my branch with some merging with your version and some updates.

download: http://www.jadoogaran.org/test255/modules/newbb43_rev10095_irmtfan_2012_08_25.zip

changelog from rev10095:


SVN irmtfan:
http://xoops.svn.sourceforge.net/viewvc/xoops/XoopsModules/newbb/branches/irmtfan/newbb/
*/

Quote:

i try last version in the sf.net
The small problem are:
Undefined variable: menumode nel file /modules/newbb/viewtopic.php alla linea 588
Undefined variable: menumode_other nel file /modules/newbb/viewtopic.php alla linea 589
Undefined variable: pollmodules nel file /modules/newbb/viewforum.php alla linea 99
And don't work the hide/show info box of the user.....

The config option do_latestedit, don't view edit message. seem to don't save the edit

Where is the version stable of this module?

In my site i use one fusion alfred irmtfan version.

The 4.3 in sf.net is stable?

I update irmtfan branch with merging the latest changes of alfred branch and fix a bug and introduce a better localized newbb style.css

changelog from alfred latest rev.10109:


download:
http://www.jadoogaran.org/test255/modules/newbb43_rev10109_irmtfan_2012_08_26.zip

I also update the irmtfan SVN.

IMO cooperating and open developing is a win-win deal.
The xoops community can have a great developer for supporting and implementing new features to the module and the developer can have a great community for testing, debugging and feature requesting.

Roby73:
The alfred branch have still these bugs:


use irmtfan latest rev and report.
IMO we need more test and also some advise from Alfred about my changes.
Also it would be great if Mamba could take some time and find the root of that headers_sent() issue.

i update irmtfan branch with a brand new feature improve.
CSS3 buttons requested by DCrussader and now you can use that.
just change this setting in include/plugin.php:

set to true and newbb is the fisrt ever xoops mlodule that can have css3 buttons.

source: http://jsfiddle.net/VTLmj/
you can customize each button like this in
newbb/templates/images/language/english/style.css (or your lang directory)
button.forum_icon#p_edit
button.forum_icon#p_edit:hover
button.forum_icon#p_edit:active
find all image names in newbb/include/images.php

download:
http://www.jadoogaran.org/test255/modules/newbb43_rev10109_irmtfan_2012_08_27.zip

look:


changelog from alfred rev.10109 (the latest is 10121):


look newbb/docs/lang_diff.txt for language definition changes:


I also update the irmtfan SVN.
http://xoops.svn.sourceforge.net/viewvc/xoops/XoopsModules/newbb/branches/irmtfan/newbb/

Quote:
I assume, this is optional, and not as a default, right?
Our overall direction is to have a set of standard, easily recognizable set of icons, so "edit" or "delete" will be always represented by the same icon.

While there will be always few people who prefer text over image, there is truth to the saying that "picture/image is worth 1,000 words", and the research into GUI and UX shows it again and again.



I know that this was only an example, but having a GUI with links to Facebook and Twitter spelled out for me, instead of their icons, would not be a good direction for us, in my view.

But the good thing is that we're having modules being "locally aware", and that's a good direction.

Quote:
Mamba, i improve the feature with the help of your comments.
Honestly in this newbb version everything is optional more than core 2.6.0
I removed almost all hardcoded html, css, php commands and ...

regarding css3 buttons i implement your suggestions and now you can do everything you want.
- you can change all image buttons to text buttons with change the setting in newbb/include/plugin.php

to true

OR

- you can customize each button one by one to
1- show text link or image in newbb/class/post.php
2- if show text ->
2-1- customize the text show in style.css with the help of class="forum_icon" id=$image_name
eg:
for buttons:
button.forum_icon#p_edit
button.forum_icon#p_edit:hover
button.forum_icon#p_edit:active
or for others
span.forum_icon
span.forum_icon:hover
span.forum_icon:active

2-2- leave it to just show the text

3- if show image ->
3-1- customize the image show in style.css with the help of:
img.forum_icon
img.forum_icon:hover
img.forum_icon:active

3-2- leave it to just show the image

look:


if you dont like the above and want to show social links with image you can do it easily.

you can show each link in image or in text or in css3 style.

download:
http://www.jadoogaran.org/test255/modules/newbb43_rev10109_irmtfan_2012_08_27_2.zip

changelog from alfred rev.10109 (the latest is 10121):



SVN:
http://xoops.svn.sourceforge.net/viewvc/xoops/XoopsModules/newbb/branches/irmtfan/newbb/

Thanks, Irmtfan.

This is the example, toward we should be going:



You can see here two different modules in two different languages:

News in English (top), and NewBB in German (bottom).

If both are sharing the same icons, for example for bookmarks, or for printing, then it's easy to recognize it, and first time users will have no problems finding their way in a new module.

This is also a good example of what should not happen - the PDF icon is different in both modules, and therefore will cause problems.

It also shows that we need a "Bookmarks" plugin, so the "Bookmarks" would look the same in every module. Right now News has a different implementation than NewBB.

So our goal is to have the same standard set of icons provided by Core. User (or theme designer) can provide their individual set of icons), and each module will first look for custom icons in the theme, and if not available, it will use the Core "default" icons. This would be the same process as with templates.

We just need to define the flow, i.e. where is XOOPS checking for icons first, second, and third, probably, as described in your document:

- theme
- module
- core

In my personal view, we should use as "default" icons/images, and provide "text buttons" as option, except the typical uses like "Cancel" or "Submit" on forms, etc.

I guess, it's time to provide a "Module Development Guidelines", where we spell out those kind of requirements. Of course, your Internationalization document should be part of it.

@irmtfan
I test your last version.
I have installed xoops in subdirectory..
The link of the image, for hide/show info box, is wrong
correct is http://www.site.com/subdir/modules/newbb/templates/images/icon/more.png
but in your code http://www.site.com/modules/newbb/templates/images/icon/more.png
subdir don't there is.

sorry for my cryptic english

@alfred

In your 4.4 rev 75 don't load style.css and function include/js/newbb_toggle.js